[review] Convert int to bool in agent.c
Commit Message
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/462
......................................................................
Convert int to bool in agent.c
Also moves an int declaration inside the for loop.
Code cleanup, no change in behavior intended.
gdb/ChangeLog:
2019-10-30 Christian Biesinger <cbiesinger@google.com>
* gdbsupport/agent.c (debug_agent): Change type to bool.
(use_agent): Likewise.
(all_agent_symbols_look_up): Likewise.
(agent_loaded_p): Change return value to bool.
(agent_look_up_symbols): Update.
(agent_capability_check): Change return value to bool.
* gdbsupport/agent.h (agent_loaded_p): Likewise.
(debug_agent): Change type to bool.
(use_agent): Likewise.
(agent_capability_check): Change return value to bool.
gdb/gdbserver/ChangeLog:
2019-10-30 Christian Biesinger <cbiesinger@google.com>
* ax.h (debug_agent): Remove duplicate declaration.
Change-Id: Icb28a65fcc8c7108bcd59287e6be66bf56f8ccb5
---
M gdb/gdbserver/ax.h
M gdb/gdbsupport/agent.c
M gdb/gdbsupport/agent.h
3 files changed, 13 insertions(+), 16 deletions(-)
Comments
Luis Machado has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/462
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Looks good to me, except for the nit pointed out. Thanks!
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/462/1/gdb/gdbsupport/agent.c
File gdb/gdbsupport/agent.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/462/1/gdb/gdbsupport/agent.c@48
PS1, Line 48:
43 | }
44 |
45 | #define DEBUG_AGENT debug_agent_printf
46 |
47 | /* Global flag to determine using agent or not. */
48 > bool use_agent = 0;
49 |
50 | /* Addresses of in-process agent's symbols both GDB and GDBserver cares
51 | about. */
52 |
53 | struct ipa_sym_addresses_common
Likewise make it "false"?
Christian Biesinger has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/462
......................................................................
Uploaded patch set 2.
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/462/1/gdb/gdbsupport/agent.c
File gdb/gdbsupport/agent.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/462/1/gdb/gdbsupport/agent.c@48
PS1, Line 48:
43 | }
44 |
45 | #define DEBUG_AGENT debug_agent_printf
46 |
47 | /* Global flag to determine using agent or not. */
48 > bool use_agent = 0;
49 |
50 | /* Addresses of in-process agent's symbols both GDB and GDBserver cares
51 | about. */
52 |
53 | struct ipa_sym_addresses_common
> Likewise make it "false"?
Oops, thanks. Fixed.
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/462
......................................................................
Patch Set 2:
Thanks, this LGTM.
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/462
......................................................................
Patch Set 2: Code-Review+2
@@ -22,7 +22,6 @@
#include "regcache.h"
#ifdef IN_PROCESS_AGENT
-extern int debug_agent;
#define debug_threads debug_agent
#endif
@@ -26,7 +26,7 @@
#define IPA_SYM_STRUCT_NAME ipa_sym_addresses_common
#include "agent.h"
-int debug_agent = 0;
+bool debug_agent = false;
/* A stdarg wrapper for debug_vprintf. */
@@ -45,7 +45,7 @@
#define DEBUG_AGENT debug_agent_printf
/* Global flag to determine using agent or not. */
-int use_agent = 0;
+bool use_agent = 0;
/* Addresses of in-process agent's symbols both GDB and GDBserver cares
about. */
@@ -73,9 +73,9 @@
static struct ipa_sym_addresses_common ipa_sym_addrs;
-static int all_agent_symbols_looked_up = 0;
+static bool all_agent_symbols_looked_up = false;
-int
+bool
agent_loaded_p (void)
{
return all_agent_symbols_looked_up;
@@ -87,11 +87,9 @@
int
agent_look_up_symbols (void *arg)
{
- int i;
+ all_agent_symbols_looked_up = false;
- all_agent_symbols_looked_up = 0;
-
- for (i = 0; i < sizeof (symbol_list) / sizeof (symbol_list[0]); i++)
+ for (int i = 0; i < sizeof (symbol_list) / sizeof (symbol_list[0]); i++)
{
CORE_ADDR *addrp =
(CORE_ADDR *) ((char *) &ipa_sym_addrs + symbol_list[i].offset);
@@ -105,7 +103,7 @@
}
}
- all_agent_symbols_looked_up = 1;
+ all_agent_symbols_looked_up = true;
return 0;
}
@@ -260,7 +258,7 @@
/* Return true if agent has capability AGENT_CAP, otherwise return false. */
-int
+bool
agent_capability_check (enum agent_capa agent_capa)
{
if (agent_capability == 0)
@@ -269,7 +267,7 @@
&agent_capability))
warning (_("Error reading capability of agent"));
}
- return agent_capability & agent_capa;
+ return (agent_capability & agent_capa) != 0;
}
/* Invalidate the cache of agent capability, so we'll read it from inferior
@@ -42,11 +42,11 @@
thread. */
#define IPA_CMD_BUF_SIZE 1024
-int agent_loaded_p (void);
+bool agent_loaded_p (void);
-extern int debug_agent;
+extern bool debug_agent;
-extern int use_agent;
+extern bool use_agent;
/* Capability of agent. Different agents may have different capabilities,
such as installing fast tracepoint or evaluating breakpoint conditions.
@@ -61,7 +61,7 @@
AGENT_CAPA_STATIC_TRACE = (0x1 << 1),
};
-int agent_capability_check (enum agent_capa);
+bool agent_capability_check (enum agent_capa);
void agent_capability_invalidate (void);