Message ID | gerrit.1571461310000.I1fbb39c32009c61c862b6bd56ce12f24a9edb2c4@gnutoolchain-gerrit.osci.io |
---|---|
State | New, archived |
Headers |
Received: (qmail 89931 invoked by alias); 19 Oct 2019 05:01:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 89918 invoked by uid 89); 19 Oct 2019 05:01:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=2019-10-19, symfile.c, UD:symfile.c, symfilec X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 19 Oct 2019 05:01:57 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 6B026206FC; Sat, 19 Oct 2019 01:01:55 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 67123204F8; Sat, 19 Oct 2019 01:01:51 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 32F7920AF6; Sat, 19 Oct 2019 01:01:51 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Sat, 19 Oct 2019 01:01:51 -0400 From: "Sergio Durigan Junior (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io> To: gdb-patches@sourceware.org Cc: Sergio Durigan Junior <sergiodj@redhat.com> Message-ID: <gerrit.1571461310000.I1fbb39c32009c61c862b6bd56ce12f24a9edb2c4@gnutoolchain-gerrit.osci.io> Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange Subject: [review] Fix typo in symfile.c X-Gerrit-Change-Id: I1fbb39c32009c61c862b6bd56ce12f24a9edb2c4 X-Gerrit-Change-Number: 161 X-Gerrit-ChangeURL: <https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161> X-Gerrit-Commit: d6eb6bd0715b4bdeaf567177d6ccba6bf441654e References: <gerrit.1571461310000.I1fbb39c32009c61c862b6bd56ce12f24a9edb2c4@gnutoolchain-gerrit.osci.io> Reply-To: sergiodj@redhat.com, sergiodj@redhat.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 |
Commit Message
Simon Marchi (Code Review)
Oct. 19, 2019, 5:01 a.m. UTC
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161 ...................................................................... Fix typo in symfile.c This commit fixes a simple typo in gdb/symfile.c. s/wether/whether/. 2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com> * symfile.c (init_entry_point_info): Fix typo. Change-Id: I1fbb39c32009c61c862b6bd56ce12f24a9edb2c4 --- M gdb/symfile.c 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161 ...................................................................... Patch Set 1: (1 comment) This is a test. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161/1/gdb/symfile.c File gdb/symfile.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161/1/gdb/symfile.c@911 PS1, Line 911: an extra symbol file such as dynamically loaded code, and whether Test comment while there's only v1.
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161
......................................................................
Patch Set 2:
(1 comment)
This is a test comment.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161/1/gdb/symfile.c
File gdb/symfile.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161/1/gdb/symfile.c@911
PS1, Line 911: an extra symbol file such as dynamically loaded code, and whether
> Test comment while there's only v1.
Test comment in v1 after v2 has been uploaded.
Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161 ...................................................................... Patch Set 2: Code-Review+2
Sergio Durigan Junior has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161 ...................................................................... Patch Set 3: This is a test comment.
Sergio Durigan Junior has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161 ...................................................................... Patch Set 3: This is another test comment. Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I1fbb39c32009c61c862b6bd56ce12f24a9edb2c4 Gerrit-Change-Number: 161 Gerrit-PatchSet: 3 Gerrit-Owner: Sergio Durigan Junior <sergiodj@redhat.com> Gerrit-Reviewer: Sergio Durigan Junior <sergiodj@redhat.com> Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca> Gerrit-Comment-Date: Wed, 23 Oct 2019 22:00:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Sergio Durigan Junior has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161 ...................................................................... Patch Set 3: On Wednesday, October 23 2019, Sergio Durigan Junior wrote: And this is a test reply, sent by e-mail. Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I1fbb39c32009c61c862b6bd56ce12f24a9edb2c4 Gerrit-Change-Number: 161 Gerrit-PatchSet: 3 Gerrit-Owner: Sergio Durigan Junior <sergiodj@redhat.com> Gerrit-Reviewer: Sergio Durigan Junior <sergiodj@redhat.com> Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca> Gerrit-Comment-Date: Wed, 23 Oct 2019 22:02:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Sergio Durigan Junior has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161 ...................................................................... Patch Set 3: This is a change with a very long line that doesn't wrap here but should wrap automatically in the email message when gerrit sends it through the SMTP server configured in the config file, yes.
diff --git a/gdb/symfile.c b/gdb/symfile.c index 82081b1..f74c6de 100644 --- a/gdb/symfile.c +++ b/gdb/symfile.c @@ -908,7 +908,7 @@ corresponding BFD section index, or -1 if the section was not found. ADD_FLAGS encodes verbosity level, whether this is main symbol or - an extra symbol file such as dynamically loaded code, and wether + an extra symbol file such as dynamically loaded code, and whether breakpoint reset should be deferred. */ static void