Message ID | 1412082645-30629-1-git-send-email-yao@codesourcery.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 28381 invoked by alias); 30 Sep 2014 13:15:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 28288 invoked by uid 89); 30 Sep 2014 13:15:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Sep 2014 13:15:13 +0000 Received: from svr-orw-fem-04.mgc.mentorg.com ([147.34.97.41]) by relay1.mentorg.com with esmtp id 1XYxGo-0004Je-Hc from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Tue, 30 Sep 2014 06:15:10 -0700 Received: from qiyao.dyndns.org.com (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.3.181.6; Tue, 30 Sep 2014 06:15:10 -0700 From: Yao Qi <yao@codesourcery.com> To: <gdb-patches@sourceware.org> Subject: [PATCH] Skip server-kill.exp on remote target Date: Tue, 30 Sep 2014 21:10:45 +0800 Message-ID: <1412082645-30629-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes |
Commit Message
Yao Qi
Sept. 30, 2014, 1:10 p.m. UTC
Hi, We see the following fail in the real remote testing... (gdb) Executing on target: kill -9 29808 (timeout = 300) spawn [open ...]^M sh: 1: kill: No such process XYZ1ZYX tstatus^M Trace can not be run on this target.^M (gdb) FAIL: gdb.server/server-kill.exp: tstatus The test tries to kill gdbserver in this way: set server_pid [exp_pid -i [board_info target fileid]] remote_exec target "kill -9 $server_pid" in native testing, we'll get the pid of spawned gdbserver, however, in remote testing, we'll get the pid of ssh session, since we start gdbserver on the remote target through ssh. The pid on build doesn't exist on target. I thought about different ways to handle remote target, for example: - use command ps on remote target to gdbserver pid, but it doesn't work if we have multiple gdbserver instances during testing, - port number can be regarded as an id to differentiate different instances, but port number is unknown to each test case. Likewise, we can't use 'pkill' due to the same reason. - close the gdbserver channel, but gdbserver doesn't exit on the target, then, I have to skip this test for remote target. gdb/testsuite: 2014-09-30 Yao Qi <yao@codesourcery.com> * gdb.server/server-kill.exp: Skip it if the target is remote. --- gdb/testsuite/gdb.server/server-kill.exp | 5 +++++ 1 file changed, 5 insertions(+)
Comments
Yao Qi <yao@codesourcery.com> writes: > gdb/testsuite: > > 2014-09-30 Yao Qi <yao@codesourcery.com> > > * gdb.server/server-kill.exp: Skip it if the target is remote. Ping.
On 09/30/2014 02:10 PM, Yao Qi wrote: > I thought about different ways to handle remote target, for example: > > - use command ps on remote target to gdbserver pid, but it doesn't work > if we have multiple gdbserver instances during testing, > - port number can be regarded as an id to differentiate different > instances, but port number is unknown to each test case. Likewise, > we can't use 'pkill' due to the same reason. > - close the gdbserver channel, but gdbserver doesn't exit on the target, gdbserver will be the parent of the tested process. So how about tweaking the test program to do: int server_pid; int main () { server_pid = getppid (); } and then simply read "server_pid" out of the inferior ? Thanks, Pedro Alves
Pedro Alves <palves@redhat.com> writes: > gdbserver will be the parent of the tested process. So how about > tweaking the test program to do: > > int server_pid; > > int main () > { > server_pid = getppid (); > } > > and then simply read "server_pid" out of the inferior ? That is a good idea! Patch 2/3 is about this. Patch 1/3 is a clean up. Patch 3/3 is to fix a fail we've seen on target doesn't support tracepoint. *** BLURB HERE *** Yao Qi (3): Clean up server-kill.exp Get GDBserver pid on remote target Use command "monitor set debug 0" to check the connection gdb/testsuite/gdb.server/server-kill.c | 10 +++++++++- gdb/testsuite/gdb.server/server-kill.exp | 23 +++++++++++++++++------ 2 files changed, 26 insertions(+), 7 deletions(-)
Yao Qi <yao@codesourcery.com> writes: > That is a good idea! Patch 2/3 is about this. Patch 1/3 is a clean > up. Patch 3/3 is to fix a fail we've seen on target doesn't support > tracepoint. These three patches are pushed in.
diff --git a/gdb/testsuite/gdb.server/server-kill.exp b/gdb/testsuite/gdb.server/server-kill.exp index 5d31103..45af850 100644 --- a/gdb/testsuite/gdb.server/server-kill.exp +++ b/gdb/testsuite/gdb.server/server-kill.exp @@ -23,6 +23,11 @@ if {[skip_gdbserver_tests]} { return 0 } +# We can't get the pid of gdbserver on the remote target. +if [is_remote target] then { + return 0 +} + if { [prepare_for_testing ${testfile}.exp ${testfile}] } { return -1 }