diff mbox

Small typo in iconv.m4

Message ID 1a59139c-804c-2cc5-821b-edabd3ba9f84@mentor.com
State New, archived
Headers

Commit Message

Hafiz Abid Qadeer Nov. 9, 2018, 10:18 a.m. UTC 
  Hi All,
Attached config/ patch was approved and committed in gcc repo. Ok to
commit it in the binutils-gdb repo?

2018-11-09  Hafiz Abid Qadeer  <abidh@codesourcery.com>

	* config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
	Append $INCICONV to it.
	* gdb/configure: Regenerate.
	* binutils/configure: Likewise.
	* intl/configure: Likewise.

Thanks,

Comments

Nick Clifton Nov. 9, 2018, 12:59 p.m. UTC | #1 
Hi Hafiz,

> Hi All,
> Attached config/ patch was approved and committed in gcc repo. Ok to
> commit it in the binutils-gdb repo?
> 
> 2018-11-09  Hafiz Abid Qadeer  <abidh@codesourcery.com>
> 
> 	* config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
> 	Append $INCICONV to it.
> 	* gdb/configure: Regenerate.
> 	* binutils/configure: Likewise.
> 	* intl/configure: Likewise.

Approved, please apply.  I should note however that the changelog
entry probably should be split up and added to the respective
subdirectories ChangeLog files.  In particular I was confused because
I could not find a mention on the change in gcc's config/ChangeLog
file, and was rather surprised when I found it in the top level 
ChangeLog file instead.

Cheers
  Nick
diff mbox

Patch

diff --git a/config/iconv.m4 b/config/iconv.m4
index 5f9304a6ba..f1e54c5aed 100644
--- a/config/iconv.m4
+++ b/config/iconv.m4
@@ -73,7 +73,7 @@  AC_DEFUN([AM_ICONV_LINK],
     if test "$am_cv_func_iconv" != yes; then
       am_save_CPPFLAGS="$CPPFLAGS"
       am_save_LIBS="$LIBS"
-      CPPFLAGS="$LIBS $INCICONV"
+      CPPFLAGS="$CPPFLAGS $INCICONV"
       LIBS="$LIBS $LIBICONV"
       AC_TRY_LINK([#include <stdlib.h>
 #include <iconv.h>],