Message ID | 20180730152844.21999-1-abrodkin@synopsys.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 113367 invoked by alias); 30 Jul 2018 15:28:52 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 113356 invoked by uid 89); 30 Jul 2018 15:28:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtprelay.synopsys.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1532964529; bh=UEi2QSUpg5DkZkQdR3Y8CRkOswlKYY6nsa+gTplpXUg=; h=From:To:Cc:Subject:Date:From; b=SyruJfY3+s7FQSZhdu18wgn1PRpug01iAUk+0Z1d4bQVbYqvcx1A9MvIK5ruJx3w5 vSmXjw2NhUk0kU9J5TAYOnSUnTqsThA8TboJLUQqM0VwFOnsiUo6XQLxbHWY8Vvwmj ZEciLW3emVwV37PBJLTg0pK33QapJF2ju0e7+6iM2/Wa7d0m+bGZkgv55/NX1TNnOa VQJf4OaPE7zBnLLX01CV9a9HUb0u0W5/tn2LDBuCiQvLCT+VmnemNvXLS2m2eiJ8sQ k8fFmAfZF6YkTIQSy8vUtANyORS8hGBVG7ek1pdv9vjmThMCKtfs2IFttTlkx78PAI /wfditDkxHQrQ== From: Alexey Brodkin <Alexey.Brodkin@synopsys.com> To: libc-alpha@sourceware.org Cc: linux-snps-arc@lists.infradead.org, Alexey Brodkin <Alexey.Brodkin@synopsys.com> Subject: [PATCH] tst-tzset: raise timeout to 10 seconds Date: Mon, 30 Jul 2018 18:28:44 +0300 Message-Id: <20180730152844.21999-1-abrodkin@synopsys.com> |
Commit Message
Alexey Brodkin
July 30, 2018, 3:28 p.m. UTC
On ARC HSDK board even though it operates @ 1GHz this test runs ~7 seconds which gives us failures all the time. That's what happens now: | # time .../build/timezone/tst-tzset | Timed out: killed the child process | Command exited with non-zero status 1 | real 0m 5.11s | user 0m 3.59s | sys 0m 1.45s And that's what happens with longer time-out: | # time .../build/timezone/tst-tzset | real 0m 6.95s | user 0m 4.97s | sys 0m 1.99s | | # echo $? | 0 --- timezone/tst-tzset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Mon, 30 Jul 2018, Alexey Brodkin wrote: > diff --git a/timezone/tst-tzset.c b/timezone/tst-tzset.c > index 27f986b56dab..534f7acdf75f 100644 > --- a/timezone/tst-tzset.c > +++ b/timezone/tst-tzset.c > @@ -25,7 +25,7 @@ > #include <time.h> > #include <unistd.h> > > -#define TIMEOUT 5 > +#define TIMEOUT 10 The timeout was set to 5 in commit 112f28e88c4ea5afbd6050e71416a23db11e4adc to increase it from a default 2 seconds. That was before the default timeout was changed to 20 seconds in commit a28605b22946c708f0a5c4f06307e1a17650ced8. In such cases I think we should remove the timeout setting - explicit timeouts less than the default are only appropriate where there is a strong reason to want to *decrease* the default timeout.
On Jul 30 2018, Joseph Myers <joseph@codesourcery.com> wrote: > On Mon, 30 Jul 2018, Alexey Brodkin wrote: > >> diff --git a/timezone/tst-tzset.c b/timezone/tst-tzset.c >> index 27f986b56dab..534f7acdf75f 100644 >> --- a/timezone/tst-tzset.c >> +++ b/timezone/tst-tzset.c >> @@ -25,7 +25,7 @@ >> #include <time.h> >> #include <unistd.h> >> >> -#define TIMEOUT 5 >> +#define TIMEOUT 10 > > The timeout was set to 5 in commit > 112f28e88c4ea5afbd6050e71416a23db11e4adc to increase it from a default 2 > seconds. That was before the default timeout was changed to 20 seconds in > commit a28605b22946c708f0a5c4f06307e1a17650ced8. In such cases I think we > should remove the timeout setting - explicit timeouts less than the > default are only appropriate where there is a strong reason to want to > *decrease* the default timeout. There are a lot of tests that set TIMEOUT to less than 20. Andreas.
On 07/30/2018 06:07 PM, Andreas Schwab wrote: > On Jul 30 2018, Joseph Myers <joseph@codesourcery.com> wrote: > >> On Mon, 30 Jul 2018, Alexey Brodkin wrote: >> >>> diff --git a/timezone/tst-tzset.c b/timezone/tst-tzset.c >>> index 27f986b56dab..534f7acdf75f 100644 >>> --- a/timezone/tst-tzset.c >>> +++ b/timezone/tst-tzset.c >>> @@ -25,7 +25,7 @@ >>> #include <time.h> >>> #include <unistd.h> >>> >>> -#define TIMEOUT 5 >>> +#define TIMEOUT 10 >> >> The timeout was set to 5 in commit >> 112f28e88c4ea5afbd6050e71416a23db11e4adc to increase it from a default 2 >> seconds. That was before the default timeout was changed to 20 seconds in >> commit a28605b22946c708f0a5c4f06307e1a17650ced8. In such cases I think we >> should remove the timeout setting - explicit timeouts less than the >> default are only appropriate where there is a strong reason to want to >> *decrease* the default timeout. > > There are a lot of tests that set TIMEOUT to less than 20. We should fix all of them. Thanks, Florian
On Mon, 30 Jul 2018, Florian Weimer wrote: > > There are a lot of tests that set TIMEOUT to less than 20. > > We should fix all of them. It's conceivable some are deliberately less than 20 (if e.g. the test sleeps for a certain number of seconds and does nothing else that should take a significant amount of time), but certainly in the absence of a reason for a short timeout I think such settings should be removed.
diff --git a/timezone/tst-tzset.c b/timezone/tst-tzset.c index 27f986b56dab..534f7acdf75f 100644 --- a/timezone/tst-tzset.c +++ b/timezone/tst-tzset.c @@ -25,7 +25,7 @@ #include <time.h> #include <unistd.h> -#define TIMEOUT 5 +#define TIMEOUT 10 static int do_test (void); #define TEST_FUNCTION do_test () #include "../test-skeleton.c"