Return bytes for tdesc_register_size()
Commit Message
tdesc_register_size returns number of bits.
Change this to use bytes, the same as regcache::register_size, memcpy and sizeof.
This fixes a bug in aarch64_get_tdesc_vq which assumed bytes.
Update all other calls to tdesc_register_size.
I originally planned to fix aarch64_get_tdesc_vq and push as OBV.
However, this seemed the better fix.
Required for 8.2
Tested with make check on a target all build.
I don't have a rs6000 machine, however change is simple enough.
2018-07-10 Alan Hayward <alan.hayward@arm.com>
* target-descriptions.c (tdesc_register_size): Return bytes.
* target-descriptions.h (tdesc_register_size): Update comment.
* rs6000-tdep.c (rs6000_gdbarch_init): Assume bytes.
---
gdb/rs6000-tdep.c | 4 ++--
gdb/target-descriptions.c | 4 ++--
gdb/target-descriptions.h | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
Comments
On 2018-07-10 11:05 AM, Alan Hayward wrote:
> tdesc_register_size returns number of bits.
> Change this to use bytes, the same as regcache::register_size, memcpy and sizeof.
>
> This fixes a bug in aarch64_get_tdesc_vq which assumed bytes.
>
> Update all other calls to tdesc_register_size.
>
> I originally planned to fix aarch64_get_tdesc_vq and push as OBV.
> However, this seemed the better fix.
> Required for 8.2
> Tested with make check on a target all build.
> I don't have a rs6000 machine, however change is simple enough.
Hi Alan,
Since I work with processors that have 16-bit bytes, I always prefer
expressing sizes in bits, otherwise it's ambiguous. Are we talking
about 8-bit bytes or target-sized bytes? So I would have perhaps
chosen to rename tdesc_register_size to tdesc_register_size_bits
(for clarity) and fix up the caller.
Would you be ok with that? Other than that, the patch looks fine.
Simon
@@ -5953,7 +5953,7 @@ rs6000_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
have_mq = tdesc_numbered_register (feature, tdesc_data, PPC_MQ_REGNUM,
"mq");
- tdesc_wordsize = tdesc_register_size (feature, "pc") / 8;
+ tdesc_wordsize = tdesc_register_size (feature, "pc");
if (wordsize == -1)
wordsize = tdesc_wordsize;
@@ -5984,7 +5984,7 @@ rs6000_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
/* The fpscr register was expanded in isa 2.05 to 64 bits
along with the addition of the decimal floating point
facility. */
- if (tdesc_register_size (feature, "fpscr") > 32)
+ if (tdesc_register_size (feature, "fpscr") > 4)
have_dfp = 1;
}
else
@@ -813,7 +813,7 @@ tdesc_numbered_register_choices (const struct tdesc_feature *feature,
}
/* Search FEATURE for a register named NAME, and return its size in
- bits. The register must exist. */
+ bytes. The register must exist. */
int
tdesc_register_size (const struct tdesc_feature *feature,
@@ -822,7 +822,7 @@ tdesc_register_size (const struct tdesc_feature *feature,
struct tdesc_reg *reg = tdesc_find_register_early (feature, name);
gdb_assert (reg != NULL);
- return reg->bitsize;
+ return reg->bitsize / 8;
}
/* Look up a register by its GDB internal register number. */
@@ -123,7 +123,7 @@ int tdesc_unnumbered_register (const struct tdesc_feature *feature,
const char *name);
/* Search FEATURE for a register named NAME, and return its size in
- bits. The register must exist. */
+ bytes. The register must exist. */
int tdesc_register_size (const struct tdesc_feature *feature,
const char *name);