Message ID | 20170608225728.26779-3-rth@twiddle.net |
---|---|
State | New, archived |
Headers |
Received: (qmail 107443 invoked by alias); 8 Jun 2017 22:57:35 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 107341 invoked by uid 89); 8 Jun 2017 22:57:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL, BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qt0-f174.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=xY744g8kTHIJDjrSnFVAHju91Ooae4ab1EYIBhmY+9s=; b=eCnXGHr10afZhO5wjKLWEonEdf8seAjeB1YscC7zgiu4CvqchL5Vwp1MrLCbF1Co17 DOWr7JgAKJtNAHyNRNUqdUDuqIOKXTDFpkZhwKQpx1pDBhlRLJxk0gLkkQe9620Dhaua aUhm5uRGd3xKynQYHC4oAdcGQ0Hfxaw+5q2NbJBm3qXWR6DZlB1YmVa4G+12Vd8RbW4X DVtdoNgGCJ9X9bkQicB9nis74bVCAm5VLxqzXqMtaer4L/aDiSZmAWJkl9DFbWl6zfkJ Zcn7xbBfMkM0IhKidxm7po7KoTQHK43HlUALSf7Ba6kFsciBWPyPAIRSHHrOpQt8e8Om T4LQ== X-Gm-Message-State: AODbwcDCjXfgBQDcE2rtsWdjn5hdZTo12nxbLm6wX8mZ23nGCIclzbfc zVrEW7YKC+nO0EKc9UY= X-Received: by 10.55.127.199 with SMTP id a190mr49778784qkd.100.1496962655872; Thu, 08 Jun 2017 15:57:35 -0700 (PDT) From: Richard Henderson <rth@twiddle.net> To: libc-alpha@sourceware.org Subject: [PATCH 2/3] Add hidden_proto for getauxval Date: Thu, 8 Jun 2017 15:57:27 -0700 Message-Id: <20170608225728.26779-3-rth@twiddle.net> In-Reply-To: <20170608225728.26779-1-rth@twiddle.net> References: <20170608225728.26779-1-rth@twiddle.net> |
Commit Message
Richard Henderson
June 8, 2017, 10:57 p.m. UTC
--- include/sys/auxv.h | 2 ++ misc/getauxval.c | 1 + 2 files changed, 3 insertions(+)
Comments
On Friday 09 June 2017 04:27 AM, Richard Henderson wrote: > --- > include/sys/auxv.h | 2 ++ > misc/getauxval.c | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/include/sys/auxv.h b/include/sys/auxv.h > index dede2c3..2e1f86b 100644 > --- a/include/sys/auxv.h > +++ b/include/sys/auxv.h > @@ -1 +1,3 @@ > #include <misc/sys/auxv.h> > + > +libc_hidden_proto (getauxval) > diff --git a/misc/getauxval.c b/misc/getauxval.c > index c83fbce..458f58d 100644 > --- a/misc/getauxval.c > +++ b/misc/getauxval.c > @@ -43,3 +43,4 @@ __getauxval (unsigned long int type) > } > > weak_alias (__getauxval, getauxval) > +libc_hidden_weak (getauxval) This is fine, but you could just merge this into 3/3 (where this gets used first), which I won't review since I haven't looked at a powerpc box in anger for years :) Siddhesh
On 06/09/2017 12:57 AM, Richard Henderson wrote:
> +libc_hidden_weak (getauxval)
This should be libc_hidden_proto (__getauxval). I don't think you can
call getauxval from libc.so because it leads to a namespace violation.
Thanks,
Florian
On 06/08/2017 11:58 PM, Florian Weimer wrote: > On 06/09/2017 12:57 AM, Richard Henderson wrote: >> +libc_hidden_weak (getauxval) > > This should be libc_hidden_proto (__getauxval). I don't think you can > call getauxval from libc.so because it leads to a namespace violation. From libc.so you certainly can, because we'll actually call __GI_getauxval. r~
On 06/09/2017 07:45 PM, Richard Henderson wrote: > On 06/08/2017 11:58 PM, Florian Weimer wrote: >> On 06/09/2017 12:57 AM, Richard Henderson wrote: >>> +libc_hidden_weak (getauxval) >> >> This should be libc_hidden_proto (__getauxval). I don't think you can >> call getauxval from libc.so because it leads to a namespace violation. > > From libc.so you certainly can, because we'll actually call __GI_getauxval. Yes, but not from libc.a, which is better to have the hidden alias for the __ variant. Florian
On 06/09/2017 10:49 AM, Florian Weimer wrote: > On 06/09/2017 07:45 PM, Richard Henderson wrote: >> On 06/08/2017 11:58 PM, Florian Weimer wrote: >>> On 06/09/2017 12:57 AM, Richard Henderson wrote: >>>> +libc_hidden_weak (getauxval) >>> >>> This should be libc_hidden_proto (__getauxval). I don't think you can >>> call getauxval from libc.so because it leads to a namespace violation. >> >> From libc.so you certainly can, because we'll actually call __GI_getauxval. > > Yes, but not from libc.a, which is better to have the hidden alias for > the __ variant. Quite right. r~
diff --git a/include/sys/auxv.h b/include/sys/auxv.h index dede2c3..2e1f86b 100644 --- a/include/sys/auxv.h +++ b/include/sys/auxv.h @@ -1 +1,3 @@ #include <misc/sys/auxv.h> + +libc_hidden_proto (getauxval) diff --git a/misc/getauxval.c b/misc/getauxval.c index c83fbce..458f58d 100644 --- a/misc/getauxval.c +++ b/misc/getauxval.c @@ -43,3 +43,4 @@ __getauxval (unsigned long int type) } weak_alias (__getauxval, getauxval) +libc_hidden_weak (getauxval)