localedata: bs_BA: fix yesexpr/noexpr [BZ #20974]
Commit Message
Both regexes end with a "*." which means the previous match can be
omitted, and then the . allows them to match any input at all.
This means tools like coreutils' `rm -i` will always delete things
when prompted because the yesexpr regex matches all inputs (even
the negative ones).
2016-12-15 Mike Frysinger <vapier@gentoo.org>
[BZ #20974]
* localedata/bs_BA (LC_MESSAGES): Delete "*." from the end of
yesexpr and noexpr.
---
localedata/locales/bs_BA | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 15 Dec 2016 18:35, Mike Frysinger wrote:
> Both regexes end with a "*." which means the previous match can be
> omitted, and then the . allows them to match any input at all.
>
> This means tools like coreutils' `rm -i` will always delete things
> when prompted because the yesexpr regex matches all inputs (even
> the negative ones).
meant to include this, but here's the diff made readable:
-yesexpr "^[+1dDyY]*."
-noexpr "^[-0nN]*."
+yesexpr "^[+1dDyY]"
+noexpr "^[-0nN]"
-mike
Mike,
16.12.2016 19:09 Mike Frysinger <vapier@gentoo.org> wrote:
>
>
> On 15 Dec 2016 18:35, Mike Frysinger wrote:
> > Both regexes end with a "*." which means the previous match can be
> > omitted, and then the . allows them to match any input at all.
> >
> > This means tools like coreutils' `rm -i` will always delete things
> > when prompted because the yesexpr regex matches all inputs (even
> > the negative ones).
>
> meant to include this, but here's the diff made readable:
> -yesexpr "^[+1dDyY]*."
> -noexpr "^[-0nN]*."
> +yesexpr "^[+1dDyY]"
> +noexpr "^[-0nN]"
> -mike
I guess the original author's intention was to put ".*" at the end
instead of "*." so first I was thinking about changing it into ".*".
But now I see you have removed all trailing ".*" from all locales.
If it works this way then I dare to say LGTM.
You may want to hear opinion from other people.
Regards,
Rafal
Mike, do you need more comments to push it? More comments, anybody?
Thanks in advance,
Rafal
16.12.2016 19:09 Mike Frysinger <vapier@gentoo.org> wrote:
>
>
> On 15 Dec 2016 18:35, Mike Frysinger wrote:
> > Both regexes end with a "*." which means the previous match can be
> > omitted, and then the . allows them to match any input at all.
> >
> > This means tools like coreutils' `rm -i` will always delete things
> > when prompted because the yesexpr regex matches all inputs (even
> > the negative ones).
>
> meant to include this, but here's the diff made readable:
> -yesexpr "^[+1dDyY]*."
> -noexpr "^[-0nN]*."
> +yesexpr "^[+1dDyY]"
> +noexpr "^[-0nN]"
> -mike
On 29 Dec 2016 13:52, Rafal Luzynski wrote:
> Mike, do you need more comments to push it? More comments, anybody?
i've pushed it now for 2.2[345]. thanks for the nudge!
-mike
@@ -148,8 +148,8 @@ copy "en_DK"
END LC_CTYPE
LC_MESSAGES
-yesexpr "<U005E><U005B><U002B><U0031><U0064><U0044><U0079><U0059><U005D><U002A><U002E>"
-noexpr "<U005E><U005B><U002D><U0030><U006E><U004E><U005D><U002A><U002E>"
+yesexpr "<U005E><U005B><U002B><U0031><U0064><U0044><U0079><U0059><U005D>"
+noexpr "<U005E><U005B><U002D><U0030><U006E><U004E><U005D>"
yesstr "<U0064><U0061>"
nostr "<U006E><U0065>"
END LC_MESSAGES