diff mbox

Remove check requiring void argument to functions with no parameters.

Message ID 20161125183148.56849-1-jhb@FreeBSD.org
State New, archived
Headers

Commit Message

John Baldwin Nov. 25, 2016, 6:31 p.m. UTC 
  C++ treats an empty parameter list as no parameters unlike C.

gdb/ChangeLog:

	* contrib/ari/gdb_ari.sh (no parameter function): Remove check.
---
 gdb/ChangeLog              |  4 ++++
 gdb/contrib/ari/gdb_ari.sh | 10 ----------
 2 files changed, 4 insertions(+), 10 deletions(-)

Comments

Pedro Alves Nov. 25, 2016, 6:42 p.m. UTC | #1 
On 11/25/2016 06:31 PM, John Baldwin wrote:
> C++ treats an empty parameter list as no parameters unlike C.
> 
> gdb/ChangeLog:
> 
> 	* contrib/ari/gdb_ari.sh (no parameter function): Remove check.

OK.

Thanks,
Pedro Alves
diff mbox

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d60fc24..1744139 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@ 
+2016-11-25  John Baldwin  <jhb@FreeBSD.org>
+
+	* contrib/ari/gdb_ari.sh (no parameter function): Remove check.
+
 2016-11-25  Simon Marchi  <simon.marchi@ericsson.com>
 
 	* Makefile.in: Fix typo.
diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index 2ecc0d6..e90dec8 100755
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -567,16 +567,6 @@  Function name in first column should be restricted to function implementation"
 }
 
 
-# Functions without any parameter should have (void)
-# after their name not simply ().
-BEGIN { doc["no parameter function"] = "\
-Function having no parameter should be declared with funcname (void)."
-    category["no parameter function"] = ari_code
-}
-/^[a-zA-Z][a-z0-9A-Z_]*[[:space:]]*\(\)/ {
-    fail("no parameter function")
-}
-
 BEGIN { doc["hash"] = "\
 Do not use ` #...'\'', instead use `#...'\''(some compilers only correctly \
 parse a C preprocessor directive when `#'\'' is the first character on \