Message ID | 1476979623-890-1-git-send-email-ynorov@caviumnetworks.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 5567 invoked by alias); 20 Oct 2016 16:07:30 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 4911 invoked by uid 89); 20 Oct 2016 16:07:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=ty, Hx-languages-length:1311, 53, 7, rt2 X-HELO: NAM01-BY2-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; From: Yury Norov <ynorov@caviumnetworks.com> To: <libc-alpha@sourceware.org> CC: Yury Norov <ynorov@caviumnetworks.com> Subject: [PATCH] dbl-64/e_sqrt.c: fix -Wunused-variable Date: Thu, 20 Oct 2016 19:07:03 +0300 Message-ID: <1476979623-890-1-git-send-email-ynorov@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB5PR10CA0033.EURPRD10.PROD.OUTLOOK.COM (10.165.4.171) To CY1PR07MB2246.namprd07.prod.outlook.com (10.164.112.148) X-MS-Office365-Filtering-Correlation-Id: 6f18fbc3-2c9f-4761-8f5b-08d3f9032981 X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2246; 2:zLUsAfTuy62i9R8L2/HBf8qtd/dp2z9K44UVj/K3agxqLKUPknGdRqzhF0wtpwfq550FOlpuUVI67Sg4tQWVtdiNNIVvx03SfvnJDIE5H90LHhr+mxq/PcGner7X1OGMXYJA3FtYw50YrWk6Rn+OU5NQmJvXw1xUFZaUamml+UbXDOrkPXLb6Cb6GBp/cgtn5pFdVt43q7JY2ap78Nggyg==; 3:9kPTmCBQ0FW6KJFstbGU2aOrizaWov6QEhOTdt47nehM3R6QjbGTAaq/SobVfbicMxHBuSeusi+g2i9A9eAe9VoSSo2XAHL5pIZTB5A5sFMTiepx6c2g+62gWt7TZxugfbJIr7tCMphJPdEM5O2tSg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2246; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2246; 25:jkFNMldF7Z3ez+vUlCnYB6YSTAfx3sz5Ow48u4ANZaffQ1HHj+o2vpvxusNpZtR/1BQucuQImrE1k+Vh8zvLU9aok964Z6NZA1FUDLfOhaKGB0/LpS7IEQkAajjEBDfNLrCnppkKuQ2ZcFu7Del17j/btkM9itjhS6WQ1ILST0FSnYMX72wuzz/yNtBwPExhpgwWGBO2Z+KMF3NbEVlrFakDWQRRnO1eHQQVw4Yrn2bGNRamE6YozAyxRWvDv2AEqSQFQ9Mke/Py5Q5c4ywNp36Ww9AXO9X0WmHMuKBakU931RCwfXhakBm4BqZFtq+aINFZWHW/pjgI/Y+doRDacWXA2B/fnxeZ5wBVZELv0Nha+F1pED9pk9r9sJIltsyGS5E/GyxhQdoVOybR7g0P7+NrmDNOVLOgg+z0jA6a4x9LfNU58+XPCE5LYwXk9XxPd3axxlA80IMdN2R6cqn1Ovqr2luXHoiIrpK3VkvND7f3dsX6Xd8SPjdfEf7+laBkPoa7qPUz2UdsKn1pnpRF5SUEz/VukpC3D5qcs76a+YtRQ9FN+t9i7d478FUziyvxRfIm1FkITmGgTmGG9qk+JEp7nLIMOnbTmGjHk4UN8SjBInArW8XcvGSMKOEtdOPHQlvJLUouJz3KTPmAE9/S/zd+ZnDaFWliKhH63txvpfEQXOS6CO1bvYr/XCyDKCAfUaEzH0dUMuoAZ9C4wrhUXR9sYVOqw/k2nXQrtCzibAqdYy8XKFmZey4Qr1WtfjcE X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2246; 31:2GwxTxnL36RyLvZaahgWzpRjVrmzhfM4ICUXGCseESUBY14v4o0XPQ1jvXWP6oqw3G9hcjxrnBUEVj/Jo3s5IaNSE6TYRgGOJjIfouBVkNFBsZcfU5d3c2QqXIRkDD3A349llGPY49IldvMcBOLkr+s4Y/4OjyPX/1c86TXhtCeoG99LBsRJCxg/xjMuZ7vr9RSQrtCiMv/OF0SO7DFC6Dt95MN171IlMcXu2dQFVWYK753OZSPHy8/+1z3+eT2p244HGl4WF/FuBcTQ9srwUZrnHmreny6w9+27tJwLFbY=; 20:DoMKRvl214JY//DhVKUHcJ89gqI0tKFBHHoM9nFFqfxBPoFIMHAlAfnMa/Kg3csNV0upks8kFuE3UkD5lQalyE/Ep/i8cu+UzszCmCIjvOURUfGwpQBVzSIyPduj15qZk/lmxhJBUHMdRcyHsstAXadbLppFXdXPeB0O+t3sNdw9grpkBqWItOx0RmatuXouhgXodmoQkplPyiXSbgrQ/VDP8gxLrun5pShU+qBcM2zfmu8+gxaHgIEN1GBLlbG/+5suqpDL2z8MDjEOaW7nc0yyp6MmWGDt3Vssxu8bjCXbcIv+03m56bUoLjzPIJc8NLiGUd3TG/XvyfOoWNhodrOZe1eQ5CE81iFdgU40pTSA1WiSSOTQDxXi47R8eGpQshOemIgyA+9Q820WOiiqLvGndhOHkvEg8h+A4uXeu48pG0Gq8svOOfngV6v6fpqLp5BsB/re0NywFa0ydMVwEZZVz7t/n89V93wyso7rTysMMoWoxI3FW+jzpQOlruml9DzMQ2oDKoSwczQo8sh0+CBsPjy+4ARmqmZ5gyBieb2E9RD+BQ0fU7oDV61fZB7bNM/qgyLT7elv/7CdB4BWU1dWOmZE4X1jSPenXQ9wokg= X-Microsoft-Antispam-PRVS: <CY1PR07MB22465A02C9988B8F4420D008EED50@CY1PR07MB2246.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001); SRVR:CY1PR07MB2246; BCL:0; PCL:0; RULEID:; SRVR:CY1PR07MB2246; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2246; 4:bv+yfOguwR+VaXmzW3E/AQFP9WX/ql/Iul8kKl2YDEWweIDWBCS0ezlql7EUAq5HSAdnOpuOvozyZ0y6ElTraw6eRvJDLMfJjCz+lRfrKBT9PTDML9cO69NMLmSSFu4P16VfX/JFQWbmDM2XXkc/q9xs7W/uKUTW26ZiMMaZTRLPx3VvXvHYwkQTRntiGaYc5Ab5oXdAoNljHPXqu5XDWnGZU1YSi+cgqxps4hQcoKn7QQeXOrBgZbPAbZxwIRZb9LgmkrTZeTQUh/8lpZ6aSR989tsgRpSoz8wRXcTQ6WMHGM5TbPoJjUlEgMz0qx470xdOfbz+VU2KOvZV4gZY8ARamWN8QEIsLivG9c/EHPrQ5+RYWuunuMN0H22bfkHo2clNK5Y1jqK+Ynui7fWLGA== X-Forefront-PRVS: 01018CB5B3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(199003)(189002)(7846002)(6916009)(50986999)(6666003)(36756003)(81156014)(81166006)(42186005)(76506005)(19580395003)(19580405001)(8676002)(23676002)(305945005)(7736002)(33646002)(586003)(5660300001)(189998001)(50466002)(2906002)(5820100001)(110136003)(101416001)(4326007)(107886002)(3846002)(6116002)(106356001)(4001430100002)(66066001)(2351001)(92566002)(97736004)(229853001)(50226002)(77096005)(2870700001)(105586002)(68736007)(450100001)(47776003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB2246; H:localhost; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: caviumnetworks.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjA3TUIyMjQ2OzIzOjVYejJCRzlzSnk0aUx0WjlrVGF5WjUzMVpV?= =?utf-8?B?emlLTGpzM1k3OHBPcEloSFFHSmloNk9Xems2Z3FITU5UUXlvSTh6V0dwdElE?= =?utf-8?B?UlhMYm1GcVpqQ29Na0JlM3hxMXJUQWtUZnZLT0VpWGdEbHJPNVBKc3g4Rmk5?= =?utf-8?B?SURPV0ljRnNPbERaQ2lMTFpQTUp1WDNLTERjZS9uTktFN01GeHBKSEV0Tng2?= =?utf-8?B?NC9jUjdrdVpZU1d1dlpmaTJRK1pIZEJiUTRiTFQ2RFpHU293NnViY1dXWXhs?= =?utf-8?B?eS9tNGo0TU0yTVltaGdYNmZ1RGIzajh0OUhXZEgzNzhicUR5cmw5L3lWZ1d5?= =?utf-8?B?UDc5Nk0zUU41eEhyYVRWUlR3dG9mVVJDd2Q1YzhWcjRRNlJPWHFDck9MVUNt?= =?utf-8?B?a1ptSlNDTWZvMGVSbEVpQUlSVUQzZ3BHT2dFTmlnbHR1aHFnZ0F6QzJtR1BP?= =?utf-8?B?aFVTVnFoWFJyUWhjenNWWVhqQmtqQUZjNUJCcXVsblg3dkRhNlc3RWdLMmpV?= =?utf-8?B?dFV5NnJvaWJxZXB5WUcxekVUNlFJKzY2MDhlS1dpTXFuSGNmTFNhdEJRUE0y?= =?utf-8?B?Z0EzTFF6T29Gc0dUWkd2a2Z2bzhDQmpPN3UrakpBL0d6S1NnUUNtZjBYWEM1?= =?utf-8?B?MzcwMHZJQlBvY2RiaUVDUEdQNXg4YzhKUXpDblF5ODBCRVNEc3QrK0k4VGhO?= =?utf-8?B?NE8ycU9LZXdsTXpMZ3c5dVM5VW54WkVBUm1QbGZrcGdadjRwL3kwK2Y2Qnp0?= =?utf-8?B?S1I1VUxxL1puWS9IbFZLMklKUmFhRjBlb3VXaUpCZGQ0SGtGWnd6ZXNsZ1NH?= =?utf-8?B?UkNsVGdlcTluOTJ5M3I2YktKZ0VQREZBRGRnaXplc29LSmRvZnM0Y0F5Mmhx?= =?utf-8?B?MzNaTXJncEJ2bEJmNVV0SU9ZcVR5c2F3d3lXOUFoU0JGdXEwUUhWc3VpZ2hw?= =?utf-8?B?WkEybkRGL0NKdHk1TmNMY0NaRTJIRVY3WWlxNnVLZHM0czZ1byt6cnZjejJo?= =?utf-8?B?dmFFQnZkcmNTUEkybWRPcWhEckk5Q21kckRkTzh2RHBtMzN5czQxYnlodWRC?= =?utf-8?B?TFE1Q1ZUdDRTT05uclYvNVNSQ0Y0aUkrajRWTVVnWTB0NjlqaDlidFBVY2F2?= =?utf-8?B?dnA2WnAxbjZxdCtZTWZUS1U1MkdrbXRHVWVNUDIrUjlpNHUrbTQwcTFLRkdh?= =?utf-8?B?MXBDQ3BIeW52bWtCVnk1YzFMMVFqVEJaVkFJaUFwNXY3amhqTzFEQ0V6bjRH?= =?utf-8?B?SFNHZzA5dnJ6V1daMzd2RlRmOFJFU2VOR1pJYVNaWHAwdHNVYUd1M2NMUmFT?= =?utf-8?B?cFFvUGw2SnlBTVY4RWVtbHhIb0R3ZXdJTUtPV1krTEY1NHluMFNWeDBoYUYr?= =?utf-8?B?WWo5Vy9mYjR5M3prMFFBUVFnS1ZVb3lvNHgxZFBnQzNBSTA5YmVlenVVNllE?= =?utf-8?B?R1hVRDlyM3FWbUZpTG1ORUIwcVJFZTYxWnR0aHNrZ25UeFpHaWt5cCs2TXcx?= =?utf-8?B?YnFVQWpIZmRSRy9nNmtGWk1tWEZyT21jeGI3YXNSWlJCaFhmbVlvYTZSaGNY?= =?utf-8?B?YTE4b1FwZ3dudmtpWFN5WExhVHBzZHNIeGd6M3VpcXVpeGs1ODd3clhMUGE5?= =?utf-8?Q?iiypOPyN3STVAfxvbyGf?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2246; 6:iL99bpJJJ/FOrQX/MZK+oY4OMK86H3qMiXXaEUiU9NmUi85GMb+v+2nCmADWl4GhxL6fvjZFn8c1LuMBS6ajII+qhTvfQnX9PX5e+3ApQPFjHQoszoYZOSFlQ93tZvoFwnj4BM1H7EHZClCJBjJrSyfsIrRHJs3UMPLBtqKHx/QVsz1KtKJITFHOWCEjF/z93QsytU0eLG7p9rd20QrLBh9c7q0f6R8EY1V1txJtOYrzhPxGvwYEldA/DLf8NAIJ2T/+XxLjlYbR48kcwM/fhDMtV/TjQxL1WcUqtg8iNDsCL1qWokouElvlLbZ15Gpv; 5:JHeaYRMamtjvZKyL8/ay9g41YXoK/3xYXXAe6g77CW5mNh33EQ4o4qhp661ksetlh7dp4fif4QRhJlaCMq8sJg7pZEgva4REw5vfOYa6eZaiXGEZ0UwsloOLd/lX2PQMKlW0DS30xCm4j4+isNNInT1AMXz8217Zf/BHILGtAGE=; 24:xU7ZTKfoXUi9RLCwHuN4QEJnB1CRi/3Haf/POKS/yOgvW6f4ZtXfnxA8jHgIUdYybeTc2PfP5BwrhoiMWMZwFUhCe/3DerOmu9UN+f/61A4=; 7:+viP9u1D6OGcM8L6on+ttpaGas3NwVri8p9dlunfRrfqwBJKXvT4NwCKczlZVrTocLqYdlQRV0QSIzHXL6vJX0pNpVmmsYJMQNIuBr9KmY39AavS+cpUtj/YoS6QJY1z4+nPYhh4I/TmhIlk6/zlyhF9c1inVgn+UQ7Anfb+KH9gN/PKNHZ3dXy4UJIKxdsTPW6wosQP7O5RzM8M3Oe6yl2O7RcUWW569IYpEk/dM8uD8mwzZxbwjE6j4jGIY/fbxDpMDq1nnOwhL/KBEuWNVtAaM0d3GmqL5r5OceWZkb0pqZlmZXpx1NAEKpYj9Q6lCg8hIriKg8HnZASNMiV+CVJ4IzWjFiepW6JVrOuQRnw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2016 16:07:16.1884 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2246 |
Commit Message
Yury Norov
Oct. 20, 2016, 4:07 p.m. UTC
EMULV() doesn't need p, hx, tx and ty if DLA_FMS is defined.
If that variables are needed for EMULV() only, GCC warns about
unused variables, like this:
../sysdeps/ieee754/dbl-64/e_sqrt.c: In function ‘__ieee754_sqrt’:
../sysdeps/ieee754/dbl-64/e_sqrt.c:56:54: warning: unused variable ‘ty’ [-Wunused-variable]
double y, t, del, res, res1, hy, z, zz, p, hx, tx, ty, s;
^
This patch fixes it for sysdeps/ieee754/dbl-64/e_sqrt.c where it happens.
* sysdeps/ieee754/dbl-64/e_sqrt.c
(__ieee754_sqrt): declare p, hx, tx and ty conditionally.
Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
---
sysdeps/ieee754/dbl-64/e_sqrt.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
Comments
On Okt 20 2016, Yury Norov <ynorov@caviumnetworks.com> wrote: > EMULV() doesn't need p, hx, tx and ty if DLA_FMS is defined. > If that variables are needed for EMULV() only, GCC warns about > unused variables, like this: > > ../sysdeps/ieee754/dbl-64/e_sqrt.c: In function ‘__ieee754_sqrt’: > ../sysdeps/ieee754/dbl-64/e_sqrt.c:56:54: warning: unused variable ‘ty’ [-Wunused-variable] > double y, t, del, res, res1, hy, z, zz, p, hx, tx, ty, s; > ^ > This patch fixes it for sysdeps/ieee754/dbl-64/e_sqrt.c where it happens. You only need that because you are getting the sysdep dir order wrong. This file should not be used on aarch64, but rather the one in sysdeps/aarch64/fpu. Andreas.
On Wed, Nov 23, 2016 at 05:39:11PM +0100, Andreas Schwab wrote: > On Okt 20 2016, Yury Norov <ynorov@caviumnetworks.com> wrote: > > > EMULV() doesn't need p, hx, tx and ty if DLA_FMS is defined. > > If that variables are needed for EMULV() only, GCC warns about > > unused variables, like this: > > > > ../sysdeps/ieee754/dbl-64/e_sqrt.c: In function ‘__ieee754_sqrt’: > > ../sysdeps/ieee754/dbl-64/e_sqrt.c:56:54: warning: unused variable ‘ty’ [-Wunused-variable] > > double y, t, del, res, res1, hy, z, zz, p, hx, tx, ty, s; > > ^ > > This patch fixes it for sysdeps/ieee754/dbl-64/e_sqrt.c where it happens. > > You only need that because you are getting the sysdep dir order wrong. > This file should not be used on aarch64, but rather the one in > sysdeps/aarch64/fpu. Yes, it works. Thank you. Yury.
diff --git a/sysdeps/ieee754/dbl-64/e_sqrt.c b/sysdeps/ieee754/dbl-64/e_sqrt.c index 8304a2b..d234678 100644 --- a/sysdeps/ieee754/dbl-64/e_sqrt.c +++ b/sysdeps/ieee754/dbl-64/e_sqrt.c @@ -53,7 +53,11 @@ __ieee754_sqrt (double x) rt2 = 3.75017500867345182581453026130850E-01, rt3 = 3.12523626554518656309172508769531E-01; static const double big = 134217728.0; - double y, t, del, res, res1, hy, z, zz, p, hx, tx, ty, s; + double y, t, del, res, res1, hy, z, zz, s; +#ifndef DLA_FMS + double p, hx, tx, ty; +#endif + mynumber a, c = { { 0, 0 } }; int4 k;