Wean gdb and sim off private libbfd.h header
Commit Message
bfd_default_set_arch_mach has moved to bfd.h, so there is now no need
to include a header which is supposed to be private to BFD. Tested by
cross-compiling from x86_64-linux, and in the rs6000-tdep.c case by
native powerpc64le-linux gdb build and regression test. I also ran
the sim testsuite, which doesn't do much for rl78 and rx..
OK to apply?
gdb/
* amd64-darwin-tdep.c: Don't include libbfd.h.
* i386-darwin-tdep.c: Likewise.
* rs6000-nat.c: Likewise.
* rs6000-tdep.c: Likewise.
sim/aarch64/
* memory.c: Don't include libbfd.h.
sim/rl78/
* load.c: Don't include libbfd.h.
(rl78_load): Don't use private iovec seek or read.
sim/rx/
* load.c: Don't include libbfd.h.
(rx_load): Don't use private iovec seek or read.
Comments
On 07/25/2016 09:22 AM, Alan Modra wrote:
> bfd_default_set_arch_mach has moved to bfd.h, so there is now no need
> to include a header which is supposed to be private to BFD. Tested by
> cross-compiling from x86_64-linux, and in the rs6000-tdep.c case by
> native powerpc64le-linux gdb build and regression test. I also ran
> the sim testsuite, which doesn't do much for rl78 and rx..
> OK to apply?
OK for the gdb parts.
sim bits look obvious to me too, fwiw.
Thanks,
Pedro Alves
On 25 Jul 2016 17:52, Alan Modra wrote:
> bfd_default_set_arch_mach has moved to bfd.h, so there is now no need
> to include a header which is supposed to be private to BFD. Tested by
> cross-compiling from x86_64-linux, and in the rs6000-tdep.c case by
> native powerpc64le-linux gdb build and regression test. I also ran
> the sim testsuite, which doesn't do much for rl78 and rx..
> OK to apply?
sim looks great, thanks !
-mike
@@ -26,7 +26,6 @@
#include "floatformat.h"
#include "symtab.h"
#include "regcache.h"
-#include "libbfd.h"
#include "objfiles.h"
#include "i387-tdep.h"
@@ -26,7 +26,6 @@
#include "floatformat.h"
#include "symtab.h"
#include "regcache.h"
-#include "libbfd.h"
#include "objfiles.h"
#include "i387-tdep.h"
@@ -23,7 +23,6 @@
#include "gdbcore.h"
#include "symfile.h"
#include "objfiles.h"
-#include "libbfd.h" /* For bfd_default_set_arch_mach (FIXME) */
#include "bfd.h"
#include "gdb-stabs.h"
#include "regcache.h"
@@ -43,7 +43,6 @@
#include "record-full.h"
#include "auxv.h"
-#include "libbfd.h" /* for bfd_default_set_arch_mach */
#include "coff/internal.h" /* for libcoff.h */
#include "libcoff.h" /* for xcoff_data */
#include "coff/xcoff.h"
@@ -26,7 +26,6 @@
#include <string.h>
#include "bfd.h"
-#include "libbfd.h"
#include "libiberty.h"
#include "elf/internal.h"
#include "elf/common.h"
@@ -29,7 +29,6 @@
#include "bfd.h"
#include "elf-bfd.h"
#include "elf/rl78.h"
-#include "libbfd.h"
#include "cpu.h"
#include "mem.h"
#include "load.h"
@@ -140,13 +139,13 @@ rl78_load (bfd *prog, host_callback *callbacks, const char * const simname)
buf = xmalloc (size);
offset = p->p_offset;
- if (prog->iovec->bseek (prog, offset, SEEK_SET) != 0)
+ if (bfd_seek (prog, offset, SEEK_SET) != 0)
{
fprintf (stderr, "%s, Failed to seek to offset %lx\n", simname, (long) offset);
continue;
}
- if (prog->iovec->bread (prog, buf, size) != size)
+ if (bfd_bread (buf, size, prog) != size)
{
fprintf (stderr, "%s: Failed to read %lx bytes\n", simname, size);
continue;
@@ -25,7 +25,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include <string.h>
#include "bfd.h"
-#include "libbfd.h"
#include "cpu.h"
#include "mem.h"
#include "load.h"
@@ -146,12 +145,12 @@ rx_load (bfd *prog, host_callback *callback)
}
offset = p->p_offset;
- if (prog->iovec->bseek (prog, offset, SEEK_SET) != 0)
+ if (bfd_seek (prog, offset, SEEK_SET) != 0)
{
fprintf (stderr, "Failed to seek to offset %lx\n", (long) offset);
continue;
}
- if (prog->iovec->bread (prog, buf, size) != size)
+ if (bfd_bread (buf, size, prog) != size)
{
fprintf (stderr, "Failed to read %lx bytes\n", size);
continue;