[v3,01/11,PR,gdb/14441] gdb: gdbtypes: add definitions for rvalue reference type
Commit Message
This patch introduces preliminal definitions regarding C++0x rvalue references
to the gdb type system. In addition to an enum type_code entry, a field in
struct type and an accessor macro for that which are created similarly to the
lvalue references' counterparts, we also introduce a TYPE_REFERENCE convenience
macro used to check for both kinds of references simultaneously as they are
equivalent in many contexts.
gdb/Changelog:
2016-03-04 Artemiy Volkov <artemiyv@acm.org>
* gdbtypes.h (enum type_code) <TYPE_CODE_RVALUE_REF>: New constant.
(TYPE_IS_REFERENCE): New macro.
(struct type): Add rvalue_reference_type field.
(TYPE_RVALUE_REFERENCE_TYPE): New macro.
---
gdb/gdbtypes.h | 12 ++++++++++++
1 file changed, 12 insertions(+)
Comments
On 03/04/2016 07:19 PM, Artemiy Volkov wrote:
> diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
> index e775a1d..3bdbcd9 100644
> --- a/gdb/gdbtypes.h
> +++ b/gdb/gdbtypes.h
> @@ -362,6 +364,11 @@ enum type_instance_flag_value
> #define TYPE_ATOMIC(t) \
> (TYPE_INSTANCE_FLAGS (t) & TYPE_INSTANCE_FLAG_ATOMIC)
>
> +/* True if this type represents either an lvalue or lvalue reference type. */
> +
I think there's a missing '*' docbook marker on this comment. [Arguably,
that whole thing appears to have fallen by the wayside...]
> +#define TYPE_IS_REFERENCE(t) \
> + (TYPE_CODE (t) == TYPE_CODE_REF || TYPE_CODE (t) == TYPE_CODE_RVALUE_REF)
> +
> /* * Instruction-space delimited type. This is for Harvard architectures
> which have separate instruction and data address spaces (and perhaps
> others).
Otherwise looks good.
Keith
@@ -160,6 +160,8 @@ enum type_code
TYPE_CODE_REF, /**< C++ Reference types */
+ TYPE_CODE_RVALUE_REF, /**< C++ rvalue reference types */
+
TYPE_CODE_CHAR, /**< *real* character type */
/* * Boolean type. 0 is false, 1 is true, and other values are
@@ -362,6 +364,11 @@ enum type_instance_flag_value
#define TYPE_ATOMIC(t) \
(TYPE_INSTANCE_FLAGS (t) & TYPE_INSTANCE_FLAG_ATOMIC)
+/* True if this type represents either an lvalue or lvalue reference type. */
+
+#define TYPE_IS_REFERENCE(t) \
+ (TYPE_CODE (t) == TYPE_CODE_REF || TYPE_CODE (t) == TYPE_CODE_RVALUE_REF)
+
/* * Instruction-space delimited type. This is for Harvard architectures
which have separate instruction and data address spaces (and perhaps
others).
@@ -767,6 +774,10 @@ struct type
struct type *reference_type;
+ /* * A C++ rvalue reference type added in C++0x. */
+
+ struct type *rvalue_reference_type;
+
/* * Variant chain. This points to a type that differs from this
one only in qualifiers and length. Currently, the possible
qualifiers are const, volatile, code-space, data-space, and
@@ -1229,6 +1240,7 @@ extern void allocate_gnat_aux_type (struct type *);
#define TYPE_TARGET_TYPE(thistype) TYPE_MAIN_TYPE(thistype)->target_type
#define TYPE_POINTER_TYPE(thistype) (thistype)->pointer_type
#define TYPE_REFERENCE_TYPE(thistype) (thistype)->reference_type
+#define TYPE_RVALUE_REFERENCE_TYPE(thistype) (thistype)->rvalue_reference_type
#define TYPE_CHAIN(thistype) (thistype)->chain
/* * Note that if thistype is a TYPEDEF type, you have to call check_typedef.
But check_typedef does set the TYPE_LENGTH of the TYPEDEF type,