[1/8] gdb.trace: Fix write_inferior_data_ptr on 32-bit big-endian machines.
Commit Message
Noticed and tested on s390. This bug caused completely broken fast
tracepoints. No regressions on i686, x86_64, s390x.
gdb/gdbserver/ChangeLog:
* tracepoint.c (write_inferior_data_ptr): Cast to uintptr_t, so that
it works properly on big-endian machines where sizeof (CORE_ADDR)
!= sizeof (void *).
---
Another patch for upcoming s390 tracepoint support. 31-bit fast tracepoints
are still broken, but now less so.
It seems tracepoints are still broken in multiple ways on big-endian
targets, and I'm going to fix that. However, I'm not sure what to do
about the bi-arch case mentioned in the comment. While it'd be nice
to handle libinproctrace.so like libgcc.so and build it for all multilib
configurations, atm C structures involving pointers are shared between
gdbserver and the IPA. This obviously would have to be refactored before
that's possible, but might be worth it - configuring a full 31-bit build
just to get fast tracepoints is a pain.
gdb/gdbserver/ChangeLog | 6 ++++++
gdb/gdbserver/tracepoint.c | 6 +++---
2 files changed, 9 insertions(+), 3 deletions(-)
Comments
OK with empty line after declaration.
Thanks,
Pedro Alves
On 22/01/16 15:01, Pedro Alves wrote:
> OK with empty line after declaration.
>
> Thanks,
> Pedro Alves
>
Thanks, fixed & pushed.
Any comment about the bi-arch case? Does that seem like something worth
doing?
BTW, don't mind the 1/8 in subject, that was a git-format-patch
accident. The remaining 7 patches are not yet review-ready :)
Marcin Kościelnicki
On 01/22/2016 02:06 PM, Marcin Kościelnicki wrote:
> On 22/01/16 15:01, Pedro Alves wrote:
>> OK with empty line after declaration.
>>
>> Thanks,
>> Pedro Alves
>>
>
> Thanks, fixed & pushed.
>
> Any comment about the bi-arch case? Does that seem like something worth
> doing?
I think it'd be nice if that worked.
>
> BTW, don't mind the 1/8 in subject, that was a git-format-patch
> accident. The remaining 7 patches are not yet review-ready :)
Thanks,
Pedro Alves
@@ -1,3 +1,9 @@
+2016-01-22 Marcin Kościelnicki <koriakin@0x04.net>
+
+ * tracepoint.c (write_inferior_data_ptr): Cast to uintptr_t, so that
+ it works properly on big-endian machines where sizeof (CORE_ADDR)
+ != sizeof (void *).
+
2016-01-21 Pedro Alves <palves@redhat.com>
* Makefile.in (COMPILER_CFLAGS, CXXFLAGS): New.
@@ -5931,14 +5931,14 @@ compile_tracepoint_condition (struct tracepoint *tpoint,
*jump_entry += 16;
}
-/* We'll need to adjust these when we consider bi-arch setups, and big
- endian machines. */
+/* We'll need to adjust these when we consider bi-arch setups. */
static int
write_inferior_data_ptr (CORE_ADDR where, CORE_ADDR ptr)
{
+ uintptr_t pptr = ptr;
return write_inferior_memory (where,
- (unsigned char *) &ptr, sizeof (void *));
+ (unsigned char *) &pptr, sizeof pptr);
}
/* The base pointer of the IPA's heap. This is the only memory the