[v3,5/5] Support software breakpoints for ARM linux in GDBServer.

Message ID 1445359685-2589-6-git-send-email-antoine.tremblay@ericsson.com
State New, archived
Headers

Commit Message

Antoine Tremblay Oct. 20, 2015, 4:48 p.m. UTC
  In this v3:
  * Removed NEWS entry
-

This patch enables software breakpoints via GDB's Z0 packets on ARM.

No regressions, tested on ubuntu 14.04 ARMv7 and x86.
With gdbserver-{native,extended} / { -marm -mthumb }

gdb/gdbserver/ChangeLog:
	* linux-arm-low.c (arm_supports_z_point_type): Add software
	breakpoint support.
---
 gdb/gdbserver/linux-arm-low.c | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Pedro Alves Oct. 21, 2015, 11:19 a.m. UTC | #1
On 10/20/2015 05:48 PM, Antoine Tremblay wrote:
> In this v3:
>   * Removed NEWS entry
> -
> 
> This patch enables software breakpoints via GDB's Z0 packets on ARM.
> 
> No regressions, tested on ubuntu 14.04 ARMv7 and x86.
> With gdbserver-{native,extended} / { -marm -mthumb }
> 
> gdb/gdbserver/ChangeLog:
> 	* linux-arm-low.c (arm_supports_z_point_type): Add software
> 	breakpoint support.

LGTM.

Thanks,
Pedro Alves
  

Patch

diff --git a/gdb/gdbserver/linux-arm-low.c b/gdb/gdbserver/linux-arm-low.c
index 62e88f0..0f88b87 100644
--- a/gdb/gdbserver/linux-arm-low.c
+++ b/gdb/gdbserver/linux-arm-low.c
@@ -545,6 +545,7 @@  arm_supports_z_point_type (char z_type)
 {
   switch (z_type)
     {
+    case Z_PACKET_SW_BP:
     case Z_PACKET_HW_BP:
     case Z_PACKET_WRITE_WP:
     case Z_PACKET_READ_WP: