[v2,08/19] elf: Emit warning if tunable is ill-formatted
Checks
Context |
Check |
Description |
redhat-pt-bot/TryBot-apply_patch |
success
|
Patch applied to master at the time it was sent
|
linaro-tcwg-bot/tcwg_glibc_build--master-arm |
success
|
Testing passed
|
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 |
success
|
Testing passed
|
linaro-tcwg-bot/tcwg_glibc_check--master-arm |
success
|
Testing passed
|
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 |
success
|
Testing passed
|
Commit Message
So caller knows that the tunable will be ignored.
Checked on x86_64-linux-gnu.
---
elf/dl-tunables.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
Comments
On 2023-10-17 09:05, Adhemerval Zanella wrote:
> So caller knows that the tunable will be ignored.
>
> Checked on x86_64-linux-gnu.
> ---
> elf/dl-tunables.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/elf/dl-tunables.c b/elf/dl-tunables.c
> index 5d4b8c5bc0..b39c14694c 100644
> --- a/elf/dl-tunables.c
> +++ b/elf/dl-tunables.c
> @@ -236,7 +236,11 @@ parse_tunables (char *valstring)
> struct tunable_toset_t tunables[tunables_list_size];
> int ntunables = parse_tunables_string (valstring, tunables);
> if (ntunables == -1)
> - return;
> + {
> + _dl_error_printf (
> + "ERROR: ld.so: invalid GLIBC_TUNABLES `%s': ignored.\n", valstring);
If it's a warning, then we should say WARNING here.
> + return;
> + }
>
> for (int i = 0; i < ntunables; i++)
> tunable_initialize (tunables[i].t, tunables[i].value);
On 27/10/23 07:28, Siddhesh Poyarekar wrote:
>
>
> On 2023-10-17 09:05, Adhemerval Zanella wrote:
>> So caller knows that the tunable will be ignored.
>>
>> Checked on x86_64-linux-gnu.
>> ---
>> elf/dl-tunables.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/elf/dl-tunables.c b/elf/dl-tunables.c
>> index 5d4b8c5bc0..b39c14694c 100644
>> --- a/elf/dl-tunables.c
>> +++ b/elf/dl-tunables.c
>> @@ -236,7 +236,11 @@ parse_tunables (char *valstring)
>> struct tunable_toset_t tunables[tunables_list_size];
>> int ntunables = parse_tunables_string (valstring, tunables);
>> if (ntunables == -1)
>> - return;
>> + {
>> + _dl_error_printf (
>> + "ERROR: ld.so: invalid GLIBC_TUNABLES `%s': ignored.\n", valstring);
>
> If it's a warning, then we should say WARNING here.
Ack.
>
>> + return;
>> + }
>> for (int i = 0; i < ntunables; i++)
>> tunable_initialize (tunables[i].t, tunables[i].value);
@@ -236,7 +236,11 @@ parse_tunables (char *valstring)
struct tunable_toset_t tunables[tunables_list_size];
int ntunables = parse_tunables_string (valstring, tunables);
if (ntunables == -1)
- return;
+ {
+ _dl_error_printf (
+ "ERROR: ld.so: invalid GLIBC_TUNABLES `%s': ignored.\n", valstring);
+ return;
+ }
for (int i = 0; i < ntunables; i++)
tunable_initialize (tunables[i].t, tunables[i].value);