Message ID | 87sg5o7705.fsf@oldenburg.str.redhat.com |
---|---|
State | Changes Requested, archived |
Headers |
Return-Path: <libc-alpha-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CC2193890421; Mon, 22 Feb 2021 10:04:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CC2193890421 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1613988263; bh=2ZJ+FqzfE+JFdmgUBqut10daoBpl/RFQV3W+c1pqMhk=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=f6XOCFrBawugJsNT8UP/GjxP7Z3jeKV3mKt0RiOfS7CdodDB0NL4/IwtA7ATa/PKs ZbpEcnfCMckXSJPAdv1TyRv9G2f8gEW7CrFinAjGBpVlRgWIZAxuPYMdGEI8GgZJTr 49VKdnyDKxjBBCvdO/WwAJ4gNQimxSK6Uepu2l6A= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 0FCCA388CC17 for <libc-alpha@sourceware.org>; Mon, 22 Feb 2021 10:04:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0FCCA388CC17 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-567-wl2jO_pzPZ6nTwpjCxorIA-1; Mon, 22 Feb 2021 05:04:19 -0500 X-MC-Unique: wl2jO_pzPZ6nTwpjCxorIA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6E9D0107ACE3 for <libc-alpha@sourceware.org>; Mon, 22 Feb 2021 10:04:18 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-113-131.ams2.redhat.com [10.36.113.131]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C7EF37771A for <libc-alpha@sourceware.org>; Mon, 22 Feb 2021 10:04:17 +0000 (UTC) To: libc-alpha@sourceware.org Subject: [PATCH] x86: Do not check FSRM in tst-cpu-features-cpuinfo Date: Mon, 22 Feb 2021 11:04:58 +0100 Message-ID: <87sg5o7705.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Florian Weimer <fweimer@redhat.com> Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org> |
Series |
x86: Do not check FSRM in tst-cpu-features-cpuinfo
|
|
Commit Message
Florian Weimer
Feb. 22, 2021, 10:04 a.m. UTC
Current kernels do not report this feature bit, so the test fails if the hardware supports it. According to [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors <https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg03370.html> some AMD processors set this CPUID bit. --- sysdeps/x86/tst-cpu-features-cpuinfo.c | 3 +++ 1 file changed, 3 insertions(+)
Comments
On Mon, Feb 22, 2021 at 2:17 AM Florian Weimer via Libc-alpha <libc-alpha@sourceware.org> wrote: > > Current kernels do not report this feature bit, so the test fails > if the hardware supports it. > > According to > > [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors > <https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg03370.html> > > some AMD processors set this CPUID bit. > > --- > sysdeps/x86/tst-cpu-features-cpuinfo.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/sysdeps/x86/tst-cpu-features-cpuinfo.c b/sysdeps/x86/tst-cpu-features-cpuinfo.c > index 75e7eb9352..a6a873b59c 100644 > --- a/sysdeps/x86/tst-cpu-features-cpuinfo.c > +++ b/sysdeps/x86/tst-cpu-features-cpuinfo.c > @@ -153,7 +153,10 @@ do_test (int argc, char **argv) > fails += CHECK_PROC (fma4, FMA4); > fails += CHECK_PROC (fpu, FPU); > fails += CHECK_PROC (fsgsbase, FSGSBASE); > +#if 0 > + /* NB: /proc/cpuinfo doesn't report this feature. */ > fails += CHECK_PROC (fsrm, FSRM); > +#endif > fails += CHECK_PROC (fxsr, FXSR); > fails += CHECK_PROC (gfni, GFNI); > fails += CHECK_PROC (hle, HLE); > Since kernel does report it on Intel CPUs, please change it to /* NB: /proc/cpuinfo reports this feature on Intel CPUs. */ if (cpu_features->basic.kind == arch_kind_intel) on top of https://sourceware.org/pipermail/libc-alpha/2021-January/122171.html Thanks.
* H. J. Lu: > On Mon, Feb 22, 2021 at 2:17 AM Florian Weimer via Libc-alpha > <libc-alpha@sourceware.org> wrote: >> >> Current kernels do not report this feature bit, so the test fails >> if the hardware supports it. >> >> According to >> >> [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors >> <https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg03370.html> >> >> some AMD processors set this CPUID bit. >> >> --- >> sysdeps/x86/tst-cpu-features-cpuinfo.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/sysdeps/x86/tst-cpu-features-cpuinfo.c b/sysdeps/x86/tst-cpu-features-cpuinfo.c >> index 75e7eb9352..a6a873b59c 100644 >> --- a/sysdeps/x86/tst-cpu-features-cpuinfo.c >> +++ b/sysdeps/x86/tst-cpu-features-cpuinfo.c >> @@ -153,7 +153,10 @@ do_test (int argc, char **argv) >> fails += CHECK_PROC (fma4, FMA4); >> fails += CHECK_PROC (fpu, FPU); >> fails += CHECK_PROC (fsgsbase, FSGSBASE); >> +#if 0 >> + /* NB: /proc/cpuinfo doesn't report this feature. */ >> fails += CHECK_PROC (fsrm, FSRM); >> +#endif >> fails += CHECK_PROC (fxsr, FXSR); >> fails += CHECK_PROC (gfni, GFNI); >> fails += CHECK_PROC (hle, HLE); >> > > Since kernel does report it on Intel CPUs, please change it to > > /* NB: /proc/cpuinfo reports this feature on Intel CPUs. */ > if (cpu_features->basic.kind == arch_kind_intel) > > on top of > > https://sourceware.org/pipermail/libc-alpha/2021-January/122171.html Oh, it looks like that kernel support has only been added in Linux 5.6. Does this mean that tst-cpu-features-cpuinfo.c needs to check kernel versions? Thanks, Florian
On Mon, Feb 22, 2021 at 5:15 AM Florian Weimer <fweimer@redhat.com> wrote: > > * H. J. Lu: > > > On Mon, Feb 22, 2021 at 2:17 AM Florian Weimer via Libc-alpha > > <libc-alpha@sourceware.org> wrote: > >> > >> Current kernels do not report this feature bit, so the test fails > >> if the hardware supports it. > >> > >> According to > >> > >> [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors > >> <https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg03370.html> > >> > >> some AMD processors set this CPUID bit. > >> > >> --- > >> sysdeps/x86/tst-cpu-features-cpuinfo.c | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/sysdeps/x86/tst-cpu-features-cpuinfo.c b/sysdeps/x86/tst-cpu-features-cpuinfo.c > >> index 75e7eb9352..a6a873b59c 100644 > >> --- a/sysdeps/x86/tst-cpu-features-cpuinfo.c > >> +++ b/sysdeps/x86/tst-cpu-features-cpuinfo.c > >> @@ -153,7 +153,10 @@ do_test (int argc, char **argv) > >> fails += CHECK_PROC (fma4, FMA4); > >> fails += CHECK_PROC (fpu, FPU); > >> fails += CHECK_PROC (fsgsbase, FSGSBASE); > >> +#if 0 > >> + /* NB: /proc/cpuinfo doesn't report this feature. */ > >> fails += CHECK_PROC (fsrm, FSRM); > >> +#endif > >> fails += CHECK_PROC (fxsr, FXSR); > >> fails += CHECK_PROC (gfni, GFNI); > >> fails += CHECK_PROC (hle, HLE); > >> > > > > Since kernel does report it on Intel CPUs, please change it to > > > > /* NB: /proc/cpuinfo reports this feature on Intel CPUs. */ > > if (cpu_features->basic.kind == arch_kind_intel) > > > > on top of > > > > https://sourceware.org/pipermail/libc-alpha/2021-January/122171.html > > Oh, it looks like that kernel support has only been added in Linux 5.6. > Does this mean that tst-cpu-features-cpuinfo.c needs to check kernel > versions? Good idea. BTW, we are checking GCC versions for __builtin_cpu_supports.
diff --git a/sysdeps/x86/tst-cpu-features-cpuinfo.c b/sysdeps/x86/tst-cpu-features-cpuinfo.c index 75e7eb9352..a6a873b59c 100644 --- a/sysdeps/x86/tst-cpu-features-cpuinfo.c +++ b/sysdeps/x86/tst-cpu-features-cpuinfo.c @@ -153,7 +153,10 @@ do_test (int argc, char **argv) fails += CHECK_PROC (fma4, FMA4); fails += CHECK_PROC (fpu, FPU); fails += CHECK_PROC (fsgsbase, FSGSBASE); +#if 0 + /* NB: /proc/cpuinfo doesn't report this feature. */ fails += CHECK_PROC (fsrm, FSRM); +#endif fails += CHECK_PROC (fxsr, FXSR); fails += CHECK_PROC (gfni, GFNI); fails += CHECK_PROC (hle, HLE);