diff mbox series

[applied] writer: escape enum linkage name in abixml

Message ID 87k0jrf8on.fsf@redhat.com
State New
Headers show
Series [applied] writer: escape enum linkage name in abixml | expand

Commit Message

Dodji Seketeli Sept. 8, 2021, 2:23 p.m. UTC
Hello,

While looking at something else, I stumbled across this bug where the
linkage name of enum are not escaped in abixml.  So "forbidden"
characters like '<' can snick in.

Fixed thus.

This helps address https://bugzilla.redhat.com/show_bug.cgi?id=1951501

	* src/abg-writer.cc (write_enum_type_decl): Escape linkage name.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
Applied to master.

---
 src/abg-writer.cc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/src/abg-writer.cc b/src/abg-writer.cc
index 9f48dc92..f18293dc 100644
--- a/src/abg-writer.cc
+++ b/src/abg-writer.cc
@@ -3011,7 +3011,9 @@  write_enum_type_decl(const enum_type_decl_sptr& decl,
   write_is_non_reachable(is_type(decl), o);
 
   if (!decl->get_linkage_name().empty())
-    o << " linkage-name='" << decl->get_linkage_name() << "'";
+    o << " linkage-name='"
+      << xml::escape_xml_string(decl->get_linkage_name())
+      << "'";
 
   write_location(decl, ctxt);
   write_is_declaration_only(decl, o);