From patchwork Wed Sep 8 14:23:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 44907 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 771CA3861881 for ; Wed, 8 Sep 2021 14:23:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 771CA3861881 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631110992; bh=mmovwg/KMF7LYuGZc14HpD2PjojAjlGj9C2OBeVwlgo=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Help: List-Subscribe:From:Reply-To:From; b=GKUPAKFTdrRQCxz7HVCIGNMEYHpEDclyQMbX1h896WPjIyQyXesL/pdis9G91H1Dx ex8ip594/4iB2DnJxoFHH8z685GaEvSwYbvcbNwNJKKBOsfqX741IgnMh/y+Y/hR6Z z1XrTY1i2v+Uva87hISvmogY8h98+nAuBTHTVIG0= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 5E1833858414 for ; Wed, 8 Sep 2021 14:23:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5E1833858414 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-169-yvGKhmUtMEmJRy5E6hrx_w-1; Wed, 08 Sep 2021 10:23:07 -0400 X-MC-Unique: yvGKhmUtMEmJRy5E6hrx_w-1 Received: by mail-wm1-f69.google.com with SMTP id j33-20020a05600c48a100b002e879427915so992983wmp.5 for ; Wed, 08 Sep 2021 07:23:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:organization:date:message-id :user-agent:mime-version; bh=mmovwg/KMF7LYuGZc14HpD2PjojAjlGj9C2OBeVwlgo=; b=xSHkN2W6ailPW/yu/aCyad5l59jPdOq+kiZ2ZfK2y+ElJyRoHBkhTmo2MxR91Ccsuz lZgqVh1FXMvvXAfYqTKv7uiH8d6vTr4uNZ1NdO6M2dkLAExwlMrZYGddndtPVfZbwcjy 6OwhF7mwko6aF7DFL2PBbF/RXu853hg84vqw31aVmAz+rDfbWD/fEmdhEfQSoIZIFjcG VaLzwKIPe5lLz7tVw9LN7beRqOwaeXjS2jMHfSF4DK+dMTRJ+jZmIbg/QdDnQlcUmf81 QD+KzZxVHPN5k0HWK10ufqgcRaAji/zJ9r9ZbD9TQ6JjvzJok2lsiMPDQMXewYNpga3n YvSA== X-Gm-Message-State: AOAM532jwYOlzWPeDGaXzkvcROD48HWnecmnIsh2b3OGBdjtHj6NnKtd Lzj2eX8P8l61hUpqzH0doJiO/TPuDGD48tmKa/26fFeJrIYN+N+XLOw9a1bYj6gV88m2LzOaMqR 9582xoauhJs+hRoWehp28taSFvW+MaaHLnaawUI+f3b6RDfbJSX4WPJCZZ+EJJkjy5l2l X-Received: by 2002:a05:6000:160c:: with SMTP id u12mr4394690wrb.128.1631110986449; Wed, 08 Sep 2021 07:23:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzzC/cA166kYtiuoPsr3ynjCTxSPwW7iY6BdwjKozbDRVVuDZwW6qCcsDBOSUL/CCQI5Md39Q== X-Received: by 2002:a05:6000:160c:: with SMTP id u12mr4394666wrb.128.1631110986218; Wed, 08 Sep 2021 07:23:06 -0700 (PDT) Received: from localhost ([88.120.130.27]) by smtp.gmail.com with ESMTPSA id e3sm3089848wrv.18.2021.09.08.07.23.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 07:23:05 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id 2646858000E; Wed, 8 Sep 2021 16:23:04 +0200 (CEST) To: libabigail@sourceware.org Subject: [PATCH, applied] writer: escape enum linkage name in abixml Organization: Red Hat / France X-Operating-System: Fedora 36 X-URL: http://www.redhat.com Date: Wed, 08 Sep 2021 16:23:04 +0200 Message-ID: <87k0jrf8on.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Dodji Seketeli via Libabigail From: Dodji Seketeli Reply-To: Dodji Seketeli Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" Hello, While looking at something else, I stumbled across this bug where the linkage name of enum are not escaped in abixml. So "forbidden" characters like '<' can snick in. Fixed thus. This helps address https://bugzilla.redhat.com/show_bug.cgi?id=1951501 * src/abg-writer.cc (write_enum_type_decl): Escape linkage name. Signed-off-by: Dodji Seketeli Applied to master. --- src/abg-writer.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/abg-writer.cc b/src/abg-writer.cc index 9f48dc92..f18293dc 100644 --- a/src/abg-writer.cc +++ b/src/abg-writer.cc @@ -3011,7 +3011,9 @@ write_enum_type_decl(const enum_type_decl_sptr& decl, write_is_non_reachable(is_type(decl), o); if (!decl->get_linkage_name().empty()) - o << " linkage-name='" << decl->get_linkage_name() << "'"; + o << " linkage-name='" + << xml::escape_xml_string(decl->get_linkage_name()) + << "'"; write_location(decl, ctxt); write_is_declaration_only(decl, o);