diff mbox series

[applied] reporter-priv: Passing a string parm by reference

Message ID 87a6a6gtba.fsf@redhat.com
State New
Headers
Series [applied] reporter-priv: Passing a string parm by reference |

Commit Message

Dodji Seketeli June 21, 2022, 11:16 a.m. UTC 
  Hello,

While looking at something else, I noticed the
maybe_report_data_members_replaced_by_anon_dm function was passing a
string parameter by value.  Pass this by reference.

	* src/abg-reporter-priv.h
	(maybe_report_data_members_replaced_by_anon_dm): Pass the string parm by ...
	* src/abg-reporter-priv.cc
	(maybe_report_data_members_replaced_by_anon_dm): ... reference.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
Applied to master.
---
 src/abg-reporter-priv.cc | 2 +-
 src/abg-reporter-priv.h  | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/src/abg-reporter-priv.cc b/src/abg-reporter-priv.cc
index 06145a1b..f41f0ca6 100644
--- a/src/abg-reporter-priv.cc
+++ b/src/abg-reporter-priv.cc
@@ -1387,7 +1387,7 @@  reporter_base::diff_to_be_reported(const diff *d) const
 void
 maybe_report_data_members_replaced_by_anon_dm(const class_or_union_diff &d,
 					      ostream			&out,
-					      const string		indent)
+					      const string		&indent)
 {
   const diff_context_sptr& ctxt = d.context();
 
diff --git a/src/abg-reporter-priv.h b/src/abg-reporter-priv.h
index 42425ef2..d8a9640a 100644
--- a/src/abg-reporter-priv.h
+++ b/src/abg-reporter-priv.h
@@ -238,8 +238,7 @@  maybe_report_interfaces_impacted_by_diff(const diff_sptr	&d,
 void
 maybe_report_data_members_replaced_by_anon_dm(const class_or_union_diff &d,
 					      ostream			&out,
-					      const string		indent);
-
+					      const string		&indent);
 
 void
 maybe_report_base_class_reordering(const class_diff	&d,