From patchwork Tue Jun 21 11:16:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 55229 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 10B6438582AB for ; Tue, 21 Jun 2022 11:16:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 10B6438582AB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1655810212; bh=RCxp3WEZwFCRMdObyjaHByNKq9kqrIxXI7pUwVY9wTA=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Help: List-Subscribe:From:Reply-To:From; b=HPyh6/vjhKqHQR5lYRoyFCU+F1CVqEigIuc6/jCbO7MOZTAWcPBJ42uOkIdYv+4bb KAxDv0A2iudB4nvBy6699KF1aHNsePdyT1QdTPmQLDD6pFuveZJdYI9j+P9+d+HDiV KnObnY1U9JUWyTLBoPnaBwvE//5dIqn6jgwXobDo= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A02B83858C56 for ; Tue, 21 Jun 2022 11:16:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A02B83858C56 Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-459-SO8fq_ExOpGUqrCLHSZtDQ-1; Tue, 21 Jun 2022 07:16:44 -0400 X-MC-Unique: SO8fq_ExOpGUqrCLHSZtDQ-1 Received: by mail-qv1-f69.google.com with SMTP id u18-20020a0cf1d2000000b00470427ccfa5so5108520qvl.18 for ; Tue, 21 Jun 2022 04:16:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:organization:date:message-id :user-agent:mime-version; bh=RCxp3WEZwFCRMdObyjaHByNKq9kqrIxXI7pUwVY9wTA=; b=pIXNQSbX6TEFl6qNXKdBRSJmRAH6bRNoFlHHFudSJ8C5cEwycKT6c+fx50eQntSDkr Qx0BLD4rZkNJ9mDDwnI2F3Gg9LcldosW7odaGoC6PucJSEDj0J1/bk/cQ5h9KoNuBFpu oNfJXijMW4GL1saWHEwjbxayelkDT7ge2VYBzaMhGRuu85GeVBSoXqtU/N//h2Bg6Iou UQHij/PEDz2S/I8KkCwxR+wcE89tSZer+AULXQDKX0+z7Zn5gNTUtJLIQmZE0MynyjEE yqrZOdG9z2sGrjuk2+zouHYERKHAZybJiYmIVNu1PstfUmsHQG+keb37BSHOvLWw3lOO 7rqQ== X-Gm-Message-State: AJIora/D4fCKFkFFUrLop64vvdM65qfwYMF/vx9+9oeSlH0lvcqWIgWe 7YOZDS9iEZpw7OjHyZbq6gP+WbpE8MfT8vTBbf38j2QCl812BAvlu89ZlNJY7B0N4RefqwaK5MD KcjxPfX5v+t5FDi6uBGDkFOLZUb9cwDhUr6LFf7aBGdVLYOMszYKbQJayvxDN7O21fyd/ X-Received: by 2002:a05:622a:1649:b0:306:6a7b:2c22 with SMTP id y9-20020a05622a164900b003066a7b2c22mr23584785qtj.66.1655810204268; Tue, 21 Jun 2022 04:16:44 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t1JpjJnvfRx0SXhXlAk0Fdp3jAcpI+Kb8F0hiJ6sMoBIR6If5rU1Qt4RTZgq/H7I49Q4koig== X-Received: by 2002:a05:622a:1649:b0:306:6a7b:2c22 with SMTP id y9-20020a05622a164900b003066a7b2c22mr23584762qtj.66.1655810203972; Tue, 21 Jun 2022 04:16:43 -0700 (PDT) Received: from localhost ([88.120.130.27]) by smtp.gmail.com with ESMTPSA id fb11-20020a05622a480b00b00304fa21762csm12463760qtb.53.2022.06.21.04.16.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 04:16:43 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id 32C935800FC; Tue, 21 Jun 2022 13:16:41 +0200 (CEST) To: libabigail@sourceware.org Subject: [PATCH, applied] reporter-priv: Passing a string parm by reference Organization: Red Hat / France X-Operating-System: Fedora 37 X-URL: http://www.redhat.com Date: Tue, 21 Jun 2022 13:16:41 +0200 Message-ID: <87a6a6gtba.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Dodji Seketeli via Libabigail From: Dodji Seketeli Reply-To: Dodji Seketeli Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" Hello, While looking at something else, I noticed the maybe_report_data_members_replaced_by_anon_dm function was passing a string parameter by value. Pass this by reference. * src/abg-reporter-priv.h (maybe_report_data_members_replaced_by_anon_dm): Pass the string parm by ... * src/abg-reporter-priv.cc (maybe_report_data_members_replaced_by_anon_dm): ... reference. Signed-off-by: Dodji Seketeli Applied to master. --- src/abg-reporter-priv.cc | 2 +- src/abg-reporter-priv.h | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/abg-reporter-priv.cc b/src/abg-reporter-priv.cc index 06145a1b..f41f0ca6 100644 --- a/src/abg-reporter-priv.cc +++ b/src/abg-reporter-priv.cc @@ -1387,7 +1387,7 @@ reporter_base::diff_to_be_reported(const diff *d) const void maybe_report_data_members_replaced_by_anon_dm(const class_or_union_diff &d, ostream &out, - const string indent) + const string &indent) { const diff_context_sptr& ctxt = d.context(); diff --git a/src/abg-reporter-priv.h b/src/abg-reporter-priv.h index 42425ef2..d8a9640a 100644 --- a/src/abg-reporter-priv.h +++ b/src/abg-reporter-priv.h @@ -238,8 +238,7 @@ maybe_report_interfaces_impacted_by_diff(const diff_sptr &d, void maybe_report_data_members_replaced_by_anon_dm(const class_or_union_diff &d, ostream &out, - const string indent); - + const string &indent); void maybe_report_base_class_reordering(const class_diff &d,