diff mbox series

Fix fedabipkgdiff configure check for Python 3.12

Message ID 20230707180121.3101370-1-yselkowi@redhat.com
State New
Headers
Series Fix fedabipkgdiff configure check for Python 3.12 |

Commit Message

Yaakov Selkowitz July 7, 2023, 6:01 p.m. UTC 
  importlib is the Python 3 replacement to imp, which was deprecated in
Python 3.4 and removed in 3.12.

	* configure.ac (REQUIRED_PYTHON_MODULES_FOR_FEDABIPKGDIFF):
	Test for importlib.machinery instead of imp with python3.

Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
---
 configure.ac | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Dodji Seketeli July 10, 2023, 7:42 a.m. UTC | #1 
Hello Yaakov,

Yaakov Selkowitz via Libabigail <libabigail@sourceware.org> a écrit:

> importlib is the Python 3 replacement to imp, which was deprecated in
> Python 3.4 and removed in 3.12.
>
> 	* configure.ac (REQUIRED_PYTHON_MODULES_FOR_FEDABIPKGDIFF):
> 	Test for importlib.machinery instead of imp with python3.
>
> Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>

Applied to the master branch, thanks!

[...]

Cheers,
diff mbox series

Patch

diff --git a/configure.ac b/configure.ac
index b4e7e38e..b3f97ba2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -739,13 +739,15 @@  if test x$CHECK_DEPS_FOR_FEDABIPKGDIFF = xyes; then
   # urllib.parse.  Oh well.
   if test x$PYTHON = xpython3; then
      URLPARSE_MODULE=urllib.parse
+     IMPORT_MODULE=importlib.machinery
   else
      URLPARSE_MODULE=urlparse
+     IMPORT_MODULE=imp
   fi
 
   REQUIRED_PYTHON_MODULES_FOR_FEDABIPKGDIFF="\
    argparse logging os re subprocess sys $URLPARSE_MODULE \
-   xdg koji mock rpm imp tempfile mimetypes shutil six"
+   xdg koji mock rpm $IMPORT_MODULE tempfile mimetypes shutil six"
 
   AX_CHECK_PYTHON_MODULES([$REQUIRED_PYTHON_MODULES_FOR_FEDABIPKGDIFF],
 			  [$PYTHON],