From patchwork Fri Jul 7 18:01:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yaakov Selkowitz X-Patchwork-Id: 72317 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AB5C3384DE68 for ; Fri, 7 Jul 2023 18:01:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AB5C3384DE68 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1688752891; bh=gKDqDqKEwrs6sFPTKKwmItYmtqvzgIDyBr3hv9tWns4=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Help: List-Subscribe:From:Reply-To:From; b=PMRVE2Gpjzxgo7+yZ2Bh5QcnYP9uEfDYbms+kz2bPe76dScy7qXu5OfV2kgLyYq6l zHNwq6a8jxYBXsfmMRbhPU+IbWkqS66lWI2MkOSrovJFXCWQa8behU+HnTo5E5iGPM tsb+zekQrp5pwvAyxYv5WLpOPBtiMK+9j9zYa6Rw= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E4349384DE53 for ; Fri, 7 Jul 2023 18:01:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E4349384DE53 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-92-snA3kUhLOB6v59Zw_tSCtA-1; Fri, 07 Jul 2023 14:01:24 -0400 X-MC-Unique: snA3kUhLOB6v59Zw_tSCtA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 59B18185A78B for ; Fri, 7 Jul 2023 18:01:24 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.22.32.77]) by smtp.corp.redhat.com (Postfix) with ESMTP id 38EDFC09A09 for ; Fri, 7 Jul 2023 18:01:24 +0000 (UTC) To: libabigail@sourceware.org Subject: [PATCH] Fix fedabipkgdiff configure check for Python 3.12 Date: Fri, 7 Jul 2023 14:01:12 -0400 Message-ID: <20230707180121.3101370-1-yselkowi@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Yaakov Selkowitz via Libabigail From: Yaakov Selkowitz Reply-To: Yaakov Selkowitz Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" importlib is the Python 3 replacement to imp, which was deprecated in Python 3.4 and removed in 3.12. * configure.ac (REQUIRED_PYTHON_MODULES_FOR_FEDABIPKGDIFF): Test for importlib.machinery instead of imp with python3. Signed-off-by: Yaakov Selkowitz --- configure.ac | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index b4e7e38e..b3f97ba2 100644 --- a/configure.ac +++ b/configure.ac @@ -739,13 +739,15 @@ if test x$CHECK_DEPS_FOR_FEDABIPKGDIFF = xyes; then # urllib.parse. Oh well. if test x$PYTHON = xpython3; then URLPARSE_MODULE=urllib.parse + IMPORT_MODULE=importlib.machinery else URLPARSE_MODULE=urlparse + IMPORT_MODULE=imp fi REQUIRED_PYTHON_MODULES_FOR_FEDABIPKGDIFF="\ argparse logging os re subprocess sys $URLPARSE_MODULE \ - xdg koji mock rpm imp tempfile mimetypes shutil six" + xdg koji mock rpm $IMPORT_MODULE tempfile mimetypes shutil six" AX_CHECK_PYTHON_MODULES([$REQUIRED_PYTHON_MODULES_FOR_FEDABIPKGDIFF], [$PYTHON],