diff mbox series

[v3,4/4] Remove set-hooks.h from generic includes

Message ID 20221227211145.3765256-5-adhemerval.zanella@linaro.org
State Superseded
Headers
Series Remove --with-default-link option |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

Adhemerval Zanella Dec. 27, 2022, 9:11 p.m. UTC 
  The hooks mechanism uses symbol sets for running lists of functions,
which requires either extra linker directives to provide any hardening
(such RELRO) or additional code (such as pointer obfuscation via
mangling with random value).

Currently only hurd uses it and there multiple examples where using
direct function call provides both hardening and good code generation
without the need to extra link or code handling.
---
 {include => hurd}/set-hooks.h | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename {include => hurd}/set-hooks.h (100%)

Comments

Carlos O'Donell March 4, 2023, 5:42 p.m. UTC | #1 
On 12/27/22 16:11, Adhemerval Zanella via Libc-alpha wrote:
> The hooks mechanism uses symbol sets for running lists of functions,
> which requires either extra linker directives to provide any hardening
> (such RELRO) or additional code (such as pointer obfuscation via

s/such/such as/g

> mangling with random value).

Please post v4.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

> 
> Currently only hurd uses it and there multiple examples where using
> direct function call provides both hardening and good code generation
> without the need to extra link or code handling.

Suggest:
Currently only hurd uses set-hooks.h so we remove it from the generic includes.
The generic implementation uses direct function calls which provide hardening
and good code generation, observability and debugging without the need for extra
linking options or special code handling.

> ---
>  {include => hurd}/set-hooks.h | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename {include => hurd}/set-hooks.h (100%)
> 
> diff --git a/include/set-hooks.h b/hurd/set-hooks.h
> similarity index 100%
> rename from include/set-hooks.h
> rename to hurd/set-hooks.h
diff mbox series

Patch

diff --git a/include/set-hooks.h b/hurd/set-hooks.h
similarity index 100%
rename from include/set-hooks.h
rename to hurd/set-hooks.h