| Message ID | 20221227211145.3765256-1-adhemerval.zanella@linaro.org |
|---|---|
| Headers |
Return-Path: <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 630B83858434 for <patchwork@sourceware.org>; Tue, 27 Dec 2022 21:12:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 630B83858434 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1672175536; bh=VYyJEUivZuLYyiqHUVuTKcX0wRxhFnbSFhKBTGsECsU=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=wHM/uJd5LuEm8mCZeTsEHqbJ795eEr3qbX4H+C2drnpsL+7TldJswgRjwED/h4shb jJ/oaC6bPkXBK9R341CNXT1LBb534gAJOlywLVCKRSbW7t9JWmfUauTCKNDXkz0efm OfHrW1WIvUk4+xuu92tUPjVLYTZ8zm78BujPkM3I= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-oa1-x32.google.com (mail-oa1-x32.google.com [IPv6:2001:4860:4864:20::32]) by sourceware.org (Postfix) with ESMTPS id A397A3858D37 for <libc-alpha@sourceware.org>; Tue, 27 Dec 2022 21:11:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A397A3858D37 Received: by mail-oa1-x32.google.com with SMTP id 586e51a60fabf-14fb7fdb977so10079609fac.12 for <libc-alpha@sourceware.org>; Tue, 27 Dec 2022 13:11:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VYyJEUivZuLYyiqHUVuTKcX0wRxhFnbSFhKBTGsECsU=; b=wgcdCUl9gNQvh25pDVMt0qcyHkfTRHCo4wqumWLv5KSyAbEGMwj4YXdCYzG28vNWuQ kXYFpp7LWxeXaa3HOMBiqf/FPRcgX6TGlMUqeMIbgrn8t9ZxILXNWj7Uu4o3ZMvyzxeY QnjNnlrfnPGW8q251aYH/1fJnW9/KOnowdqR7CCs1diVhm/Gan7ssZE98OBrIFhYFiZ8 RQN6q8JG5bK6gIukSUCD3UOSgOwy/1D+LHcZE3yOEInRGWDXy+/EXpZom8HQrOpX7fHV YbsgZX09+wteJ3mx/Fs5b2xdEfv+kMnuPtQ4OTm15Wm4Gyxc8xHJY3K5jSg/YU2ESGoL OHcQ== X-Gm-Message-State: AFqh2koNcx6FdTd3ezLe41Ne2XP7c0r20tRyCApZ0cP3A4XXgGiRWAjo mmhJYBS7pYoD4hfw/U7mY1qPoChTmvNSuwSzA/k= X-Google-Smtp-Source: AMrXdXthJkLgx4qmpEAOGluJ75/H1Gpx2RJ7AtrRh5/zQQA3DRPSmafv1fXKoEN1SkwQjqfqLRRKvw== X-Received: by 2002:a05:6870:d0d:b0:148:4e20:c531 with SMTP id mk13-20020a0568700d0d00b001484e20c531mr10228122oab.28.1672175509679; Tue, 27 Dec 2022 13:11:49 -0800 (PST) Received: from mandiga.. ([2804:1b3:a7c3:dd36:5c8b:974f:479c:a0d4]) by smtp.gmail.com with ESMTPSA id n7-20020a4aa7c7000000b004db65419011sm850955oom.34.2022.12.27.13.11.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Dec 2022 13:11:48 -0800 (PST) To: libc-alpha@sourceware.org, Florian Weimer <fweimer@redhat.com> Subject: [PATCH v3 0/4] Remove --with-default-link option Date: Tue, 27 Dec 2022 18:11:41 -0300 Message-Id: <20221227211145.3765256-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Adhemerval Zanella <adhemerval.zanella@linaro.org> Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> |
| Series | Remove --with-default-link option | |
Message
Adhemerval Zanella Netto
Dec. 27, 2022, 9:11 p.m. UTC
The vtables hardening are not enabled with --with-default-link=no
(tst-relro-libc fails [1]) and with --with-default-link=yes it also
requires ld.bfd to be available [2]. Furthermore, only lld 15
supports custom RELRO sections in linker script, even though older
version does support building glibc for some architectures.
The patchset removes the --with-default-link by replacing
libc_freeres_ptrs and libc_subfreeres with weak function calls, and by
refactoring the vtables hardening with a array placed directly on
RELRO segment.
[1] https://sourceware.org/bugzilla/show_bug.cgi?id=25812
[2] https://sourceware.org/git/?p=glibc.git;a=commit;h=2ae7990542e1955097aa21943e416dec70f867fa
Changes from v2:
- Add pragma weak for weakly called function at malloc/set-freeres.c.
- Remove _IO_str_*, _IO_new_file_*, and _IO_old_ from pragma weak directive.
Adhemerval Zanella (4):
Move libc_freeres_ptrs and libc_subfreeres to hidden/weak functions
libio: Remove the usage of __libc_IO_vtables
Remove --with-default-link configure option
Remove set-hooks.h from generic includes
INSTALL | 6 -
Makerules | 52 +-
config.make.in | 1 -
configure | 13 -
configure.ac | 7 -
crypt/md5-crypt.c | 7 +-
crypt/sha256-crypt.c | 7 +-
crypt/sha512-crypt.c | 7 +-
dlfcn/dlerror.h | 1 -
elf/Makefile | 18 +-
elf/dl-libc.c | 5 +-
grp/fgetgrent.c | 5 +-
gshadow/fgetsgent.c | 5 +-
{include => hurd}/set-hooks.h | 0
iconv/gconv_cache.c | 3 +-
iconv/gconv_conf.c | 3 +-
iconv/gconv_db.c | 6 +-
iconv/gconv_dl.c | 5 +-
iconvdata/extra-module.mk | 2 +-
include/libc-symbols.h | 91 +---
include/set-freeres.h | 142 +++++
inet/getnameinfo.c | 5 +-
inet/getnetgrent.c | 5 +-
inet/rcmd.c | 5 +-
inet/rexec.c | 5 +-
intl/dcigettext.c | 3 +-
intl/finddomain.c | 2 +-
intl/loadmsgcat.c | 1 -
intl/localealias.c | 15 +-
libio/Makefile | 2 +
libio/fcloseall.c | 1 +
libio/fileops.c | 81 +--
libio/genops.c | 8 +-
libio/iofopncook.c | 60 +--
libio/iopopen.c | 25 -
libio/libio-macros.sym | 7 +
libio/libioP.h | 137 ++++-
libio/memstream.c | 32 +-
libio/oldfileops.c | 23 -
libio/oldiopopen.c | 23 -
libio/stdio.c | 3 +
libio/strfile.h | 2 -
libio/strops.c | 24 -
libio/tst-vtables-interposed.c | 5 +
libio/vtables.c | 497 ++++++++++++++++++
libio/wfileops.c | 79 +--
libio/wmemstream.c | 32 +-
libio/wstrops.c | 24 -
locale/loadarchive.c | 2 +-
locale/localeinfo.h | 4 +-
locale/setlocale.c | 4 +-
login/getutent.c | 5 +-
login/getutid.c | 6 +-
login/getutline.c | 5 +-
malloc/set-freeres.c | 156 +++++-
malloc/thread-freeres.c | 9 +-
manual/install.texi | 6 -
misc/efgcvt-template.c | 5 +-
misc/efgcvt.c | 1 +
misc/fstab.c | 3 +-
misc/hsearch.c | 4 -
misc/mntent.c | 5 +-
misc/qefgcvt.c | 1 +
misc/unwind-link.c | 2 +-
nptl/nptlfreeres.c | 1 -
nscd/nscd_getgr_r.c | 3 +-
nscd/nscd_gethst_r.c | 3 +-
nscd/nscd_getpw_r.c | 3 +-
nscd/nscd_getserv_r.c | 3 +-
nscd/nscd_netgroup.c | 3 +-
nss/getXXbyYY.c | 7 +-
nss/getXXent.c | 7 +-
nss/nss_action.c | 2 +-
nss/nss_action.h | 3 -
nss/nss_database.c | 2 +-
nss/nss_database.h | 3 -
nss/nss_module.c | 2 +-
nss/nss_module.h | 3 -
posix/regcomp.c | 3 +-
posix/register-atfork.c | 3 +-
pwd/fgetpwent.c | 5 +-
resolv/gai_misc.c | 6 +-
resolv/res-close.c | 2 -
resolv/res_hconf.c | 16 +-
resolv/resolv-internal.h | 14 +
resolv/resolv_conf.c | 3 +-
resolv/tst-leaks2.c | 2 +
rt/aio_misc.c | 6 +-
shadow/fgetspent.c | 5 +-
stdio-common/printf_buffer_as_file.c | 28 +-
stdio-common/reg-modifier.c | 3 +-
stdio-common/reg-printf.c | 6 +-
stdio-common/reg-type.c | 6 +-
stdio-common/wprintf_buffer_as_file.c | 28 +-
stdlib/exit.c | 2 +-
stdlib/fmtmsg.c | 3 +-
stdlib/setenv.c | 3 +-
sunrpc/clnt_perr.c | 4 +-
sunrpc/rpc_thread.c | 1 -
sunrpc/tst-svc_register.c | 6 +-
sysdeps/generic/set-freeres-fp.h | 19 +
sysdeps/generic/set-freeres-os.h | 19 +
sysdeps/generic/set-freeres-system.h | 27 +
.../ldbl-128ibm-compat/ieee128-qefgcvt.c | 1 +
.../ldbl-128ibm-compat/set-freeres-fp.h | 22 +
sysdeps/mach/hurd/bits/errno.h | 1 -
sysdeps/posix/getaddrinfo.c | 5 +-
sysdeps/posix/ttyname.c | 4 +-
sysdeps/unix/sysv/linux/check_pf.c | 3 +-
.../unix/sysv/linux/s390/s390-32/getutent.c | 1 +
.../unix/sysv/linux/s390/s390-32/getutid.c | 1 +
.../unix/sysv/linux/s390/s390-32/getutline.c | 1 +
sysdeps/unix/sysv/linux/set-freeres-os.h | 24 +
sysdeps/unix/sysv/linux/ttyname.c | 8 +-
time/tzfile.c | 5 +-
time/tzset.c | 3 +-
116 files changed, 1247 insertions(+), 807 deletions(-)
rename {include => hurd}/set-hooks.h (100%)
create mode 100644 include/set-freeres.h
create mode 100644 libio/libio-macros.sym
create mode 100644 sysdeps/generic/set-freeres-fp.h
create mode 100644 sysdeps/generic/set-freeres-os.h
create mode 100644 sysdeps/generic/set-freeres-system.h
create mode 100644 sysdeps/ieee754/ldbl-128ibm-compat/set-freeres-fp.h
create mode 100644 sysdeps/unix/sysv/linux/set-freeres-os.h
Comments
On 12/27/22 16:11, Adhemerval Zanella via Libc-alpha wrote: > The vtables hardening are not enabled with --with-default-link=no s/are/is/g > (tst-relro-libc fails [1]) and with --with-default-link=yes it also > requires ld.bfd to be available [2]. Furthermore, only lld 15 > supports custom RELRO sections in linker script, even though older > version does support building glibc for some architectures. s/version does/versions do/g > > The patchset removes the --with-default-link by replacing > libc_freeres_ptrs and libc_subfreeres with weak function calls, and by > refactoring the vtables hardening with a array placed directly on s/a/an/g s/on/in the/g Please post v4. > RELRO segment. > > [1] https://sourceware.org/bugzilla/show_bug.cgi?id=25812 > [2] https://sourceware.org/git/?p=glibc.git;a=commit;h=2ae7990542e1955097aa21943e416dec70f867fa > > Changes from v2: > - Add pragma weak for weakly called function at malloc/set-freeres.c. > - Remove _IO_str_*, _IO_new_file_*, and _IO_old_ from pragma weak directive. > > Adhemerval Zanella (4): > Move libc_freeres_ptrs and libc_subfreeres to hidden/weak functions > libio: Remove the usage of __libc_IO_vtables > Remove --with-default-link configure option > Remove set-hooks.h from generic includes > > INSTALL | 6 - > Makerules | 52 +- > config.make.in | 1 - > configure | 13 - > configure.ac | 7 - > crypt/md5-crypt.c | 7 +- > crypt/sha256-crypt.c | 7 +- > crypt/sha512-crypt.c | 7 +- > dlfcn/dlerror.h | 1 - > elf/Makefile | 18 +- > elf/dl-libc.c | 5 +- > grp/fgetgrent.c | 5 +- > gshadow/fgetsgent.c | 5 +- > {include => hurd}/set-hooks.h | 0 > iconv/gconv_cache.c | 3 +- > iconv/gconv_conf.c | 3 +- > iconv/gconv_db.c | 6 +- > iconv/gconv_dl.c | 5 +- > iconvdata/extra-module.mk | 2 +- > include/libc-symbols.h | 91 +--- > include/set-freeres.h | 142 +++++ > inet/getnameinfo.c | 5 +- > inet/getnetgrent.c | 5 +- > inet/rcmd.c | 5 +- > inet/rexec.c | 5 +- > intl/dcigettext.c | 3 +- > intl/finddomain.c | 2 +- > intl/loadmsgcat.c | 1 - > intl/localealias.c | 15 +- > libio/Makefile | 2 + > libio/fcloseall.c | 1 + > libio/fileops.c | 81 +-- > libio/genops.c | 8 +- > libio/iofopncook.c | 60 +-- > libio/iopopen.c | 25 - > libio/libio-macros.sym | 7 + > libio/libioP.h | 137 ++++- > libio/memstream.c | 32 +- > libio/oldfileops.c | 23 - > libio/oldiopopen.c | 23 - > libio/stdio.c | 3 + > libio/strfile.h | 2 - > libio/strops.c | 24 - > libio/tst-vtables-interposed.c | 5 + > libio/vtables.c | 497 ++++++++++++++++++ > libio/wfileops.c | 79 +-- > libio/wmemstream.c | 32 +- > libio/wstrops.c | 24 - > locale/loadarchive.c | 2 +- > locale/localeinfo.h | 4 +- > locale/setlocale.c | 4 +- > login/getutent.c | 5 +- > login/getutid.c | 6 +- > login/getutline.c | 5 +- > malloc/set-freeres.c | 156 +++++- > malloc/thread-freeres.c | 9 +- > manual/install.texi | 6 - > misc/efgcvt-template.c | 5 +- > misc/efgcvt.c | 1 + > misc/fstab.c | 3 +- > misc/hsearch.c | 4 - > misc/mntent.c | 5 +- > misc/qefgcvt.c | 1 + > misc/unwind-link.c | 2 +- > nptl/nptlfreeres.c | 1 - > nscd/nscd_getgr_r.c | 3 +- > nscd/nscd_gethst_r.c | 3 +- > nscd/nscd_getpw_r.c | 3 +- > nscd/nscd_getserv_r.c | 3 +- > nscd/nscd_netgroup.c | 3 +- > nss/getXXbyYY.c | 7 +- > nss/getXXent.c | 7 +- > nss/nss_action.c | 2 +- > nss/nss_action.h | 3 - > nss/nss_database.c | 2 +- > nss/nss_database.h | 3 - > nss/nss_module.c | 2 +- > nss/nss_module.h | 3 - > posix/regcomp.c | 3 +- > posix/register-atfork.c | 3 +- > pwd/fgetpwent.c | 5 +- > resolv/gai_misc.c | 6 +- > resolv/res-close.c | 2 - > resolv/res_hconf.c | 16 +- > resolv/resolv-internal.h | 14 + > resolv/resolv_conf.c | 3 +- > resolv/tst-leaks2.c | 2 + > rt/aio_misc.c | 6 +- > shadow/fgetspent.c | 5 +- > stdio-common/printf_buffer_as_file.c | 28 +- > stdio-common/reg-modifier.c | 3 +- > stdio-common/reg-printf.c | 6 +- > stdio-common/reg-type.c | 6 +- > stdio-common/wprintf_buffer_as_file.c | 28 +- > stdlib/exit.c | 2 +- > stdlib/fmtmsg.c | 3 +- > stdlib/setenv.c | 3 +- > sunrpc/clnt_perr.c | 4 +- > sunrpc/rpc_thread.c | 1 - > sunrpc/tst-svc_register.c | 6 +- > sysdeps/generic/set-freeres-fp.h | 19 + > sysdeps/generic/set-freeres-os.h | 19 + > sysdeps/generic/set-freeres-system.h | 27 + > .../ldbl-128ibm-compat/ieee128-qefgcvt.c | 1 + > .../ldbl-128ibm-compat/set-freeres-fp.h | 22 + > sysdeps/mach/hurd/bits/errno.h | 1 - > sysdeps/posix/getaddrinfo.c | 5 +- > sysdeps/posix/ttyname.c | 4 +- > sysdeps/unix/sysv/linux/check_pf.c | 3 +- > .../unix/sysv/linux/s390/s390-32/getutent.c | 1 + > .../unix/sysv/linux/s390/s390-32/getutid.c | 1 + > .../unix/sysv/linux/s390/s390-32/getutline.c | 1 + > sysdeps/unix/sysv/linux/set-freeres-os.h | 24 + > sysdeps/unix/sysv/linux/ttyname.c | 8 +- > time/tzfile.c | 5 +- > time/tzset.c | 3 +- > 116 files changed, 1247 insertions(+), 807 deletions(-) > rename {include => hurd}/set-hooks.h (100%) > create mode 100644 include/set-freeres.h > create mode 100644 libio/libio-macros.sym > create mode 100644 sysdeps/generic/set-freeres-fp.h > create mode 100644 sysdeps/generic/set-freeres-os.h > create mode 100644 sysdeps/generic/set-freeres-system.h > create mode 100644 sysdeps/ieee754/ldbl-128ibm-compat/set-freeres-fp.h > create mode 100644 sysdeps/unix/sysv/linux/set-freeres-os.h >
On 04/03/23 14:37, Carlos O'Donell wrote: > On 12/27/22 16:11, Adhemerval Zanella via Libc-alpha wrote: >> The vtables hardening are not enabled with --with-default-link=no > > s/are/is/g > >> (tst-relro-libc fails [1]) and with --with-default-link=yes it also >> requires ld.bfd to be available [2]. Furthermore, only lld 15 >> supports custom RELRO sections in linker script, even though older >> version does support building glibc for some architectures. > > s/version does/versions do/g > >> >> The patchset removes the --with-default-link by replacing >> libc_freeres_ptrs and libc_subfreeres with weak function calls, and by >> refactoring the vtables hardening with a array placed directly on > > s/a/an/g > s/on/in the/g > > Please post v4. Ack.