diff mbox series

[2/6] configure: Remove check if as is GNU

Message ID 20221202190030.1671870-3-adhemerval.zanella@linaro.org
State Committed
Commit f35b7ce02fcf5267e128f25d4b01b80711a01110
Headers
Series Refactor binutils configure usage |

Commit Message

Adhemerval Zanella Netto Dec. 2, 2022, 7 p.m. UTC 
  It is not used in any place.
---
 aclocal.m4 |  6 ------
 configure  | 20 --------------------
 2 files changed, 26 deletions(-)

Comments

Carlos O'Donell Dec. 5, 2022, 3:56 p.m. UTC | #1 
On 12/2/22 14:00, Adhemerval Zanella via Libc-alpha wrote:
> It is not used in any place.

Good cleanup. Verified it isn't used.

LGTM.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

> ---
>  aclocal.m4 |  6 ------
>  configure  | 20 --------------------
>  2 files changed, 26 deletions(-)
> 
> diff --git a/aclocal.m4 b/aclocal.m4
> index 531b11cb69..149b9e5376 100644
> --- a/aclocal.m4
> +++ b/aclocal.m4
> @@ -127,12 +127,6 @@ AC_SUBST(OBJCOPY)
>  GPROF=`$CC -print-prog-name=gprof`
>  AC_SUBST(GPROF)
>  
> -# Determine whether we are using GNU binutils.
> -AC_CACHE_CHECK(whether $AS is GNU as, libc_cv_prog_as_gnu,
> -[LIBC_PROG_FOO_GNU($AS, libc_cv_prog_as_gnu=yes, libc_cv_prog_as_gnu=no)])
> -rm -f a.out
> -gnu_as=$libc_cv_prog_as_gnu
> -

OK. Remove.

>  AC_CACHE_CHECK(whether $LD is GNU ld, libc_cv_prog_ld_gnu,
>  [LIBC_PROG_FOO_GNU($LD, libc_cv_prog_ld_gnu=yes, libc_cv_prog_ld_gnu=no)])
>  gnu_ld=$libc_cv_prog_ld_gnu
> diff --git a/configure b/configure
> index 9a8acc4ef7..2d3b3946b9 100755
> --- a/configure
> +++ b/configure

OK. Regenerate.

> @@ -4155,26 +4155,6 @@ OBJCOPY=`$CC -print-prog-name=objcopy`
>  GPROF=`$CC -print-prog-name=gprof`
>  
>  
> -# Determine whether we are using GNU binutils.
> -{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $AS is GNU as" >&5
> -$as_echo_n "checking whether $AS is GNU as... " >&6; }
> -if ${libc_cv_prog_as_gnu+:} false; then :
> -  $as_echo_n "(cached) " >&6
> -else
> -  # Most GNU programs take a -v and spit out some text including
> -# the word 'GNU'.  Some try to read stdin, so give them /dev/null.
> -if $AS -o conftest -v </dev/null 2>&1 | grep GNU > /dev/null 2>&1; then
> -  libc_cv_prog_as_gnu=yes
> -else
> -  libc_cv_prog_as_gnu=no
> -fi
> -rm -fr contest*
> -fi
> -{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_prog_as_gnu" >&5
> -$as_echo "$libc_cv_prog_as_gnu" >&6; }
> -rm -f a.out
> -gnu_as=$libc_cv_prog_as_gnu
> -
>  { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $LD is GNU ld" >&5
>  $as_echo_n "checking whether $LD is GNU ld... " >&6; }
>  if ${libc_cv_prog_ld_gnu+:} false; then :
diff mbox series

Patch

diff --git a/aclocal.m4 b/aclocal.m4
index 531b11cb69..149b9e5376 100644
--- a/aclocal.m4
+++ b/aclocal.m4
@@ -127,12 +127,6 @@  AC_SUBST(OBJCOPY)
 GPROF=`$CC -print-prog-name=gprof`
 AC_SUBST(GPROF)
 
-# Determine whether we are using GNU binutils.
-AC_CACHE_CHECK(whether $AS is GNU as, libc_cv_prog_as_gnu,
-[LIBC_PROG_FOO_GNU($AS, libc_cv_prog_as_gnu=yes, libc_cv_prog_as_gnu=no)])
-rm -f a.out
-gnu_as=$libc_cv_prog_as_gnu
-
 AC_CACHE_CHECK(whether $LD is GNU ld, libc_cv_prog_ld_gnu,
 [LIBC_PROG_FOO_GNU($LD, libc_cv_prog_ld_gnu=yes, libc_cv_prog_ld_gnu=no)])
 gnu_ld=$libc_cv_prog_ld_gnu
diff --git a/configure b/configure
index 9a8acc4ef7..2d3b3946b9 100755
--- a/configure
+++ b/configure
@@ -4155,26 +4155,6 @@  OBJCOPY=`$CC -print-prog-name=objcopy`
 GPROF=`$CC -print-prog-name=gprof`
 
 
-# Determine whether we are using GNU binutils.
-{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $AS is GNU as" >&5
-$as_echo_n "checking whether $AS is GNU as... " >&6; }
-if ${libc_cv_prog_as_gnu+:} false; then :
-  $as_echo_n "(cached) " >&6
-else
-  # Most GNU programs take a -v and spit out some text including
-# the word 'GNU'.  Some try to read stdin, so give them /dev/null.
-if $AS -o conftest -v </dev/null 2>&1 | grep GNU > /dev/null 2>&1; then
-  libc_cv_prog_as_gnu=yes
-else
-  libc_cv_prog_as_gnu=no
-fi
-rm -fr contest*
-fi
-{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_prog_as_gnu" >&5
-$as_echo "$libc_cv_prog_as_gnu" >&6; }
-rm -f a.out
-gnu_as=$libc_cv_prog_as_gnu
-
 { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $LD is GNU ld" >&5
 $as_echo_n "checking whether $LD is GNU ld... " >&6; }
 if ${libc_cv_prog_ld_gnu+:} false; then :