mbox series

[0/6] Refactor binutils configure usage

Message ID 20221202190030.1671870-1-adhemerval.zanella@linaro.org
Headers
Series Refactor binutils configure usage |

Message

Adhemerval Zanella Netto Dec. 2, 2022, 7 p.m. UTC 
  This patchset fixes a long standing issue where some configure checks
are no done with the target binutils, remove some old definitions not
required anymore, remove the AS usage (since it is not used directly),
and allow all binutils tools to be overriden at configure time.

It should restore the previous behavious while setting OUTPUT_FORMAT
for multilib toolchains.  If the uses requires a different binutils
tool as default, it can always override at configure time.

Adhemerval Zanella (6):
  configure: Move locale tools early
  configure: Remove check if as is GNU
  configure: Remove check if ld is GNU
  configure: Remove AS check
  configure: Allow user override LD, AR, OBJCOPY, and GPROF
  configure: Move nm, objdump, and readelf to LIBC_PROG_BINUTILS

 aclocal.m4                                |   67 +-
 configure                                 | 2441 +++++++++------------
 configure.ac                              |  233 +-
 scripts/build-many-glibcs.py              |    1 -
 sysdeps/unix/sysv/linux/powerpc/configure |   28 +-
 sysdeps/x86/configure                     |    4 +-
 sysdeps/x86/configure.ac                  |    2 +-
 7 files changed, 1200 insertions(+), 1576 deletions(-)

Comments

Vineet Gupta Dec. 20, 2022, 10:01 p.m. UTC | #1 
Hi Adhemerval,

On 12/2/22 11:00, Adhemerval Zanella wrote:
> This patchset fixes a long standing issue where some configure checks
> are no done with the target binutils, remove some old definitions not
> required anymore, remove the AS usage (since it is not used directly),
> and allow all binutils tools to be overriden at configure time.
>
> It should restore the previous behavious while setting OUTPUT_FORMAT
> for multilib toolchains.  If the uses requires a different binutils
> tool as default, it can always override at configure time.

As of upstream today, cross builds are still broken for OUTPUT_FORMAT.

Thx,
-Vineet


>
> Adhemerval Zanella (6):
>    configure: Move locale tools early
>    configure: Remove check if as is GNU
>    configure: Remove check if ld is GNU
>    configure: Remove AS check
>    configure: Allow user override LD, AR, OBJCOPY, and GPROF
>    configure: Move nm, objdump, and readelf to LIBC_PROG_BINUTILS
>
>   aclocal.m4                                |   67 +-
>   configure                                 | 2441 +++++++++------------
>   configure.ac                              |  233 +-
>   scripts/build-many-glibcs.py              |    1 -
>   sysdeps/unix/sysv/linux/powerpc/configure |   28 +-
>   sysdeps/x86/configure                     |    4 +-
>   sysdeps/x86/configure.ac                  |    2 +-
>   7 files changed, 1200 insertions(+), 1576 deletions(-)
>
Adhemerval Zanella Netto Dec. 22, 2022, 12:54 p.m. UTC | #2 
On 20/12/22 19:01, Vineet Gupta wrote:
> Hi Adhemerval,
> 
> On 12/2/22 11:00, Adhemerval Zanella wrote:
>> This patchset fixes a long standing issue where some configure checks
>> are no done with the target binutils, remove some old definitions not
>> required anymore, remove the AS usage (since it is not used directly),
>> and allow all binutils tools to be overriden at configure time.
>>
>> It should restore the previous behavious while setting OUTPUT_FORMAT
>> for multilib toolchains.  If the uses requires a different binutils
>> tool as default, it can always override at configure time.
> 
> As of upstream today, cross builds are still broken for OUTPUT_FORMAT.
> 
> Thx,
> -Vineet

Yeap, we still need someone to help review my v2 [1].

[1] https://patchwork.sourceware.org/project/glibc/list/?series=14999
Vineet Gupta Jan. 5, 2023, 9:39 p.m. UTC | #3 
Hi Carlos,

On 12/22/22 04:54, Adhemerval Zanella Netto wrote:
>
> On 20/12/22 19:01, Vineet Gupta wrote:
>> Hi Adhemerval,
>>
>> On 12/2/22 11:00, Adhemerval Zanella wrote:
>>> This patchset fixes a long standing issue where some configure checks
>>> are no done with the target binutils, remove some old definitions not
>>> required anymore, remove the AS usage (since it is not used directly),
>>> and allow all binutils tools to be overriden at configure time.
>>>
>>> It should restore the previous behavious while setting OUTPUT_FORMAT
>>> for multilib toolchains.  If the uses requires a different binutils
>>> tool as default, it can always override at configure time.
>> As of upstream today, cross builds are still broken for OUTPUT_FORMAT.
>>
>> Thx,
>> -Vineet
> Yeap, we still need someone to help review my v2 [1].
>
> [1] https://patchwork.sourceware.org/project/glibc/list/?series=14999

Can you please help review the patches.

Thx,
-Vineet
Adhemerval Zanella Netto Jan. 5, 2023, 9:54 p.m. UTC | #4 
On 05/01/23 18:39, Vineet Gupta wrote:
> Hi Carlos,
> 
> On 12/22/22 04:54, Adhemerval Zanella Netto wrote:
>>
>> On 20/12/22 19:01, Vineet Gupta wrote:
>>> Hi Adhemerval,
>>>
>>> On 12/2/22 11:00, Adhemerval Zanella wrote:
>>>> This patchset fixes a long standing issue where some configure checks
>>>> are no done with the target binutils, remove some old definitions not
>>>> required anymore, remove the AS usage (since it is not used directly),
>>>> and allow all binutils tools to be overriden at configure time.
>>>>
>>>> It should restore the previous behavious while setting OUTPUT_FORMAT
>>>> for multilib toolchains.  If the uses requires a different binutils
>>>> tool as default, it can always override at configure time.
>>> As of upstream today, cross builds are still broken for OUTPUT_FORMAT.
>>>
>>> Thx,
>>> -Vineet
>> Yeap, we still need someone to help review my v2 [1].
>>
>> [1] https://patchwork.sourceware.org/project/glibc/list/?series=14999
> 
> Can you please help review the patches.

This is the latest version [1] and I have added is a release blocker for
2.37 [2].

[1] https://patchwork.sourceware.org/project/glibc/list/?series=14999
[2] https://sourceware.org/glibc/wiki/Release/2.37