diff mbox series

[pushed] gdb: remove some trivial uses of current_program_space

Message ID 20240715150756.23387-1-simon.marchi@efficios.com
State New
Headers
Series [pushed] gdb: remove some trivial uses of current_program_space |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 warning Patch is already merged
linaro-tcwg-bot/tcwg_gdb_build--master-arm warning Patch is already merged

Commit Message

Simon Marchi July 15, 2024, 3:07 p.m. UTC 
  It is obvious that pspace is the same as current_program_space in these
cases, due to the set_current_program_space call just above.  The rest
of the functions probably care about the current program space though,
so leave the set_cset_current_program_space calls there.

Change-Id: I3c300decbf2c2fe5f25aa7f697ebcb524432394f
---
 gdb/breakpoint.c | 4 ++--
 gdb/linespec.c   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)


base-commit: 25c228409597bcb7114a9a839ac08db0ba995418
diff mbox series

Patch

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index f32883eb3bc3..84b18ecb4b03 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -3710,7 +3710,7 @@  create_longjmp_master_breakpoint (void)
     {
       set_current_program_space (pspace);
 
-      for (objfile *obj : current_program_space->objfiles ())
+      for (objfile *obj : pspace->objfiles ())
 	{
 	  /* Skip separate debug object, it's handled in the loop below.  */
 	  if (obj->separate_debug_objfile_backlink != nullptr)
@@ -3743,7 +3743,7 @@  create_std_terminate_master_breakpoint (void)
     {
       set_current_program_space (pspace);
 
-      for (objfile *objfile : current_program_space->objfiles ())
+      for (objfile *objfile : pspace->objfiles ())
 	{
 	  struct breakpoint *b;
 	  struct breakpoint_objfile_data *bp_objfile_data;
diff --git a/gdb/linespec.c b/gdb/linespec.c
index d24d6912e347..9769f011fae1 100644
--- a/gdb/linespec.c
+++ b/gdb/linespec.c
@@ -1156,7 +1156,7 @@  iterate_over_all_matching_symtabs
 
       set_current_program_space (pspace);
 
-      for (objfile *objfile : current_program_space->objfiles ())
+      for (objfile *objfile : pspace->objfiles ())
 	{
 	  objfile->expand_symtabs_matching (NULL, &lookup_name, NULL, NULL,
 					    (SEARCH_GLOBAL_BLOCK
@@ -4213,7 +4213,7 @@  search_minsyms_for_name (struct collect_info *info,
 
 	  set_current_program_space (pspace);
 
-	  for (objfile *objfile : current_program_space->objfiles ())
+	  for (objfile *objfile : pspace->objfiles ())
 	    {
 	      iterate_over_minimal_symbols (objfile, name,
 					    [&] (struct minimal_symbol *msym)