diff mbox series

[2/3] gdb, amd64: remove unused forward declerations

Message ID 20240523134842.3019820-3-felix.willgerodt@intel.com
State New
Headers
Series Minor amd64/avx512 improvments |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Testing passed

Commit Message

Willgerodt, Felix May 23, 2024, 1:48 p.m. UTC 
  These structs are not referenced anywhere anymore and seemed to have been
missed at some point when their usage was removed.

Co-authored-by: Nils-Christian Kempke <nils-christian.kempke@intel.com>
---
 gdb/amd64-linux-tdep.h | 12 ------------
 1 file changed, 12 deletions(-)

Comments

Tom Tromey May 23, 2024, 2:08 p.m. UTC | #1 
>>>>> "Felix" == Felix Willgerodt <felix.willgerodt@intel.com> writes:

Felix> These structs are not referenced anywhere anymore and seemed to have been
Felix> missed at some point when their usage was removed.

Felix> Co-authored-by: Nils-Christian Kempke <nils-christian.kempke@intel.com>

Seems obvious to me.  Thanks.
Approved-By: Tom Tromey <tom@tromey.com>

Tom
Willgerodt, Felix May 31, 2024, 7:35 a.m. UTC | #2 
> -----Original Message-----
> From: Tom Tromey <tom@tromey.com>
> Sent: Donnerstag, 23. Mai 2024 16:09
> To: Willgerodt, Felix <felix.willgerodt@intel.com>
> Cc: gdb-patches@sourceware.org
> Subject: Re: [PATCH 2/3] gdb, amd64: remove unused forward declerations
> 
> >>>>> "Felix" == Felix Willgerodt <felix.willgerodt@intel.com> writes:
> 
> Felix> These structs are not referenced anywhere anymore and seemed to have
> been
> Felix> missed at some point when their usage was removed.
> 
> Felix> Co-authored-by: Nils-Christian Kempke <nils-christian.kempke@intel.com>
> 
> Seems obvious to me.  Thanks.
> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom

Thanks, I pushed this!

Felix
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
diff mbox series

Patch

diff --git a/gdb/amd64-linux-tdep.h b/gdb/amd64-linux-tdep.h
index 2003dcda78f..66170256639 100644
--- a/gdb/amd64-linux-tdep.h
+++ b/gdb/amd64-linux-tdep.h
@@ -31,18 +31,6 @@ 
 /* Total number of registers for GNU/Linux.  */
 #define AMD64_LINUX_NUM_REGS (AMD64_LINUX_ORIG_RAX_REGNUM + 1)
 
-/* Linux target description.  */
-extern struct target_desc *tdesc_amd64_linux;
-extern struct target_desc *tdesc_amd64_avx_linux;
-extern struct target_desc *tdesc_amd64_mpx_linux;
-extern struct target_desc *tdesc_amd64_avx_mpx_linux;
-extern struct target_desc *tdesc_amd64_avx_avx512_linux;
-extern struct target_desc *tdesc_amd64_avx_mpx_avx512_pku_linux;
-
-extern struct target_desc *tdesc_x32_linux;
-extern struct target_desc *tdesc_x32_avx_linux;
-extern struct target_desc *tdesc_x32_avx_avx512_linux;
-
 /* Return the right amd64-linux target descriptions according to
    XCR0_FEATURES_BIT and IS_X32.  */