[pushed] Fix crash in gdb_rl_callback_handler
Checks
Commit Message
commit bdcd50f9 ("Strip trailing newlines from input string")
introduced a crash in eof-exit.exp. This patch fixes the problem by
adding a NULL check in the appropriate spot.
Regression tested on x86-64 Fedora 38. I'm checking this in.
---
gdb/event-top.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
@@ -254,10 +254,13 @@ gdb_rl_callback_handler (char *rl) noexcept
/* In bracketed paste mode, pasting a complete line can result in a
literal newline appearing at the end of LINE. However, we never
want this in gdb. */
- size_t len = strlen (rl);
- while (len > 0 && (rl[len - 1] == '\r' || rl[len - 1] == '\n'))
- --len;
- rl[len] = '\0';
+ if (rl != nullptr)
+ {
+ size_t len = strlen (rl);
+ while (len > 0 && (rl[len - 1] == '\r' || rl[len - 1] == '\n'))
+ --len;
+ rl[len] = '\0';
+ }
try
{