diff mbox series

[1/2] doc: add the missing 'handle' attribute in xml

Message ID 20240402102020.2521082-1-tankut.baris.aktemur@intel.com
State New
Headers
Series [1/2] doc: add the missing 'handle' attribute in xml |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Testing passed

Commit Message

Aktemur, Tankut Baris April 2, 2024, 10:20 a.m. UTC 
  The XML response to the "qXfer:threads:read" packet may include
a "handle" attribute.  The attribute is mentioned in the document
but not shown in the sample XML structure.  Add it.
---
 gdb/doc/gdb.texinfo | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Eli Zaretskii April 2, 2024, 12:14 p.m. UTC | #1 
> From: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
> Date: Tue,  2 Apr 2024 12:20:19 +0200
> 
> The XML response to the "qXfer:threads:read" packet may include
> a "handle" attribute.  The attribute is mentioned in the document
> but not shown in the sample XML structure.  Add it.
> ---
>  gdb/doc/gdb.texinfo | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 727f9275bfb..41a368a0194 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -48081,7 +48081,7 @@ the following structure:
>  @smallexample
>  <?xml version="1.0"?>
>  <threads>
> -    <thread id="id" core="0" name="name">
> +    <thread id="id" core="0" name="name" handle="XX...">
>      ... description ...
>      </thread>
>  </threads>

Thanks, but can we put some string without dots there?  IOW, an
example of a real-life "handle" attribute, like the rest of the
example does?
Aktemur, Tankut Baris April 3, 2024, 2:49 p.m. UTC | #2 
> > The XML response to the "qXfer:threads:read" packet may include
> > a "handle" attribute.  The attribute is mentioned in the document
> > but not shown in the sample XML structure.  Add it.
> > ---
> >  gdb/doc/gdb.texinfo | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> > index 727f9275bfb..41a368a0194 100644
> > --- a/gdb/doc/gdb.texinfo
> > +++ b/gdb/doc/gdb.texinfo
> > @@ -48081,7 +48081,7 @@ the following structure:
> >  @smallexample
> >  <?xml version="1.0"?>
> >  <threads>
> > -    <thread id="id" core="0" name="name">
> > +    <thread id="id" core="0" name="name" handle="XX...">
> >      ... description ...
> >      </thread>
> >  </threads>
> 
> Thanks, but can we put some string without dots there?  IOW, an
> example of a real-life "handle" attribute, like the rest of the
> example does?

Thanks.  I pushed this patch with handle="1a2b3c".

-Baris


Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
diff mbox series

Patch

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 727f9275bfb..41a368a0194 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -48081,7 +48081,7 @@  the following structure:
 @smallexample
 <?xml version="1.0"?>
 <threads>
-    <thread id="id" core="0" name="name">
+    <thread id="id" core="0" name="name" handle="XX...">
     ... description ...
     </thread>
 </threads>