diff mbox series

gdb/jit: Fix missing word in comment

Message ID 20240301134752.1561639-1-hawkinsw@obs.cr
State New
Headers
Series gdb/jit: Fix missing word in comment |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 fail Patch failed to apply
linaro-tcwg-bot/tcwg_gdb_build--master-arm fail Patch failed to apply

Commit Message

Will Hawkins March 1, 2024, 1:47 p.m. UTC 
  ChangeLog:

	* gdb/jit.c: Fix missing word in code comment.

Signed-off-by: Will Hawkins <hawkinsw@obs.cr>
---

Notes:
    Sorry that this is such a minor patch. I hope it's not a waste
    of people's time. I sincerely appreciate all that every maintainer
    does to keep gdb going. I attempted to follow the contributor
    guide. Please correct me if I did something wrong. Thank you
    again for everything.

 gdb/jit.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Marchi March 1, 2024, 3:15 p.m. UTC | #1 
On 3/1/24 08:47, Will Hawkins wrote:
> ChangeLog:
> 
> 	* gdb/jit.c: Fix missing word in code comment.
> 
> Signed-off-by: Will Hawkins <hawkinsw@obs.cr>
> ---
> 
> Notes:
>     Sorry that this is such a minor patch. I hope it's not a waste
>     of people's time. I sincerely appreciate all that every maintainer
>     does to keep gdb going. I attempted to follow the contributor
>     guide. Please correct me if I did something wrong. Thank you
>     again for everything.

It's totally fine to send patches for things like that, as long as they
fix actual errors.

Note that we don't use ChangeLogs in GDB anymore, so you don't need to
write a ChangeLog entry.  If you saw a reference to ChangeLogs somewhere
in the contribution docs, please let me know so I can adjust it.

We don't use Signed-off-by tags (yet at least) to track contributions,
but it's harmless to have it there anyway, some people just add it out
of habit.  For now, we require a copyright assignment for contributions,
but since this patch can be considered trivial, it doesn't need one.  So
I'll just go ahead and push it.

Thanks,

Simon
Will Hawkins March 1, 2024, 7:58 p.m. UTC | #2 
On Fri, Mar 1, 2024 at 10:15 AM Simon Marchi <simark@simark.ca> wrote:
>
> On 3/1/24 08:47, Will Hawkins wrote:
> > ChangeLog:
> >
> >       * gdb/jit.c: Fix missing word in code comment.
> >
> > Signed-off-by: Will Hawkins <hawkinsw@obs.cr>
> > ---
> >
> > Notes:
> >     Sorry that this is such a minor patch. I hope it's not a waste
> >     of people's time. I sincerely appreciate all that every maintainer
> >     does to keep gdb going. I attempted to follow the contributor
> >     guide. Please correct me if I did something wrong. Thank you
> >     again for everything.
>
> It's totally fine to send patches for things like that, as long as they
> fix actual errors.
>

Thank you for your kindness!

> Note that we don't use ChangeLogs in GDB anymore, so you don't need to
> write a ChangeLog entry.  If you saw a reference to ChangeLogs somewhere
> in the contribution docs, please let me know so I can adjust it.

I think that I "assumed" ChangeLogs were still in use because of the
relationship between gdb and binutils (where I just a few days ago
submitted a few patches and they do want ChangeLog entries). I am
really sorry!

>
> We don't use Signed-off-by tags (yet at least) to track contributions,
> but it's harmless to have it there anyway, some people just add it out
> of habit.  For now, we require a copyright assignment for contributions,
> but since this patch can be considered trivial, it doesn't need one.  So
> I'll just go ahead and push it.
>

Absolutely understood and, again, I apologize!

I sincerely hope that I can continue to contribute and will absolutely
do the assignment if/when that happens.

Thank you again!
Will


> Thanks,
>
> Simon
diff mbox series

Patch

diff --git a/gdb/jit.c b/gdb/jit.c
index 3ca9cdabf9d..a7fd5c40f9d 100644
--- a/gdb/jit.c
+++ b/gdb/jit.c
@@ -779,8 +779,8 @@  JITed symbol file is not an object file, ignoring it.\n"));
 	     b->printable_name);
 
   /* Read the section address information out of the symbol file.  Since the
-     file is generated by the JIT at runtime, it should all of the absolute
-     addresses that we care about.  */
+     file is generated by the JIT at runtime, it should contain all of the
+     absolute addresses that we care about.  */
   section_addr_info sai;
   for (sec = nbfd->sections; sec != NULL; sec = sec->next)
     if ((bfd_section_flags (sec) & (SEC_ALLOC|SEC_LOAD)) != 0)