diff mbox series

gdbserver: require_running_or_break for the 'z' packet

Message ID 20240229153541.3057573-1-tankut.baris.aktemur@intel.com
State New
Headers
Series gdbserver: require_running_or_break for the 'z' packet |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Testing passed

Commit Message

Aktemur, Tankut Baris Feb. 29, 2024, 3:35 p.m. UTC 
  Similar to several other packages that access/modify process state,
the 'z' and 'Z' packets need to access the process.  Hence, add a
`require_running_or_break` as a pre-check.
---
 gdbserver/server.cc | 1 +
 1 file changed, 1 insertion(+)

Comments

Aktemur, Tankut Baris April 2, 2024, 8:52 a.m. UTC | #1 
Kindly pinging.

Thanks.
-Baris

On Thursday, February 29, 2024 4:36 PM, Aktemur, Tankut Baris wrote:
> Similar to several other packages that access/modify process state,
> the 'z' and 'Z' packets need to access the process.  Hence, add a
> `require_running_or_break` as a pre-check.
> ---
>  gdbserver/server.cc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/gdbserver/server.cc b/gdbserver/server.cc
> index 74c7763d777..8b9c4df50ae 100644
> --- a/gdbserver/server.cc
> +++ b/gdbserver/server.cc
> @@ -4731,6 +4731,7 @@ process_serial_event (void)
>        /* Fallthrough.  */
>      case 'z':  /* remove_ ... */
>        {
> +	require_running_or_break (cs.own_buf);
>  	char *dataptr;
>  	ULONGEST addr;
>  	int kind;
> --
> 2.34.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
diff mbox series

Patch

diff --git a/gdbserver/server.cc b/gdbserver/server.cc
index 74c7763d777..8b9c4df50ae 100644
--- a/gdbserver/server.cc
+++ b/gdbserver/server.cc
@@ -4731,6 +4731,7 @@  process_serial_event (void)
       /* Fallthrough.  */
     case 'z':  /* remove_ ... */
       {
+	require_running_or_break (cs.own_buf);
 	char *dataptr;
 	ULONGEST addr;
 	int kind;