diff mbox series

[gdb/testsuite] Remove KFAIL for PR ada/30908

Message ID 20240227112304.13299-1-tdevries@suse.de
State Committed
Headers
Series [gdb/testsuite] Remove KFAIL for PR ada/30908 |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Testing passed

Commit Message

Tom de Vries Feb. 27, 2024, 11:23 a.m. UTC 
  PR ada/30908 turns out to be a duplicate of PR ada/12607, which was fixed by
commit d56fdf1b976 ("Refine Ada overload matching").

Remove the KFAILs for PR ada/30908.

Tested on x86_64-linux.
---
 gdb/testsuite/gdb.ada/str_binop_equal.exp | 20 ++--------------
 gdb/testsuite/gdb.ada/widewide.exp        | 28 ++---------------------
 2 files changed, 4 insertions(+), 44 deletions(-)


base-commit: 54af729da143016b234750b88853209c142ae5e7

Comments

Tom Tromey Feb. 27, 2024, 2:05 p.m. UTC | #1 
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> PR ada/30908 turns out to be a duplicate of PR ada/12607, which was fixed by
Tom> commit d56fdf1b976 ("Refine Ada overload matching").

Tom> Remove the KFAILs for PR ada/30908.

Tom> Tested on x86_64-linux.

This probably needs a "Bug:" trailer?

Anyway, thank you.
Approved-By: Tom Tromey <tom@tromey.com>

Tom
diff mbox series

Patch

diff --git a/gdb/testsuite/gdb.ada/str_binop_equal.exp b/gdb/testsuite/gdb.ada/str_binop_equal.exp
index 470fda0f129..943e0a6c414 100644
--- a/gdb/testsuite/gdb.ada/str_binop_equal.exp
+++ b/gdb/testsuite/gdb.ada/str_binop_equal.exp
@@ -31,24 +31,8 @@  runto "foo_p211_061.adb:$bp_location"
 gdb_test "print my_str = my_str" \
          " = true"
 
-set kfail_re \
-    [multi_line \
-	 [string_to_regexp {Symbol: ada.strings.maps."="}] \
-	 ".*" \
-	 "\\$$decimal = false"]
-
-gdb_test_no_output "set debug expr 1"
-
-gdb_test_multiple {print my_str = "ABCD"} "" {
-    -re -wrap " = true" {
-	pass $gdb_test_name
-    }
-    -re -wrap $kfail_re {
-	kfail ada/30908 $gdb_test_name
-    }
-}
-
-gdb_test "set debug expr 0"
+gdb_test "print my_str = \"ABCD\"" \
+    " = true"
 
 gdb_test "print my_str = \"EFGH\"" \
          " = false"
diff --git a/gdb/testsuite/gdb.ada/widewide.exp b/gdb/testsuite/gdb.ada/widewide.exp
index 241f0a019c2..f1ce084667f 100644
--- a/gdb/testsuite/gdb.ada/widewide.exp
+++ b/gdb/testsuite/gdb.ada/widewide.exp
@@ -42,33 +42,9 @@  gdb_test "print my_wws(1)" "= 32 ' '"
 
 gdb_test "print my_wws(2)" "= 104 'h'"
 
-set kfail_re \
-    [multi_line \
-	 [string_to_regexp {Symbol: ada.strings.maps."="}] \
-	 ".*" \
-	 "\\$$decimal = false"]
-
-gdb_test_no_output "set debug expr 1"
-
-gdb_test_multiple {print my_wws = " helo"} "" {
-    -re -wrap " = true" {
-	pass $gdb_test_name
-    }
-    -re -wrap $kfail_re {
-	kfail ada/30908 $gdb_test_name
-    }
-}
-gdb_test_multiple {print my_ws = "wide"} "" {
-    -re -wrap " = true" {
-	pass $gdb_test_name
-    }
-    -re -wrap $kfail_re {
-	kfail ada/30908 $gdb_test_name
-    }
-}
-
-gdb_test "set debug expr 0"
+gdb_test "print my_wws = \" helo\"" " = true"
 
+gdb_test "print my_ws = \"wide\"" " = true"
 gdb_test "print my_ws = \"nope\"" " = false"
 
 gdb_test "print \"x\" & my_ws & \"y\"" " = \"xwidey\""