diff mbox series

[gdb/testsuite] Further handle long filenames in gdb.base/startup-with-shell.exp

Message ID 20240226141708.17884-1-tdevries@suse.de
State Committed
Headers
Series [gdb/testsuite] Further handle long filenames in gdb.base/startup-with-shell.exp |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 warning Patch is already merged
linaro-tcwg-bot/tcwg_gdb_build--master-arm warning Patch is already merged

Commit Message

Tom de Vries Feb. 26, 2024, 2:17 p.m. UTC 
  In commit 52498004a34 ("gdb/testsuite: handle long filenames in
gdb.base/startup-with-shell.exp") we fixed a FAIL reported by the Linaro CI:
...
(gdb) print argv[1]
$1 = 0xfffed978 "<snip>/startup-with-shell/unique-file.unique-e"...
(gdb) FAIL: gdb.base/startup-with-shell.exp: startup_with_shell = on; \
  run_args = *.unique-extension: first argument expanded
...

PR testsuite/31410 reports a similar failure:
...
(gdb) print argv[1]
$1 = 0xfffeda96 "<snip>/startup-with-shell/*.unique-extens"...
(gdb) FAIL: gdb.base/startup-with-shell.exp: startup_with_shell = off; \
  run_args = *.unique-extension: first argument not expanded
...

Fix this in the same way, using "set print characters unlimited".

Tested on x86_64-linux.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31410
---
 gdb/testsuite/gdb.base/startup-with-shell.exp | 1 +
 1 file changed, 1 insertion(+)


base-commit: 4a4fd10d1707424b9b13aa4af0cec7590c086ea0

Comments

Tom Tromey Feb. 26, 2024, 2:53 p.m. UTC | #1 
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> Fix this in the same way, using "set print characters unlimited".

Looks good to me.
Approved-By: Tom Tromey <tom@tromey.com>

Tom
diff mbox series

Patch

diff --git a/gdb/testsuite/gdb.base/startup-with-shell.exp b/gdb/testsuite/gdb.base/startup-with-shell.exp
index d5ec503dceb..670fab6a543 100644
--- a/gdb/testsuite/gdb.base/startup-with-shell.exp
+++ b/gdb/testsuite/gdb.base/startup-with-shell.exp
@@ -66,6 +66,7 @@  with_test_prefix "startup_with_shell = on; run_args = *.unique-extension" {
 
 with_test_prefix "startup_with_shell = off; run_args = *.unique-extension" {
     initial_setup_simple "off" "$unique_file_dir/*.unique-extension"
+    gdb_test_no_output "set print characters unlimited"
     gdb_test "print argv\[1\]" "\\\$$decimal = $hex \"$unique_file_dir/\\\*\.unique-extension\"" \
 	"first argument not expanded"
 }