[v5,1/3] gdb/testsuite: Fix indentation issues in gdb.dwarf2/dynarr-ptr.exp
Checks
| Context |
Check |
Description |
| linaro-tcwg-bot/tcwg_gdb_build--master-arm |
success
|
Testing passed
|
| linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 |
success
|
Testing passed
|
| linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 |
success
|
Testing passed
|
| linaro-tcwg-bot/tcwg_gdb_check--master-arm |
success
|
Testing passed
|
Commit Message
From: "Ijaz, Abdul B" <abdul.b.ijaz@intel.com>
---
gdb/testsuite/gdb.dwarf2/dynarr-ptr.exp | 136 ++++++++++++------------
1 file changed, 68 insertions(+), 68 deletions(-)
Comments
>>>>> Abdul Basit Ijaz <abdul.b.ijaz@intel.com> writes:
> From: "Ijaz, Abdul B" <abdul.b.ijaz@intel.com>
> ---
> gdb/testsuite/gdb.dwarf2/dynarr-ptr.exp | 136 ++++++++++++------------
> 1 file changed, 68 insertions(+), 68 deletions(-)
Could you put a brief description in the commit message?
It's OK with that change; you don't need to re-submit it.
Tom
Thanks for the feedback Tom.
Tom > Could you put a brief description in the commit message?
Sure I will add this to commit message before mering.
"
Improve indentation in the test file by replacing 10 spaces at second level
with 4 spaces. This helps to update the test using the right indentation
in future.
"
Best Regards
Abdul Basit
-----Original Message-----
From: Tom Tromey <tom@tromey.com>
Sent: Thursday, February 1, 2024 1:36 AM
To: Ijaz, Abdul B <abdul.b.ijaz@intel.com>
Cc: gdb-patches@sourceware.org; thiago.bauermann@linaro.org; tom@tromey.com; simark@simark.ca
Subject: Re: [PATCH v5 1/3] gdb/testsuite: Fix indentation issues in gdb.dwarf2/dynarr-ptr.exp
>>>>> Abdul Basit Ijaz <abdul.b.ijaz@intel.com> writes:
> From: "Ijaz, Abdul B" <abdul.b.ijaz@intel.com>
> ---
> gdb/testsuite/gdb.dwarf2/dynarr-ptr.exp | 136 ++++++++++++------------
> 1 file changed, 68 insertions(+), 68 deletions(-)
Could you put a brief description in the commit message?
It's OK with that change; you don't need to re-submit it.
Tom
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
@@ -133,219 +133,219 @@ gdb_test_no_output "set language ada"
# foo.three_ptr.all
gdb_test "print foo.three_ptr.all" \
- " = \\(1, 2, 3\\)"
+ " = \\(1, 2, 3\\)"
gdb_test "print foo.three_ptr.all(1)" \
- " = 1"
+ " = 1"
gdb_test "print foo.three_ptr.all(2)" \
- " = 2"
+ " = 2"
gdb_test "print foo.three_ptr.all(3)" \
- " = 3"
+ " = 3"
gdb_test "print foo.three_ptr.all'first" \
- " = 1"
+ " = 1"
gdb_test "print foo.three_ptr.all'last" \
- " = 3"
+ " = 3"
gdb_test "print foo.three_ptr.all'length" \
- " = 3"
+ " = 3"
gdb_test "ptype foo.three_ptr.all" \
- " = array \\(<>\\) of integer"
+ " = array \\(<>\\) of integer"
# foo.three_ptr
gdb_test "print foo.three_ptr(1)" \
- " = 1"
+ " = 1"
gdb_test "print foo.three_ptr(2)" \
- " = 2"
+ " = 2"
gdb_test "print foo.three_ptr(3)" \
- " = 3"
+ " = 3"
gdb_test "print foo.three_ptr'first" \
- " = 1"
+ " = 1"
gdb_test "print foo.three_ptr'last" \
- " = 3"
+ " = 3"
gdb_test "print foo.three_ptr'length" \
- " = 3"
+ " = 3"
gdb_test "ptype foo.three_ptr" \
- " = access array \\(<>\\) of integer"
+ " = access array \\(<>\\) of integer"
# foo.three_ptr_tdef.all
gdb_test "print foo.three_ptr_tdef.all" \
- " = \\(1, 2, 3\\)"
+ " = \\(1, 2, 3\\)"
gdb_test "print foo.three_ptr_tdef.all(1)" \
- " = 1"
+ " = 1"
gdb_test "print foo.three_ptr_tdef.all(2)" \
- " = 2"
+ " = 2"
gdb_test "print foo.three_ptr_tdef.all(3)" \
- " = 3"
+ " = 3"
gdb_test "print foo.three_ptr_tdef.all'first" \
- " = 1"
+ " = 1"
gdb_test "print foo.three_ptr_tdef.all'last" \
- " = 3"
+ " = 3"
gdb_test "print foo.three_ptr_tdef.all'length" \
- " = 3"
+ " = 3"
gdb_test "ptype foo.three_ptr_tdef.all" \
- " = array \\(<>\\) of integer"
+ " = array \\(<>\\) of integer"
# foo.three_ptr_tdef
gdb_test "print foo.three_ptr_tdef(1)" \
- " = 1"
+ " = 1"
gdb_test "print foo.three_ptr_tdef(2)" \
- " = 2"
+ " = 2"
gdb_test "print foo.three_ptr_tdef(3)" \
- " = 3"
+ " = 3"
gdb_test "print foo.three_ptr_tdef'first" \
- " = 1"
+ " = 1"
gdb_test "print foo.three_ptr_tdef'last" \
- " = 3"
+ " = 3"
gdb_test "print foo.three_ptr_tdef'length" \
- " = 3"
+ " = 3"
gdb_test "ptype foo.three_ptr_tdef" \
- " = access array \\(<>\\) of integer"
+ " = access array \\(<>\\) of integer"
# foo.five_ptr.all
gdb_test "print foo.five_ptr.all" \
- " = \\(2 => 5, 8, 13, 21, 34\\)"
+ " = \\(2 => 5, 8, 13, 21, 34\\)"
gdb_test "print foo.five_ptr.all(2)" \
- " = 5"
+ " = 5"
gdb_test "print foo.five_ptr.all(3)" \
- " = 8"
+ " = 8"
gdb_test "print foo.five_ptr.all(4)" \
- " = 13"
+ " = 13"
gdb_test "print foo.five_ptr.all(5)" \
- " = 21"
+ " = 21"
gdb_test "print foo.five_ptr.all(6)" \
- " = 34"
+ " = 34"
gdb_test "print foo.five_ptr.all'first" \
- " = 2"
+ " = 2"
gdb_test "print foo.five_ptr.all'last" \
- " = 6"
+ " = 6"
gdb_test "print foo.five_ptr.all'length" \
- " = 5"
+ " = 5"
gdb_test "ptype foo.five_ptr.all" \
- " = array \\(<>\\) of integer"
+ " = array \\(<>\\) of integer"
# foo.five_ptr
gdb_test "print foo.five_ptr(2)" \
- " = 5"
+ " = 5"
gdb_test "print foo.five_ptr(3)" \
- " = 8"
+ " = 8"
gdb_test "print foo.five_ptr(4)" \
- " = 13"
+ " = 13"
gdb_test "print foo.five_ptr(5)" \
- " = 21"
+ " = 21"
gdb_test "print foo.five_ptr(6)" \
- " = 34"
+ " = 34"
gdb_test "print foo.five_ptr'first" \
- " = 2"
+ " = 2"
gdb_test "print foo.five_ptr'last" \
- " = 6"
+ " = 6"
gdb_test "print foo.five_ptr'length" \
- " = 5"
+ " = 5"
gdb_test "ptype foo.five_ptr" \
- " = access array \\(<>\\) of integer"
+ " = access array \\(<>\\) of integer"
# foo.five_ptr_tdef.all
gdb_test "print foo.five_ptr_tdef.all" \
- " = \\(2 => 5, 8, 13, 21, 34\\)"
+ " = \\(2 => 5, 8, 13, 21, 34\\)"
gdb_test "print foo.five_ptr_tdef.all(2)" \
- " = 5"
+ " = 5"
gdb_test "print foo.five_ptr_tdef.all(3)" \
- " = 8"
+ " = 8"
gdb_test "print foo.five_ptr_tdef.all(4)" \
- " = 13"
+ " = 13"
gdb_test "print foo.five_ptr_tdef.all(5)" \
- " = 21"
+ " = 21"
gdb_test "print foo.five_ptr_tdef.all(6)" \
- " = 34"
+ " = 34"
gdb_test "print foo.five_ptr_tdef.all'first" \
- " = 2"
+ " = 2"
gdb_test "print foo.five_ptr_tdef.all'last" \
- " = 6"
+ " = 6"
gdb_test "print foo.five_ptr_tdef.all'length" \
- " = 5"
+ " = 5"
gdb_test "ptype foo.five_ptr_tdef.all" \
- " = array \\(<>\\) of integer"
+ " = array \\(<>\\) of integer"
# foo.five_ptr_tdef
gdb_test "print foo.five_ptr_tdef(2)" \
- " = 5"
+ " = 5"
gdb_test "print foo.five_ptr_tdef(3)" \
- " = 8"
+ " = 8"
gdb_test "print foo.five_ptr_tdef(4)" \
- " = 13"
+ " = 13"
gdb_test "print foo.five_ptr_tdef(5)" \
- " = 21"
+ " = 21"
gdb_test "print foo.five_ptr_tdef(6)" \
- " = 34"
+ " = 34"
gdb_test "print foo.five_ptr_tdef'first" \
- " = 2"
+ " = 2"
gdb_test "print foo.five_ptr_tdef'last" \
- " = 6"
+ " = 6"
gdb_test "print foo.five_ptr_tdef'length" \
- " = 5"
+ " = 5"
gdb_test "ptype foo.five_ptr_tdef" \
- " = access array \\(<>\\) of integer"
+ " = access array \\(<>\\) of integer"