[PATCH/committed] sim: ppc: return register error when unhandled

Message ID 20240111055055.29046-1-vapier@gentoo.org
State New
Headers
Series [PATCH/committed] sim: ppc: return register error when unhandled |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 warning Patch is already merged
linaro-tcwg-bot/tcwg_gdb_build--master-arm warning Patch is already merged

Commit Message

Mike Frysinger Jan. 11, 2024, 5:50 a.m. UTC
  We don't want to fallthru and use cooked_buf when we haven't initialized
it to anything.  Returning 0 indicates the register wasn't recognized.
---
 sim/ppc/psim.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
  

Patch

diff --git a/sim/ppc/psim.c b/sim/ppc/psim.c
index a08d38914eaf..645e29a636d6 100644
--- a/sim/ppc/psim.c
+++ b/sim/ppc/psim.c
@@ -889,8 +889,7 @@  psim_read_register(psim *system,
   default:
     printf_filtered("psim_read_register(processor=%p,buf=%p,reg=%s) %s\n",
 		    processor, buf, reg, "read of this register unimplemented");
-    break;
-
+    return 0;
   }
 
   /* the PSIM internal values are in host order.  To fetch raw data,
@@ -1077,8 +1076,7 @@  psim_write_register(psim *system,
     printf_filtered("psim_write_register(processor=%p,cooked_buf=%p,reg=%s) %s\n",
 		    processor, cooked_buf, reg,
 		    "read of this register unimplemented");
-    break;
-
+    return 0;
   }
 
   return description.size;