diff mbox series

[1/2] gdb: remove stale comment in value_assign

Message ID 20231218200256.28489-1-simon.marchi@efficios.com
State New
Headers
Series [1/2] gdb: remove stale comment in value_assign |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Testing passed

Commit Message

Simon Marchi Dec. 18, 2023, 8:02 p.m. UTC 
  This comment is no longer relevant, put_frame_register_bytes now accepts
the "next frame".

Change-Id: I077933a03f8bdb886f8ba10a98d1202a38bce0a9
---
 gdb/valops.c | 7 -------
 1 file changed, 7 deletions(-)


base-commit: 989ea4061f275edb85ab5de8f908be5a273bd05a

Comments

Tom Tromey Dec. 19, 2023, 3:05 p.m. UTC | #1 
>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:

Simon> This comment is no longer relevant, put_frame_register_bytes now accepts
Simon> the "next frame".

FWIW seems obvious to me.
Approved-By: Tom Tromey <tom@tromey.com>

Tom
diff mbox series

Patch

diff --git a/gdb/valops.c b/gdb/valops.c
index 21b010684af1..049314cf7db5 100644
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -1193,13 +1193,6 @@  value_assign (struct value *toval, struct value *fromval)
 
     case lval_register:
       {
-	/* Figure out which frame this register value is in.  The value
-	   holds the frame_id for the next frame, that is the frame this
-	   register value was unwound from.
-
-	   Below we will call put_frame_register_bytes which requires that
-	   we pass it the actual frame in which the register value is
-	   valid, i.e. not the next frame.  */
 	frame_info_ptr next_frame = frame_find_by_id (VALUE_NEXT_FRAME_ID (toval));
 
 	int value_reg = VALUE_REGNUM (toval);