diff mbox series

[01/29] Fix bug in cooked index scanner

Message ID	20231120-submit-domain-hacks-2-v1-1-29650d01b198@tromey.com
State	New
Headers	DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 05C6F3858D35 From: Tom Tromey <tom@tromey.com> Date: Mon, 20 Nov 2023 20:53:32 -0700 Subject: [PATCH 01/29] Fix bug in cooked index scanner MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20231120-submit-domain-hacks-2-v1-1-29650d01b198@tromey.com> References: <20231120-submit-domain-hacks-2-v1-0-29650d01b198@tromey.com> In-Reply-To: <20231120-submit-domain-hacks-2-v1-0-29650d01b198@tromey.com> To: gdb-patches@sourceware.org Precedence: list Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org
Series	Restructure symbol domains \| [00/29] Restructure symbol domains [01/29] Fix bug in cooked index scanner [02/29] Small cleanup in DWARF reader [03/29] Make nsalias.exp more reliable [04/29] Fix latent bug in mdebugread.c [05/29] Give names to unspecified types [06/29] Remove NR_DOMAINS [07/29] Simplify symbol_to_info_string [08/29] Split up a big 'if' in symtab.c [09/29] Use a .def file for domain_enum [10/29] Add two new symbol domains [11/29] Add domain_search_flags [12/29] Replace search_domain with domain_search_flags [13/29] Remove a check of VAR_DOMAIN [14/29] Introduce "scripting" domains [15/29] Use domain_search_flags in lookup_global_symbol_language [16/29] Use domain_search_flags in lookup_symbol et al [17/29] Remove some obsolete Python constants [18/29] Remove old symbol_matches_domain [19/29] Use the new symbol domains [20/29] Simplify some symbol searches in Ada code [21/29] Simplify some symbol searches in linespec.c [22/29] Only search for "main" as a function [23/29] Only look for functions in expand_symtabs_for_function [24/29] Use a function-domain search in inside_main_func [25/29] Only search types in cp_lookup_rtti_type [26/29] Only search types in lookup_typename [27/29] Only search for functions in rust_structop::evaluate_funcall [28/29] Refine search in cp_search_static_and_baseclasses [29/29] Document new Python and Guile constants

Commit Message

Tom Tromey Nov. 21, 2023, 3:53 a.m. UTC

  Testing this entire series pointed out that the cooked index scanner
disagrees with new_symbol about certain symbols.  In particular,
new_symbol has this comment:

    Ada and Fortran subprograms, whether marked external or
    not, are always stored as a global symbol, because we want

This patch updates the scanner to match.

I don't know why the current code does not cause failures.

It's maybe worth noting that incremental CU expansion -- creating
symtabs directly from the index -- would eliminate this sort of bug.
---
 gdb/dwarf2/read.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff mbox series

Patch

diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index e8ff4d8f29a..1aca36e6179 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -16303,6 +16303,12 @@  cooked_indexer::scan_attributes (dwarf2_per_cu_data *scanning_per_cu,
 	      || abbrev->tag == DW_TAG_enumeration_type
 	      || abbrev->tag == DW_TAG_enumerator))
 	*flags &= ~IS_STATIC;
+
+      /* Keep in sync with new_symbol.  */
+      if (abbrev->tag == DW_TAG_subprogram
+	  && (m_language == language_ada
+	      || m_language == language_fortran))
+	*flags &= ~IS_STATIC;
     }
 
   return info_ptr;