diff mbox series

[v2,03/18] Add a couple of bfd_cache_close calls

Message ID 20231112-t-bg-dwarf-reading-v2-3-70fb170012ba@tromey.com
State New
Headers
Series Index DWARf in the background |

Commit Message

Tom Tromey Nov. 12, 2023, 8:25 p.m. UTC 
  This adds a couple of calls to bfd_cache_close at points where a BFD
isn't actively needed by gdb.  Normally at these points, all the
needed section data is already mapped, so we can simply close the file
descriptor.  This is harmless at worst, because if this is needed
after all, the BFD file descriptor cache will reopen it.
---
 gdb/dwarf2/read.c | 4 ++++
 1 file changed, 4 insertions(+)
diff mbox series

Patch

diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index d277c21622f..a83095f8c5d 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -9187,6 +9187,8 @@  open_and_init_dwo_file (dwarf2_cu *cu, const char *dwo_name,
 
   dwarf_read_debug_printf ("DWO file found: %s", dwo_name);
 
+  bfd_cache_close (dwo_file->dbfd.get ());
+
   return dwo_file.release ();
 }
 
@@ -9479,6 +9481,8 @@  open_and_init_dwp_file (dwarf2_per_objfile *per_objfile)
 			   pulongest (dwp_file->cus ? dwp_file->cus->nr_units : 0),
 			   pulongest (dwp_file->tus ? dwp_file->tus->nr_units : 0));
 
+  bfd_cache_close (dwp_file->dbfd.get ());
+
   return dwp_file;
 }