[07/24] gdb: make get_cbfd_soname_build_id static

Message ID 20231010204213.111285-8-simon.marchi@efficios.com
State New
Headers
Series C++ification of struct so_list |

Commit Message

Simon Marchi Oct. 10, 2023, 8:40 p.m. UTC
  It is only used in solib.c.

Change-Id: I43461d13d84d65c4f6913d4033678d8983b9910b
---
 gdb/solib.c | 6 ++++--
 gdb/solib.h | 7 -------
 2 files changed, 4 insertions(+), 9 deletions(-)
  

Patch

diff --git a/gdb/solib.c b/gdb/solib.c
index a85ea5458bce..32f9aa7397c0 100644
--- a/gdb/solib.c
+++ b/gdb/solib.c
@@ -503,9 +503,11 @@  set_cbfd_soname_build_id (gdb_bfd_ref_ptr abfd,
   (*mapptr)[soname] = build_id_to_string (build_id);
 }
 
-/* See solib.h.  */
+/* If SONAME had a build-id associated with it in ABFD's registry by a
+   previous call to set_cbfd_soname_build_id then return the build-id
+   as a NULL-terminated hex string.  */
 
-gdb::unique_xmalloc_ptr<char>
+static gdb::unique_xmalloc_ptr<char>
 get_cbfd_soname_build_id (gdb_bfd_ref_ptr abfd, const char *soname)
 {
   if (abfd.get () == nullptr || soname == nullptr)
diff --git a/gdb/solib.h b/gdb/solib.h
index 50b154b2b9b6..88ade882396d 100644
--- a/gdb/solib.h
+++ b/gdb/solib.h
@@ -143,11 +143,4 @@  extern void set_cbfd_soname_build_id (gdb_bfd_ref_ptr abfd,
 				      const char *soname,
 				      const bfd_build_id *build_id);
 
-/* If SONAME had a build-id associated with it in ABFD's registry by a
-   previous call to set_cbfd_soname_build_id then return the build-id
-   as a NULL-terminated hex string.  */
-
-extern gdb::unique_xmalloc_ptr<char> get_cbfd_soname_build_id
-  (gdb_bfd_ref_ptr abfd, const char *soname);
-
 #endif /* SOLIB_H */