diff mbox series

[pushed,1/2,gdb/testsuite] Use proc readnow in two test-cases

Message ID 20230722090044.18503-1-tdevries@suse.de
State Committed
Headers
Series [pushed,1/2,gdb/testsuite] Use proc readnow in two test-cases |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 warning Patch failed to apply
linaro-tcwg-bot/tcwg_gdb_build--master-arm warning Patch failed to apply
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 warning Patch failed to apply

Commit Message

Tom de Vries July 22, 2023, 9 a.m. UTC 
  Use "require !readnow" in two test-cases, instead of the written-out variant.

Tested on x86_64-linux, with target boards unix and readnow.
---
 .../gdb.arch/arm-pthread_cond_timedwait-bt.exp        | 11 ++++-------
 gdb/testsuite/gdb.base/readnever.exp                  | 11 ++++-------
 2 files changed, 8 insertions(+), 14 deletions(-)


base-commit: 6fbe38ce1170415bc1d2fe596911a056091949de
diff mbox series

Patch

diff --git a/gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp b/gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp
index 0cf7f273b39..17f8d68b847 100644
--- a/gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp
+++ b/gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp
@@ -17,6 +17,10 @@ 
 # syscall is active. But some active syscalls keep PC pointing to the SVC
 # instruction itself.
 
+# See if we have target board readnow.exp or similar.  We're using
+# --readnever, which is not allowed in combination with --readnow.
+require !readnow
+
 standard_testfile
 
 if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \
@@ -24,13 +28,6 @@  if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \
     return
 }
 
-# See if we have target board readnow.exp or similar.
-if { [lsearch -exact $GDBFLAGS -readnow] != -1 \
-         || [lsearch -exact $GDBFLAGS --readnow] != -1 } {
-    untested "--readnever not allowed in combination with --readnow"
-    return -1
-}
-
 save_vars { GDBFLAGS } {
     append GDBFLAGS " --readnever"
     if { [clean_restart ${binfile}] == -1 } {
diff --git a/gdb/testsuite/gdb.base/readnever.exp b/gdb/testsuite/gdb.base/readnever.exp
index 765b5bda062..8a21c4117d0 100644
--- a/gdb/testsuite/gdb.base/readnever.exp
+++ b/gdb/testsuite/gdb.base/readnever.exp
@@ -13,6 +13,10 @@ 
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+# See if we have target board readnow.exp or similar.  We're using
+# --readnever, which is not allowed in combination with --readnow.
+require !readnow
+
 standard_testfile .c
 
 if { [build_executable "failed to build" $testfile $srcfile { debug }] == -1 } {
@@ -20,13 +24,6 @@  if { [build_executable "failed to build" $testfile $srcfile { debug }] == -1 } {
     return -1
 }
 
-# See if we have target board readnow.exp or similar.
-if { [lsearch -exact $GDBFLAGS -readnow] != -1 \
-	 || [lsearch -exact $GDBFLAGS --readnow] != -1 } {
-    untested "--readnever not allowed in combination with --readnow"
-    return -1
-}
-
 save_vars { GDBFLAGS } {
     append GDBFLAGS " --readnever"
     if { [clean_restart ${binfile}] == -1 } {