diff mbox series

Move allocate_stub_method to stabsread.c

Message ID 20230224205603.2765694-1-tromey@adacore.com
State New
Headers
Series Move allocate_stub_method to stabsread.c |

Commit Message

Tom Tromey Feb. 24, 2023, 8:56 p.m. UTC 
  allocate_stub_method is only called from stabsread.c, and I don't
think it will be needed anywhere else.  So, move it and make it
static.  Tested by rebuilding.
---
 gdb/gdbtypes.c  | 20 --------------------
 gdb/gdbtypes.h  |  2 --
 gdb/stabsread.c | 20 ++++++++++++++++++++
 3 files changed, 20 insertions(+), 22 deletions(-)

Comments

Tom Tromey March 10, 2023, 2:57 p.m. UTC | #1 
>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> allocate_stub_method is only called from stabsread.c, and I don't
Tom> think it will be needed anywhere else.  So, move it and make it
Tom> static.  Tested by rebuilding.

I'm checking this in.

Tom
diff mbox series

Patch

diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index f22ba44a538..32d195e27c4 100644
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -861,26 +861,6 @@  lookup_methodptr_type (struct type *to_type)
   return mtype;
 }
 
-/* Allocate a stub method whose return type is TYPE.  This apparently
-   happens for speed of symbol reading, since parsing out the
-   arguments to the method is cpu-intensive, the way we are doing it.
-   So, we will fill in arguments later.  This always returns a fresh
-   type.  */
-
-struct type *
-allocate_stub_method (struct type *type)
-{
-  struct type *mtype;
-
-  mtype = alloc_type_copy (type);
-  mtype->set_code (TYPE_CODE_METHOD);
-  mtype->set_length (1);
-  mtype->set_is_stub (true);
-  mtype->set_target_type (type);
-  /* TYPE_SELF_TYPE (mtype) = unknown yet */
-  return mtype;
-}
-
 /* See gdbtypes.h.  */
 
 bool
diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
index c2253310666..ce78f05fbc8 100644
--- a/gdb/gdbtypes.h
+++ b/gdb/gdbtypes.h
@@ -2311,8 +2311,6 @@  extern void smash_to_memberptr_type (struct type *, struct type *,
 
 extern void smash_to_methodptr_type (struct type *, struct type *);
 
-extern struct type *allocate_stub_method (struct type *);
-
 extern const char *type_name_or_error (struct type *type);
 
 struct struct_elt
diff --git a/gdb/stabsread.c b/gdb/stabsread.c
index ca9132b37d0..39bb3f32a73 100644
--- a/gdb/stabsread.c
+++ b/gdb/stabsread.c
@@ -1464,6 +1464,26 @@  error_type (const char **pp, struct objfile *objfile)
 }
 
 
+/* Allocate a stub method whose return type is TYPE.  This apparently
+   happens for speed of symbol reading, since parsing out the
+   arguments to the method is cpu-intensive, the way we are doing it.
+   So, we will fill in arguments later.  This always returns a fresh
+   type.  */
+
+static struct type *
+allocate_stub_method (struct type *type)
+{
+  struct type *mtype;
+
+  mtype = alloc_type_copy (type);
+  mtype->set_code (TYPE_CODE_METHOD);
+  mtype->set_length (1);
+  mtype->set_is_stub (true);
+  mtype->set_target_type (type);
+  /* TYPE_SELF_TYPE (mtype) = unknown yet */
+  return mtype;
+}
+
 /* Read type information or a type definition; return the type.  Even
    though this routine accepts either type information or a type
    definition, the distinction is relevant--some parts of stabsread.c