diff mbox series

[34/47] Fully qualify calls to copy in value.c

Message ID	20230209-submit-value-fixups-2023-v1-34-55dc2794dbb9@tromey.com
State	New
Headers	DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 59BDA3858C50 From: Tom Tromey <tom@tromey.com> Date: Thu, 09 Feb 2023 14:38:55 -0700 Subject: [PATCH 34/47] Fully qualify calls to copy in value.c MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230209-submit-value-fixups-2023-v1-34-55dc2794dbb9@tromey.com> References: <20230209-submit-value-fixups-2023-v1-0-55dc2794dbb9@tromey.com> In-Reply-To: <20230209-submit-value-fixups-2023-v1-0-55dc2794dbb9@tromey.com> To: gdb-patches@sourceware.org Precedence: list Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org>
Series	Use methods for struct value \| [00/47] Use methods for struct value [01/47] Rename all fields of struct value [02/47] Move ~value body out-of-line [03/47] Move struct value to value.h [04/47] Turn value_type into method [05/47] Turn deprecated_set_value_type into a method [06/47] Turn value_arch into method [07/47] Turn value_bitsize into method [08/47] Turn value_bitpos into method [09/47] Turn value_parent into method [10/47] Turn value_offset into method [11/47] Turn deprecated_value_modifiable into method [12/47] Turn value_enclosing_type into method [13/47] Turn some value offset functions into method [14/47] Turn value_lazy and set_value_lazy functions into methods [15/47] Turn value_stack and set_value_stack functions into methods [16/47] Turn value_computed_closure and value_computed_funcs functions into methods [17/47] Convert value_lval_const and deprecated_lval_hack to methods [18/47] Turn value_initialized and set_value_initialized functions into methods [19/47] Turn value_address and set_value_address functions into methods [20/47] Turn more deprecated_* functions into methods [21/47] Turn allocate_value_lazy into a static "constructor" [22/47] Turn allocate_value into a static "constructor" [23/47] Turn allocate_computed_value into static "constructor" [24/47] Turn allocate_optimized_out_value into static "constructor" [25/47] Turn value_zero into static "constructor" [26/47] Turn some value_contents functions into methods [27/47] Turn value_fetch_lazy into a method [28/47] Turn allocate_value_contents into a method [29/47] Turn value_contents_eq into a method [30/47] Turn value_bits_synthetic_pointer into a method [31/47] Move value_ref_policy methods out-of-line [32/47] Turn value_incref and value_decref into methods [33/47] Turn remaining value_contents functions into methods [34/47] Fully qualify calls to copy in value.c [35/47] Turn value_copy into a method [36/47] Turn many optimized-out value functions into methods [37/47] Turn value_non_lval and value_force_lval into methods [38/47] Turn set_value_component_location into method [39/47] Change some code to use value methods [40/47] Turn some xmethod functions into methods [41/47] Turn preserve_one_value into method [42/47] Turn various value copying-related functions into methods [43/47] Add value::set_modifiable [44/47] Make struct value data members private [45/47] Make ~value private [46/47] Introduce set_lval method on value [47/47] Remove deprecated_lval_hack

Commit Message

Tom Tromey Feb. 9, 2023, 9:38 p.m. UTC

  A coming patch will add value::copy, so this namespace-qualifies
existing calls to 'copy' in value.c, to ensure it will still compile
after that change is done.
---
 gdb/value.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff mbox series

Patch

diff --git a/gdb/value.c b/gdb/value.c
index a17a3bd8e8d..81199ab4b9a 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -1088,7 +1088,7 @@  value_contents_copy_raw (struct value *dst, LONGEST dst_offset,
   gdb::array_view<const gdb_byte> src_contents
     = src->contents_all_raw ().slice (src_offset * unit_size,
 					  length * unit_size);
-  copy (src_contents, dst_contents);
+  gdb::copy (src_contents, dst_contents);
 
   /* Copy the meta-data, adjusted.  */
   src_bit_offset = src_offset * unit_size * HOST_CHAR_BIT;
@@ -1425,7 +1425,7 @@  value_copy (const value *arg)
       ULONGEST length = arg->enclosing_type ()->length ();
       const auto &arg_view
 	= gdb::make_array_view (arg->m_contents.get (), length);
-      copy (arg_view, val->contents_all_raw ());
+      gdb::copy (arg_view, val->contents_all_raw ());
     }
 
   val->m_parent = arg->m_parent;
@@ -1468,7 +1468,7 @@  value_non_lval (struct value *arg)
       struct type *enc_type = arg->enclosing_type ();
       struct value *val = value::allocate (enc_type);
 
-      copy (arg->contents_all (), val->contents_all_raw ());
+      gdb::copy (arg->contents_all (), val->contents_all_raw ());
       val->m_type = arg->m_type;
       val->set_embedded_offset (arg->embedded_offset ());
       val->set_pointed_to_offset (arg->pointed_to_offset ());