Message ID | 20221004170747.154307-8-blarsen@redhat.com |
---|---|
State | Committed |
Headers |
Return-Path: <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CCA0138515D0 for <patchwork@sourceware.org>; Tue, 4 Oct 2022 17:09:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CCA0138515D0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664903382; bh=jZUJA6PKWDoWCJY235cfTtPalYQJ8wyz4LzV/xds0p8=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=rwX264zCI2moHuRbm4r4SNNcHShK5e9KtU64Tw0JmS8kv/SE2x0F2ZfyaT9nFPZ44 onsMA2Vv6W8q0frwxEf2QOwF0nw7MxnL0ZEOhQnN8kHMZwDAeIlPxHk+R9/klCLjEa dIQYNkZqSF4LsZodMELna82CaW4kPtfjx1XVyIk8= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 2B3A93858014 for <gdb-patches@sourceware.org>; Tue, 4 Oct 2022 17:08:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2B3A93858014 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-637-7SY2q7-1PHy2GAPXlTvaeg-1; Tue, 04 Oct 2022 13:08:13 -0400 X-MC-Unique: 7SY2q7-1PHy2GAPXlTvaeg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5C2F81C05146 for <gdb-patches@sourceware.org>; Tue, 4 Oct 2022 17:08:13 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.40.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CD4F6492B04; Tue, 4 Oct 2022 17:08:12 +0000 (UTC) To: gdb-patches@sourceware.org Subject: [PATCH 06/11] gdb/testsuite: add XFAIL to gdb.cp/ptype-flags.exp when using clang Date: Tue, 4 Oct 2022 19:07:42 +0200 Message-Id: <20221004170747.154307-8-blarsen@redhat.com> In-Reply-To: <20221004170747.154307-1-blarsen@redhat.com> References: <20221004170747.154307-1-blarsen@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> From: Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> Reply-To: Bruno Larsen <blarsen@redhat.com> Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
Cleanup gdb.cp tests when running with clang
|
|
Commit Message
Guinevere Larsen
Oct. 4, 2022, 5:07 p.m. UTC
When running gdb.cp/ptype-flags.exp using clang, we get an unexpected failure when printing the type of a class with an internal typedef. This happens because clang doesn't add accessibility information for typedefs inside classes (see https://github.com/llvm/llvm-project/issues/57608 for more info). To help with clang testing, an XFAIL was added to this test. --- gdb/testsuite/gdb.cp/ptype-flags.exp | 12 ++++++++++++ 1 file changed, 12 insertions(+)
Comments
Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes: > When running gdb.cp/ptype-flags.exp using clang, we get an unexpected > failure when printing the type of a class with an internal typedef. This > happens because clang doesn't add accessibility information for typedefs > inside classes (see https://github.com/llvm/llvm-project/issues/57608 > for more info). To help with clang testing, an XFAIL was added to this > test. > --- > gdb/testsuite/gdb.cp/ptype-flags.exp | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/gdb/testsuite/gdb.cp/ptype-flags.exp b/gdb/testsuite/gdb.cp/ptype-flags.exp > index f88c83e03ce..e8d3f285803 100644 > --- a/gdb/testsuite/gdb.cp/ptype-flags.exp > +++ b/gdb/testsuite/gdb.cp/ptype-flags.exp > @@ -30,11 +30,18 @@ if ![runto_main] then { > return > } > > +if {[test_compiler_info {clang-*-*}]} { > + set using_clang true > +} else { > + set using_clang false > +} Missing the language for the test_compiler_info call. Looks good with that fixed. Thanks, Andrew > + > gdb_test_no_output "set language c++" "" > gdb_test_no_output "set width 0" "" > > proc do_check_holder {name {flags ""} {show_typedefs 1} {show_methods 1} > {raw 0}} { > + global using_clang > > set contents { > { base "public Base<T>" } > @@ -49,6 +56,11 @@ proc do_check_holder {name {flags ""} {show_typedefs 1} {show_methods 1} > } > > if {$show_typedefs} { > + # Clang does not add accessibility information for typedefs: > + # https://github.com/llvm/llvm-project/issues/57608 > + if {$using_clang} { > + setup_xfail "clang 57608" *-*-* > + } > lappend contents { typedef public "typedef Simple<Simple<T> > Z;" } > } > > -- > 2.37.3
On 26/10/2022 16:08, Andrew Burgess wrote: > Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes: > >> When running gdb.cp/ptype-flags.exp using clang, we get an unexpected >> failure when printing the type of a class with an internal typedef. This >> happens because clang doesn't add accessibility information for typedefs >> inside classes (see https://github.com/llvm/llvm-project/issues/57608 >> for more info). To help with clang testing, an XFAIL was added to this >> test. >> --- >> gdb/testsuite/gdb.cp/ptype-flags.exp | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/gdb/testsuite/gdb.cp/ptype-flags.exp b/gdb/testsuite/gdb.cp/ptype-flags.exp >> index f88c83e03ce..e8d3f285803 100644 >> --- a/gdb/testsuite/gdb.cp/ptype-flags.exp >> +++ b/gdb/testsuite/gdb.cp/ptype-flags.exp >> @@ -30,11 +30,18 @@ if ![runto_main] then { >> return >> } >> >> +if {[test_compiler_info {clang-*-*}]} { >> + set using_clang true >> +} else { >> + set using_clang false >> +} > Missing the language for the test_compiler_info call. Looks good with > that fixed. Great! Can I add an Approved-by tag to the patch? Cheers, Bruno > Thanks, > Andrew > >> + >> gdb_test_no_output "set language c++" "" >> gdb_test_no_output "set width 0" "" >> >> proc do_check_holder {name {flags ""} {show_typedefs 1} {show_methods 1} >> {raw 0}} { >> + global using_clang >> >> set contents { >> { base "public Base<T>" } >> @@ -49,6 +56,11 @@ proc do_check_holder {name {flags ""} {show_typedefs 1} {show_methods 1} >> } >> >> if {$show_typedefs} { >> + # Clang does not add accessibility information for typedefs: >> + # https://github.com/llvm/llvm-project/issues/57608 >> + if {$using_clang} { >> + setup_xfail "clang 57608" *-*-* >> + } >> lappend contents { typedef public "typedef Simple<Simple<T> > Z;" } >> } >> >> -- >> 2.37.3
Bruno Larsen <blarsen@redhat.com> writes: > On 26/10/2022 16:08, Andrew Burgess wrote: >> Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes: >> >>> When running gdb.cp/ptype-flags.exp using clang, we get an unexpected >>> failure when printing the type of a class with an internal typedef. This >>> happens because clang doesn't add accessibility information for typedefs >>> inside classes (see https://github.com/llvm/llvm-project/issues/57608 >>> for more info). To help with clang testing, an XFAIL was added to this >>> test. >>> --- >>> gdb/testsuite/gdb.cp/ptype-flags.exp | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/gdb/testsuite/gdb.cp/ptype-flags.exp b/gdb/testsuite/gdb.cp/ptype-flags.exp >>> index f88c83e03ce..e8d3f285803 100644 >>> --- a/gdb/testsuite/gdb.cp/ptype-flags.exp >>> +++ b/gdb/testsuite/gdb.cp/ptype-flags.exp >>> @@ -30,11 +30,18 @@ if ![runto_main] then { >>> return >>> } >>> >>> +if {[test_compiler_info {clang-*-*}]} { >>> + set using_clang true >>> +} else { >>> + set using_clang false >>> +} >> Missing the language for the test_compiler_info call. Looks good with >> that fixed. > Great! Can I add an Approved-by tag to the patch? Sure, with that fix made. Thanks, Andrew > > Cheers, > Bruno > >> Thanks, >> Andrew >> >>> + >>> gdb_test_no_output "set language c++" "" >>> gdb_test_no_output "set width 0" "" >>> >>> proc do_check_holder {name {flags ""} {show_typedefs 1} {show_methods 1} >>> {raw 0}} { >>> + global using_clang >>> >>> set contents { >>> { base "public Base<T>" } >>> @@ -49,6 +56,11 @@ proc do_check_holder {name {flags ""} {show_typedefs 1} {show_methods 1} >>> } >>> >>> if {$show_typedefs} { >>> + # Clang does not add accessibility information for typedefs: >>> + # https://github.com/llvm/llvm-project/issues/57608 >>> + if {$using_clang} { >>> + setup_xfail "clang 57608" *-*-* >>> + } >>> lappend contents { typedef public "typedef Simple<Simple<T> > Z;" } >>> } >>> >>> -- >>> 2.37.3
On 28/10/2022 13:38, Andrew Burgess wrote: > Bruno Larsen <blarsen@redhat.com> writes: > >> On 26/10/2022 16:08, Andrew Burgess wrote: >>> Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes: >>> >>>> When running gdb.cp/ptype-flags.exp using clang, we get an unexpected >>>> failure when printing the type of a class with an internal typedef. This >>>> happens because clang doesn't add accessibility information for typedefs >>>> inside classes (see https://github.com/llvm/llvm-project/issues/57608 >>>> for more info). To help with clang testing, an XFAIL was added to this >>>> test. >>>> --- >>>> gdb/testsuite/gdb.cp/ptype-flags.exp | 12 ++++++++++++ >>>> 1 file changed, 12 insertions(+) >>>> >>>> diff --git a/gdb/testsuite/gdb.cp/ptype-flags.exp b/gdb/testsuite/gdb.cp/ptype-flags.exp >>>> index f88c83e03ce..e8d3f285803 100644 >>>> --- a/gdb/testsuite/gdb.cp/ptype-flags.exp >>>> +++ b/gdb/testsuite/gdb.cp/ptype-flags.exp >>>> @@ -30,11 +30,18 @@ if ![runto_main] then { >>>> return >>>> } >>>> >>>> +if {[test_compiler_info {clang-*-*}]} { >>>> + set using_clang true >>>> +} else { >>>> + set using_clang false >>>> +} >>> Missing the language for the test_compiler_info call. Looks good with >>> that fixed. >> Great! Can I add an Approved-by tag to the patch? > Sure, with that fix made. Thanks! I pushed this patch with the change Cheers, Bruno > > Thanks, > Andrew > > >> Cheers, >> Bruno >> >>> Thanks, >>> Andrew >>> >>>> + >>>> gdb_test_no_output "set language c++" "" >>>> gdb_test_no_output "set width 0" "" >>>> >>>> proc do_check_holder {name {flags ""} {show_typedefs 1} {show_methods 1} >>>> {raw 0}} { >>>> + global using_clang >>>> >>>> set contents { >>>> { base "public Base<T>" } >>>> @@ -49,6 +56,11 @@ proc do_check_holder {name {flags ""} {show_typedefs 1} {show_methods 1} >>>> } >>>> >>>> if {$show_typedefs} { >>>> + # Clang does not add accessibility information for typedefs: >>>> + # https://github.com/llvm/llvm-project/issues/57608 >>>> + if {$using_clang} { >>>> + setup_xfail "clang 57608" *-*-* >>>> + } >>>> lappend contents { typedef public "typedef Simple<Simple<T> > Z;" } >>>> } >>>> >>>> -- >>>> 2.37.3
diff --git a/gdb/testsuite/gdb.cp/ptype-flags.exp b/gdb/testsuite/gdb.cp/ptype-flags.exp index f88c83e03ce..e8d3f285803 100644 --- a/gdb/testsuite/gdb.cp/ptype-flags.exp +++ b/gdb/testsuite/gdb.cp/ptype-flags.exp @@ -30,11 +30,18 @@ if ![runto_main] then { return } +if {[test_compiler_info {clang-*-*}]} { + set using_clang true +} else { + set using_clang false +} + gdb_test_no_output "set language c++" "" gdb_test_no_output "set width 0" "" proc do_check_holder {name {flags ""} {show_typedefs 1} {show_methods 1} {raw 0}} { + global using_clang set contents { { base "public Base<T>" } @@ -49,6 +56,11 @@ proc do_check_holder {name {flags ""} {show_typedefs 1} {show_methods 1} } if {$show_typedefs} { + # Clang does not add accessibility information for typedefs: + # https://github.com/llvm/llvm-project/issues/57608 + if {$using_clang} { + setup_xfail "clang 57608" *-*-* + } lappend contents { typedef public "typedef Simple<Simple<T> > Z;" } }