[commit#2] gdbserver <library-list> and its #FIXED version="1.0"
Commit Message
On Wed, 10 Jun 2015 18:31:21 +0200, Jan Kratochvil wrote:
> On Mon, 08 Jun 2015 11:07:56 +0200, Gary Benson wrote:
> > The "if (version)" should likely be "if (version != NULL)".
I forgot about this part. Checked in as obvious.
Jan
gdb/ChangeLog
2015-06-10 Jan Kratochvil <jan.kratochvil@redhat.com>
Code cleanup.
* solib-target.c (library_list_start_list): Use explicit NULL
comparison.
---
gdb/ChangeLog | 6 ++++++
gdb/solib-target.c | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
@@ -1,5 +1,11 @@
2015-06-10 Jan Kratochvil <jan.kratochvil@redhat.com>
+ Code cleanup.
+ * solib-target.c (library_list_start_list): Use explicit NULL
+ comparison.
+
+2015-06-10 Jan Kratochvil <jan.kratochvil@redhat.com>
+
* solib-target.c (library_list_start_list): Do not dereference
variable version in its initialization. Make the VERSION check handle
NULL.
@@ -149,7 +149,7 @@ library_list_start_list (struct gdb_xml_parser *parser,
struct gdb_xml_value *version = xml_find_attribute (attributes, "version");
/* #FIXED attribute may be omitted, Expat returns NULL in such case. */
- if (version)
+ if (version != NULL)
{
const char *string = version->value;