diff mbox

[c++,6/6] aarch64: Add cast for integer to enum cast

Message ID 1444624329-4828-6-git-send-email-simon.marchi@polymtl.ca
State New, archived
Headers

Commit Message

Simon Marchi Oct. 12, 2015, 4:32 a.m. UTC 
  /home/simark/src/binutils-gdb/gdb/aarch64-linux-tdep.c: In function ‘int aarch64_linux_syscall_record(regcache*, long unsigned int)’:
/home/simark/src/binutils-gdb/gdb/aarch64-linux-tdep.c:904:57: error: invalid conversion from ‘long unsigned int’ to ‘aarch64_syscall’ [-fpermissive]
   syscall_gdb = aarch64_canonicalize_syscall (svc_number);
                                                         ^
/home/simark/src/binutils-gdb/gdb/aarch64-linux-tdep.c:645:1: note:   initializing argument 1 of ‘gdb_syscall aarch64_canonicalize_syscall(aarch64_syscall)’
 aarch64_canonicalize_syscall (enum aarch64_syscall syscall_number)
 ^

gdb/ChangeLog:

	* aarch64-linux-tdep.c (aarch64_linux_syscall_record): Add cast.
---
 gdb/aarch64-linux-tdep.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Yao Qi Oct. 12, 2015, 10:06 a.m. UTC | #1 
Simon Marchi <simon.marchi@polymtl.ca> writes:

> diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
> index 9c3500c..82c4b84 100644
> --- a/gdb/aarch64-linux-tdep.c
> +++ b/gdb/aarch64-linux-tdep.c
> @@ -901,7 +901,8 @@ aarch64_linux_syscall_record (struct regcache *regcache,
>    int ret = 0;
>    enum gdb_syscall syscall_gdb;
>  
> -  syscall_gdb = aarch64_canonicalize_syscall (svc_number);
> +  syscall_gdb =
> +    aarch64_canonicalize_syscall ((enum aarch64_syscall) svc_number);

Patch is OK.
Simon Marchi Oct. 12, 2015, 4:26 p.m. UTC | #2 
On 12/10/15 06:06 AM, Yao Qi wrote:
> Simon Marchi <simon.marchi@polymtl.ca> writes:
> 
>> diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
>> index 9c3500c..82c4b84 100644
>> --- a/gdb/aarch64-linux-tdep.c
>> +++ b/gdb/aarch64-linux-tdep.c
>> @@ -901,7 +901,8 @@ aarch64_linux_syscall_record (struct regcache *regcache,
>>    int ret = 0;
>>    enum gdb_syscall syscall_gdb;
>>  
>> -  syscall_gdb = aarch64_canonicalize_syscall (svc_number);
>> +  syscall_gdb =
>> +    aarch64_canonicalize_syscall ((enum aarch64_syscall) svc_number);
> 
> Patch is OK.
> 

Pushed, thanks!
diff mbox

Patch

diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
index 9c3500c..82c4b84 100644
--- a/gdb/aarch64-linux-tdep.c
+++ b/gdb/aarch64-linux-tdep.c
@@ -901,7 +901,8 @@  aarch64_linux_syscall_record (struct regcache *regcache,
   int ret = 0;
   enum gdb_syscall syscall_gdb;
 
-  syscall_gdb = aarch64_canonicalize_syscall (svc_number);
+  syscall_gdb =
+    aarch64_canonicalize_syscall ((enum aarch64_syscall) svc_number);
 
   if (syscall_gdb < 0)
     {