diff mbox

[c++,5/6] aarch64: Use gdb_sys_no_syscall enum instead of -1

Message ID 1444624329-4828-5-git-send-email-simon.marchi@polymtl.ca
State New, archived
Headers

Commit Message

Simon Marchi Oct. 12, 2015, 4:32 a.m. UTC 
  Fixes:

/home/simark/src/binutils-gdb/gdb/aarch64-linux-tdep.c: In function ‘gdb_syscall aarch64_canonicalize_syscall(aarch64_syscall)’:
/home/simark/src/binutils-gdb/gdb/aarch64-linux-tdep.c:874:13: error: invalid conversion from ‘int’ to ‘gdb_syscall’ [-fpermissive]
     return -1;
             ^

gdb/ChangeLog:

	* aarch64-linux-tdep.c (aarch64_canonicalize_syscall): Return
	gdb_sys_no_syscall instead of -1.
---
 gdb/aarch64-linux-tdep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yao Qi Oct. 12, 2015, 10:01 a.m. UTC | #1 
Simon Marchi <simon.marchi@polymtl.ca> writes:

> Fixes:
>
> /home/simark/src/binutils-gdb/gdb/aarch64-linux-tdep.c: In function ‘gdb_syscall aarch64_canonicalize_syscall(aarch64_syscall)’:
> /home/simark/src/binutils-gdb/gdb/aarch64-linux-tdep.c:874:13: error: invalid conversion from ‘int’ to ‘gdb_syscall’ [-fpermissive]
>      return -1;
>              ^
>
> gdb/ChangeLog:
>
> 	* aarch64-linux-tdep.c (aarch64_canonicalize_syscall): Return
> 	gdb_sys_no_syscall instead of -1.

Patch is OK.
Simon Marchi Oct. 12, 2015, 4:26 p.m. UTC | #2 
On 12/10/15 06:01 AM, Yao Qi wrote:
> Simon Marchi <simon.marchi@polymtl.ca> writes:
> 
>> Fixes:
>>
>> /home/simark/src/binutils-gdb/gdb/aarch64-linux-tdep.c: In function ‘gdb_syscall aarch64_canonicalize_syscall(aarch64_syscall)’:
>> /home/simark/src/binutils-gdb/gdb/aarch64-linux-tdep.c:874:13: error: invalid conversion from ‘int’ to ‘gdb_syscall’ [-fpermissive]
>>      return -1;
>>              ^
>>
>> gdb/ChangeLog:
>>
>> 	* aarch64-linux-tdep.c (aarch64_canonicalize_syscall): Return
>> 	gdb_sys_no_syscall instead of -1.
> 
> Patch is OK.
> 

Pushed, thanks!
diff mbox

Patch

diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
index aaf6608..9c3500c 100644
--- a/gdb/aarch64-linux-tdep.c
+++ b/gdb/aarch64-linux-tdep.c
@@ -871,7 +871,7 @@  aarch64_canonicalize_syscall (enum aarch64_syscall syscall_number)
       SYSCALL_MAP (move_pages);
 
   default:
-    return -1;
+    return gdb_sys_no_syscall;
   }
 }