Message ID | 1441876920-32009-1-git-send-email-mihail.nistor@freescale.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 114746 invoked by alias); 10 Sep 2015 09:22:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 113782 invoked by uid 89); 10 Sep 2015 09:22:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL, BAYES_20, RCVD_IN_DNSWL_NONE, RCVD_IN_SEMBACKSCATTER, SPF_HELO_PASS, SPF_PASS autolearn=no version=3.3.2 X-HELO: na01-bn1-obe.outbound.protection.outlook.com Received: from mail-bn1bn0102.outbound.protection.outlook.com (HELO na01-bn1-obe.outbound.protection.outlook.com) (157.56.110.102) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA256 encrypted) ESMTPS; Thu, 10 Sep 2015 09:22:17 +0000 Received: from CY1PR0301MB1531.namprd03.prod.outlook.com (10.162.165.153) by CY1PR0301MB1179.namprd03.prod.outlook.com (10.160.165.22) with Microsoft SMTP Server (TLS) id 15.1.262.15; Thu, 10 Sep 2015 09:22:15 +0000 Received: from CO2PR03CA0049.namprd03.prod.outlook.com (10.141.194.176) by CY1PR0301MB1531.namprd03.prod.outlook.com (10.162.165.153) with Microsoft SMTP Server (TLS) id 15.1.262.15; Thu, 10 Sep 2015 09:22:13 +0000 Received: from BL2FFO11OLC002.protection.gbl (2a01:111:f400:7c09::131) by CO2PR03CA0049.outlook.office365.com (2a01:111:e400:1414::48) with Microsoft SMTP Server (TLS) id 15.1.268.10 via Frontend Transport; Thu, 10 Sep 2015 09:22:13 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; freescale.mail.onmicrosoft.com; dkim=none (message not signed) header.d=none; freescale.mail.onmicrosoft.com; dmarc=none action=none header.from=freescale.com; Received-SPF: Fail (protection.outlook.com: domain of freescale.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BL2FFO11OLC002.mail.protection.outlook.com (10.173.161.186) with Microsoft SMTP Server (TLS) id 15.1.262.18 via Frontend Transport; Thu, 10 Sep 2015 09:22:13 +0000 Received: from fsr-ub1464-101.ea.freescale.net (fsr-ub1464-101.ea.freescale.net [10.171.73.71]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id t8A9MB5d001409; Thu, 10 Sep 2015 02:22:11 -0700 From: Mihail-Marian Nistor <mihail.nistor@freescale.com> To: <gdb-patches@sourceware.org> CC: Mihail-Marian Nistor <mihail.nistor@freescale.com> Subject: [PATCH] gdb/18947: [aarch64]Step into shared library is very slow. Date: Thu, 10 Sep 2015 12:22:00 +0300 Message-ID: <1441876920-32009-1-git-send-email-mihail.nistor@freescale.com> X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11OLC002; 1:JpflYGnqZNZLL33jxDjfFGPq9Fvk1Y61U9RQtcXOCrrj0vYEJ/yZogtAUtUpa3lTwg6k09xyWKxAWWnDFwaziPKFDOYEPnqAk6LH08wEDnkGNqy1ws5DHiGEf+Z9MwTsWfjIMUNYFESdVd0A3ZvY28WW1PH+h6hXKCjZM/R39pP8kjXj23zBLediPt6UPhUOdXUn1gPL94kOWhg38lDTKdJ032ZNxaibzOl8cHxSmYdXmkaWfXrkSRPwEMGvNgLlmFcGBda8VzUDeiPCK9juBNMZ4odSSNBzedYKmeZZK1e1gAIVnqbQBRUCQDJKPzbejRfgHpfRZjHZHu8FbeFMIFO8iM1Gh/tC28SGk5nQUIjBihEGTcrRJU3T1/MiUuwe72azPHOzS2SaKrDqVZXYTA== X-Forefront-Antispam-Report: CIP:192.88.158.2; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(1109001)(1110001)(339900001)(377424004)(54534003)(199003)(189002)(69596002)(5001860100001)(64706001)(33646002)(77156002)(110136002)(77096005)(92566002)(2351001)(46102003)(5007970100001)(104016003)(85426001)(68736005)(47776003)(450100001)(62966003)(50986999)(50466002)(229853001)(48376002)(105606002)(6806004)(19580405001)(50226001)(11100500001)(86362001)(87936001)(5001960100002)(4001540100001)(97736004)(107886002)(106466001)(36756003)(5003940100001)(19580395003)(81156007)(189998001)(5001830100001)(4001430100001); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR0301MB1531; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:; MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1531; 2:ofvQikSDycZCISFjHPuH+y8uloNvJhiMG2imCXPt8pSab8fMz0o42KKm8QFm2PEwgzYe566VGIdcysZnjYRVbJcqjjhf6HCidDmNIc+Iw0CzQ/t4jMq6nKSY0JC4GMuc5kr+vDTB1KoRt+K3AVH8FuchHaIgTVhHvADgK5lQN1I=; 3:Eh5M85Grz7bEodtw9zRi6pKlxw9EjF553LUZKMvORTrwlPMRyQAHu/vpB0NuDCCTNjl2p2Nrqzyy45NZLIvXujtoT6p6YzzJL1g+QPU+pRechQWHWNl0fWKiqx5AaL/3gj5TtWjxji9VNCy5+MqmzDs+6ip67T0ZBLQD1nB2b3JhVATz+BISfzCTxligieg1xW279TIkLBEcPyVMOhouKAO5jVN1kkGFHD7yk02ljE8=; 25:96ExOlgOQuAtTveXXU0yVd3luIB/WL0SQAmr3UNan9RIUK3/2Lh7StN/DBl2EPmxigPCFatSrtSApeDTYuwshIaUXFizEpyIFFs/YexnfFCZn97ARc6/QSw/Iwqf6445KTX0aOuVYpMRtYXz40QGpELuW82QSvsYLsbX147QgWNgnDr8tqA7nX23LSvCPCPAJWeULNxmBc562bctrez77MjXVIjUY9+j+6IJjeAma+VEwzHLSLV/w2h8bhoM4ch3IXFL7SaT37+G9Vjx8vyFzw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB1531; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1531; 20:CQJzV33obxUTCDthaM8gE/FHHm0xa3YOIH9p6ZAzljfyjroNPnxIscJ4jI1hbtjUGuzqtLnjWz7w4/mjh/CFwi4wg4zVX9L7pCi6rpDIAb962DrCTrF0iBJbZ/P3TEhpR6qAWBVGkm6KgMr70calj+1lsgpyq6dEeG2rGnCMu4IeJnckh4JBh4xqhA+3MTjZ0ASxtBlTn4evnGh2+IiUK2GE0r+mYrUHMD2ukMrMPf79pSmrX6FUFMN8bwMcSxvU0UoI1NSM1e9PdzC+lByvFJDNsdd3UhGHOhxRaBOkMEfNWyY8GKZeS7d80ygVaI7VuOuSD1nrDp4WyUUZpvt/N7i8hdsvo7gi3lRfmYzjchg=; 4:39TRpkpsMzL0RX23GYRDkS2vgz9cEDhY3RhuCEocPyZvDv3PJs4bYfcE+VgTkDavb6dtlb8nv+39g3avsHmxDeOoGjki2d352RVu7QFD/NTunESaPQpQtLhS4KTUNcXl/EYaMHB9mxNlQaX9CR0s385rrsSiAeQggBcPoWW7d5jMicIHfiytUcH7VdNDZbKsAwdKtgl0l2ziYRMGfne1IwoGmOw0Cpp4k2gYglWvXjJjMvwYQunCJ0YgEPtEoPPOZKcRuVUM+HYN6aQLTMAdPF7zdhFhHjXB4MI8/NBEYhzw/wB5WNC4ESu6pybfw9TY X-Microsoft-Antispam-PRVS: <CY1PR0301MB153190E8BA79FC732BB4350CE2510@CY1PR0301MB1531.namprd03.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(8121501046)(5005006)(3002001); SRVR:CY1PR0301MB1531; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0301MB1531; X-Forefront-PRVS: 06952FC175 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0301MB1531; 23:6IcJXBv1FEt5Wx13zgr7kicNrURB9OAPCWAEWmn?= =?us-ascii?Q?isyD6D9UenPyo66/KldLLffwR3r02OyQi7JLaVNYvH48a3Ot2HBnZhQ/z4Bd?= =?us-ascii?Q?ROhnxbfcu3t/jhEc+4PxYwRdN5S4N4LOkYOvQLfK4djsDWyagJXRK+kQTdc6?= =?us-ascii?Q?a/DUEzGWZ8rvzQSC73U6Jq17UfhSxVg72wy07M6PhmOFJj4+7nfSSkmktuRw?= =?us-ascii?Q?lvkkXWjuYN/pDrNvRVPqplr4QZi1HzMm8N+WndbgWrGpZjE48c4AuGTjLN2U?= =?us-ascii?Q?/lRtglxlmlgEMcFUZlKlilUFgFtj/5X2B9E+8QoyCk6HlKdoJaTel4Ab4NwG?= =?us-ascii?Q?jSbrSxSWFe+epZPGRwPvlYlZKbh08cCXDnoPD005WYxmMbTG8cCK6jeFwdxq?= =?us-ascii?Q?l0nz21AOd152xXgzSoRE94SQacZwx3J0YrbBua0sXafHurb3pw3ZR6eyGhqH?= =?us-ascii?Q?DX7DUY0ZKPzb/OsrDaR4v6takPoXcbXuTS5j/v6eoqFugSdlXXf77493b8XO?= =?us-ascii?Q?+S3sYAhWeecq603UX/FTICPTjmqbh/Oa6t3lVbKboZ8/tbtBb4Wc6dmVewXc?= =?us-ascii?Q?flgEEz+lTKTSWTxFzZTmCyHP48aUK5FK/z2Q95ESqFjQx2Jx6RArmSp3ZYX+?= =?us-ascii?Q?NXxLZ6IPoX8lEpun+UIuuKUmCZ7uJ0nqirauNqJYGBdM+mUToTUVKkf6uDCf?= =?us-ascii?Q?imgbk7cVmj8Kv2rJ83Kv8I48ACkD2RXBOheWiGrXMkRx+E//608OLyz39e0D?= =?us-ascii?Q?QnahH+V3UkGQd7x+y7E4Q7MledaFFFt+dldHyiiAYLftIuZgdVZ+t9VFWszc?= =?us-ascii?Q?QJyHG5bV3b1jLLgxXmhbzvuFlr8UkHwdjDYr7JbxH9UC0UXNLP3J7hs32Cwz?= =?us-ascii?Q?5RtHupouHOZF41V98TeTaLrvanxOUl82bozMFxotz0NC55N5+Zx/QQ5hwUdU?= =?us-ascii?Q?c4NmasL7ZxSj0YvxdgB+jAkjNbPbFl1MbEs8f64Ixw0HzEcC4P2d/ZdS900g?= =?us-ascii?Q?GSElXGrvuD1BuC/qr1rrIiCnwBrLcslgme1+PbLFY5C6A6iNRop+FulKbgY4?= =?us-ascii?Q?+7SNoFiSr18zUZl/xe5oVxmnq49wL4RkNrMTZuDUdvGj7ZiRvMSRZ5FLovXq?= =?us-ascii?Q?wwW1yFKFZFON9gB8nQRvr2xyANu7LDIPBubPZR81D4Kf4CtCau5aJIBQ6x86?= =?us-ascii?Q?j5M+RJ6ITFgqDyGpKdfi5VNfXX4PxTRXjALIA0o7X//KgYbEnD36XVr3TzwC?= =?us-ascii?Q?Yn0+/R5MAoPUmq87HFvolfetivDE4eXqmguAFqjIrBXck9LdJqg9XPSJkeJo?= =?us-ascii?Q?ujseUU5MklKwrj59mDxH+Y30=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1531; 5:TNuq/dNjx7+rIVaXTo9b8FmUnkzSGwqoputjW5st6kP6oE3htXCmjPXU/YvhG/rVazHKCZKv6kg4W9csjbR1fENw3yS2dH+GZmW77RY3PSJM4gZnXXoslFlXsPGzcEbepeWjHHDGlJhJkT4sKBp9pQ==; 24:/KwqFphJIz5j6mgWC07Pb/HzZ78sWvuyKFyatXO5aOk+Is4fLVtEY59PmrZ8UFY5EDaSSdWacRqh02gQXauh8FbmqPbRT2hIKsCJ8eKAF70=; 20:4f7WUGy7/EpGFgJFMO0SkInmn9rIEb6b32mtzq5VxiD1lLBIkiqUhyCYoyNKINfaJnZ/SMKCIPoZMDZw1d9Q0g== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2015 09:22:13.2399 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB1531 X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1179; 2:D7zljvAuKIckMp0yie/ir+bzOujxd84/dZ048AF3YmV2k8s8LNijhqqHCVaSf5UJlAkhEy3pv4UTZC99uysuihXZ74y5b0f/3JEKotZTeiFdqn8EWVPcGQphe1w547ju52dVpEtSERzlv6eDwwnGWXIGgZ1vdM+HxZs+0TQU7tw=; 23:X8KAkFcgVKu0UeESquOK5ycw6wmOp24m0kSzhjQTc5Q9GS3AZd1XjzR7tG+seNqm7YSw/4vMXr/0p7kaCFJdMcvbEm1euhnDqDSW47GjEZohrdqRdx2m/x5zexuuRQb2ZnesijAqfSf0sGgQURAX0yeqmYrCqYWuBlTjWqv4bvrBFoID30NCqwUiwM0Q3OPW X-OriginatorOrg: freescale.com |
Commit Message
Mihail-Marian Nistor
Sept. 10, 2015, 9:22 a.m. UTC
Install gdbarch_skip_solib_resolver on aarch64 GNU/Linux
gdb/ChangeLog:
2015-09-10 Mihail-Marian Nistor <mihail.nistor@freescale.com>
PR gdb/18947
* aarch64-linux-tdep.c: (aarch64_linux_init_abi): Install
glibc_skip_solib_resolver as gdbarch_skip_solib_resolver callback.
Signed-off-by: Mihail-Marian Nistor <mihail.nistor@freescale.com>
---
gdb/aarch64-linux-tdep.c | 1 +
1 file changed, 1 insertion(+)
Comments
Mihail-Marian Nistor <mihail.nistor@freescale.com> writes: Hi Mihail-Marian, > Install gdbarch_skip_solib_resolver on aarch64 GNU/Linux > > gdb/ChangeLog: > 2015-09-10 Mihail-Marian Nistor <mihail.nistor@freescale.com> > > PR gdb/18947 > * aarch64-linux-tdep.c: (aarch64_linux_init_abi): Install > glibc_skip_solib_resolver as gdbarch_skip_solib_resolver callback. The patch is OK if you run GDB testsuite for aarch64-linux, and no regressions. If you don't have an env set up for running GDB testsuite, I can test it for you.
Hi Yao, I have run GDB testsuite for aarch64 and I don't see any regression. Best regards, Mihai -----Original Message----- From: Yao Qi [mailto:qiyaoltc@gmail.com] Sent: Thursday, September 10, 2015 2:46 PM To: Nistor Mihail-MNISTOR1 <mihail.nistor@freescale.com> Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/18947: [aarch64]Step into shared library is very slow. Mihail-Marian Nistor <mihail.nistor@freescale.com> writes: Hi Mihail-Marian, > Install gdbarch_skip_solib_resolver on aarch64 GNU/Linux > > gdb/ChangeLog: > 2015-09-10 Mihail-Marian Nistor <mihail.nistor@freescale.com> > > PR gdb/18947 > * aarch64-linux-tdep.c: (aarch64_linux_init_abi): Install > glibc_skip_solib_resolver as gdbarch_skip_solib_resolver callback. The patch is OK if you run GDB testsuite for aarch64-linux, and no regressions. If you don't have an env set up for running GDB testsuite, I can test it for you. -- Yao (齐尧)
Nistor Mihail <mihail.nistor@freescale.com> writes:
> I have run GDB testsuite for aarch64 and I don't see any regression.
Great, please push your commit in then.
Hi Yao, I don't have the write access on git. Could you please put this patch on git. Best regards, Mihai -----Original Message----- From: Yao Qi [mailto:qiyaoltc@gmail.com] Sent: Thursday, September 10, 2015 4:56 PM To: Nistor Mihail-MNISTOR1 <mihail.nistor@freescale.com> Cc: Yao Qi <qiyaoltc@gmail.com>; gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/18947: [aarch64]Step into shared library is very slow. Nistor Mihail <mihail.nistor@freescale.com> writes: > I have run GDB testsuite for aarch64 and I don't see any regression. Great, please push your commit in then. -- Yao (齐尧)
Nistor Mihail <mihail.nistor@freescale.com> writes:
> I don't have the write access on git. Could you please put this patch on git.
Sure, patch is pushed into mainline. I plan to push it in to 7.10
branch too. Mihail-Marian, thanks for your contribution!
For the record, I checked that freescale has the copyright assignment,
so we can push it in.
Hi Yao, Thank you very much for your support. Best regards, Mihai -----Original Message----- From: Yao Qi [mailto:qiyaoltc@gmail.com] Sent: Friday, September 11, 2015 5:27 PM To: Nistor Mihail-MNISTOR1 <mihail.nistor@freescale.com> Cc: Yao Qi <qiyaoltc@gmail.com>; gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/18947: [aarch64]Step into shared library is very slow. Nistor Mihail <mihail.nistor@freescale.com> writes: > I don't have the write access on git. Could you please put this patch on git. Sure, patch is pushed into mainline. I plan to push it in to 7.10 branch too. Mihail-Marian, thanks for your contribution! For the record, I checked that freescale has the copyright assignment, so we can push it in. -- Yao (齐尧)
diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c index f8cf43e..07ee1ea 100644 --- a/gdb/aarch64-linux-tdep.c +++ b/gdb/aarch64-linux-tdep.c @@ -961,6 +961,7 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) /* Shared library handling. */ set_gdbarch_skip_trampoline_code (gdbarch, find_solib_trampoline_target); + set_gdbarch_skip_solib_resolver (gdbarch, glibc_skip_solib_resolver); tramp_frame_prepend_unwinder (gdbarch, &aarch64_linux_rt_sigframe);