diff mbox

Initialize `location' in gdbpy_decode_line

Message ID 1439401110-12694-1-git-send-email-keiths@redhat.com
State New, archived
Headers

Commit Message

Keith Seitz Aug. 12, 2015, 5:38 p.m. UTC 
  BuildBot flagged an uninitialized variable coming from one of the patches
in my recently committed locations/explicit patchset.

The following patch fixes this.

Ok?

gdb/ChangeLog

	* python/python.c (gdbpy_decode_line): Initialize `location' to NULL
	and only call decode_line_1 when it is non-NULL.

Comments

Doug Evans Aug. 12, 2015, 5:45 p.m. UTC | #1 
On Wed, Aug 12, 2015 at 10:38 AM, Keith Seitz <keiths@redhat.com> wrote:
> BuildBot flagged an uninitialized variable coming from one of the patches
> in my recently committed locations/explicit patchset.
>
> The following patch fixes this.
>
> Ok?
>
> gdb/ChangeLog
>
>         * python/python.c (gdbpy_decode_line): Initialize `location' to NULL
>         and only call decode_line_1 when it is non-NULL.
>
> diff --git a/gdb/python/python.c b/gdb/python/python.c
> index c28f98b..14da62c 100644
> --- a/gdb/python/python.c
> +++ b/gdb/python/python.c
> @@ -730,7 +730,7 @@ gdbpy_decode_line (PyObject *self, PyObject *args)
>    PyObject *result = NULL;
>    PyObject *return_result = NULL;
>    PyObject *unparsed = NULL;
> -  struct event_location *location;
> +  struct event_location *location = NULL;
>
>    if (! PyArg_ParseTuple (args, "|s", &arg))
>      return NULL;
> @@ -747,7 +747,7 @@ gdbpy_decode_line (PyObject *self, PyObject *args)
>
>    TRY
>      {
> -      if (arg)
> +      if (location != NULL)
>         sals = decode_line_1 (location, 0, 0, 0);
>        else
>         {

LGTM
Keith Seitz Aug. 12, 2015, 6:32 p.m. UTC | #2 
On 08/12/2015 10:45 AM, Doug Evans wrote:
> On Wed, Aug 12, 2015 at 10:38 AM, Keith Seitz <keiths@redhat.com> wrote:
>> BuildBot flagged an uninitialized variable coming from one of the patches
>> in my recently committed locations/explicit patchset.
>>
>> The following patch fixes this.
>>
>> Ok?
>>
>> gdb/ChangeLog
>>
>>         * python/python.c (gdbpy_decode_line): Initialize `location' to NULL
>>         and only call decode_line_1 when it is non-NULL.
>>
> 
> LGTM
> 

I've pushed this. Thank you, Doug.

Keith
diff mbox

Patch

diff --git a/gdb/python/python.c b/gdb/python/python.c
index c28f98b..14da62c 100644
--- a/gdb/python/python.c
+++ b/gdb/python/python.c
@@ -730,7 +730,7 @@  gdbpy_decode_line (PyObject *self, PyObject *args)
   PyObject *result = NULL;
   PyObject *return_result = NULL;
   PyObject *unparsed = NULL;
-  struct event_location *location;
+  struct event_location *location = NULL;
 
   if (! PyArg_ParseTuple (args, "|s", &arg))
     return NULL;
@@ -747,7 +747,7 @@  gdbpy_decode_line (PyObject *self, PyObject *args)
 
   TRY
     {
-      if (arg)
+      if (location != NULL)
 	sals = decode_line_1 (location, 0, 0, 0);
       else
 	{