diff mbox

Don't check noargs in remotetimeout.exp

Message ID 1413167088-14327-1-git-send-email-yao@codesourcery.com
State New
Headers show

Commit Message

Yao Qi Oct. 13, 2014, 2:24 a.m. UTC 
The condition [target_info exists noargs] is checked when
remotetimeout.exp was added
https://sourceware.org/ml/gdb-patches/2005-02/msg00052.html

noargs means GDB does not support argument passing for inferior,
rather than doesn't support argument passing to GDB (remotetimeout.exp
passes -l to GDB).

This patch is to remove such unnecessary checking, and
remotetimeout.exp then can be run with native-gdbserver board file.

gdb/testsuite:

2014-10-13  Yao Qi  <yao@codesourcery.com>

	* gdb.base/remotetimeout.exp: Remove noargs checking.
---
 gdb/testsuite/gdb.base/remotetimeout.exp | 5 -----
 1 file changed, 5 deletions(-)

Comments

Pedro Alves Oct. 15, 2014, 2:10 p.m. UTC | #1 
On 10/13/2014 03:24 AM, Yao Qi wrote:
> The condition [target_info exists noargs] is checked when
> remotetimeout.exp was added
> https://sourceware.org/ml/gdb-patches/2005-02/msg00052.html
> 
> noargs means GDB does not support argument passing for inferior,
> rather than doesn't support argument passing to GDB (remotetimeout.exp
> passes -l to GDB).

Yeah, makes sense.

> 
> This patch is to remove such unnecessary checking, and
> remotetimeout.exp then can be run with native-gdbserver board file.
> 
> gdb/testsuite:
> 
> 2014-10-13  Yao Qi  <yao@codesourcery.com>
> 
> 	* gdb.base/remotetimeout.exp: Remove noargs checking.

LGTM.

Thanks,
Pedro Alves
Yao Qi Oct. 16, 2014, 4:57 a.m. UTC | #2 
Pedro Alves <palves@redhat.com> writes:

>> This patch is to remove such unnecessary checking, and
>> remotetimeout.exp then can be run with native-gdbserver board file.
>> 
>> gdb/testsuite:
>> 
>> 2014-10-13  Yao Qi  <yao@codesourcery.com>
>> 
>> 	* gdb.base/remotetimeout.exp: Remove noargs checking.
>
> LGTM.

Thanks, patch is pushed in.
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.base/remotetimeout.exp b/gdb/testsuite/gdb.base/remotetimeout.exp
index b19deec..c1f511c 100644
--- a/gdb/testsuite/gdb.base/remotetimeout.exp
+++ b/gdb/testsuite/gdb.base/remotetimeout.exp
@@ -21,11 +21,6 @@ 
 
 global GDBFLAGS
 
-# Skip test if target does not support argument passing.
-if [target_info exists noargs] {
-    return
-}
-
 #
 # Test that -l is processed correctly.
 #